mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
e832325e87
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1) The shared src/utils closure that blocked the platform-family moves lands on declared owners: generic host mechanics form a new private @agent-device/host-kit package between kernel and capture-kit, and capture-kit keeps capture, snapshot, and recording behavior, depending on host-kit for the mechanics it needs. tar-stream and yauzl move with the archive code. Every seam's exported subpaths are pinned in package-boundaries.test.ts, the layering model ranks the new zone, R13's allow-list names it, and each seam carries an exact eager-closure row. ADR-0019's substrate amendment describes the layout. Tests that mocked two of the moved modules separately became duplicate same-seam vi.mock factories, where the second silently replaced the first; those are merged, and the mocks that production code reaches past are pinned at their injection points instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * refactor(host-kit): one narrow capability port per export The four technical barrels (exec/fs/values/request) grouped by category rather than by capability, so a consumer needing one mechanic evaluated unrelated ones. Each export is now a single capability over the host machine: command, process, diagnostics, retry, archive, file, request, version. A port re-exports only what a consumer of that capability uses, and every port carries its own eager-closure row. Most of the old values barrel was never host mechanics. Pure record readers, config-source values, result text, memoization, async scoping, coordinate validation, and device-scope parsing touch no process, file, or environment, so they join kernel's other primitives instead. Closures fall accordingly: capture-kit's png-worker-client from 20 to 10, png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from 386 to 380. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * chore: drop the migration inventories and trim the touched comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: trim the touched host-kit and mutation-lane comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only in the touched files Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only across the touched tree Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: point the Swift parity comment at the real TS twin and test The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts, which does not exist: the module went to capture-kit while isTapPointInsideViewport itself went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at the pre-move path. Both now resolve. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: repoint comment citations at the homes this refactor moved them to The W1 move left ~20 comment citations pointing at src/utils/*.ts and src/request/*.ts paths that no longer exist. Each now names the capability port that owns the symbol, which survives further file moves: exec -> host-kit/command host-process, owner-identity -> host-kit/process diagnostics -> host-kit/diagnostics atomic-file, process-lock -> host-kit/file retry -> host-kit/retry request progress/cancel -> host-kit/request version -> host-kit/version ttl-memo, source-value, parsing, device-isolation, keyed-lock, success-text -> kernel subpaths Comment-only; no closure, budget, or behavior change. ADR citations are left as written, being dated records of the decision rather than live references. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH --------- Co-authored-by: Claude <noreply@anthropic.com>
100 lines
4.0 KiB
TypeScript
100 lines
4.0 KiB
TypeScript
import { performance } from 'node:perf_hooks';
|
|
import { runCmdSync } from '@agent-device/host-kit/command';
|
|
import { resolveCliArgv, REPO_ROOT } from './config.ts';
|
|
import type { BatchStepSpec } from './scenario.ts';
|
|
import type { CliResult } from './types.ts';
|
|
|
|
const MAX_BUFFER = 64 * 1024 * 1024;
|
|
const CLI_ARGV = resolveCliArgv();
|
|
|
|
function tryParseJson(stdout: string): unknown {
|
|
const trimmed = stdout.trim();
|
|
if (!trimmed) return undefined;
|
|
try {
|
|
return JSON.parse(trimmed);
|
|
} catch {
|
|
// Some commands print a trailing line after JSON; try the last JSON-looking block.
|
|
const start = trimmed.indexOf('{');
|
|
const end = trimmed.lastIndexOf('}');
|
|
if (start >= 0 && end > start) {
|
|
try {
|
|
return JSON.parse(trimmed.slice(start, end + 1));
|
|
} catch {
|
|
return undefined;
|
|
}
|
|
}
|
|
return undefined;
|
|
}
|
|
}
|
|
|
|
function jsonOk(json: unknown): boolean {
|
|
return !(json !== null && typeof json === 'object' && (json as { ok?: unknown }).ok === false);
|
|
}
|
|
|
|
// Invoke the built CLI once. `args` includes the command + positionals + dash-flags;
|
|
// `baseFlags` carries the isolation + device flags shared by every call.
|
|
export function invokeCli(args: string[], baseFlags: string[]): CliResult {
|
|
const full = [...CLI_ARGV, ...args, ...baseFlags, '--json'];
|
|
const t0 = performance.now();
|
|
let stdout = '';
|
|
let stderr = '';
|
|
let exitCode = -1;
|
|
try {
|
|
// allowFailure so non-zero exits are recorded as samples instead of thrown; maxBuffer
|
|
// raised because snapshot payloads exceed Node's ~1MB default.
|
|
const r = runCmdSync(process.execPath, full, {
|
|
cwd: REPO_ROOT,
|
|
maxBuffer: MAX_BUFFER,
|
|
allowFailure: true,
|
|
});
|
|
stdout = r.stdout;
|
|
stderr = r.stderr;
|
|
exitCode = r.exitCode;
|
|
} catch (error) {
|
|
// Spawn-level failures (missing executable, timeout) — record as a failed sample.
|
|
stderr = error instanceof Error ? error.message : String(error);
|
|
}
|
|
const wallClockMs = performance.now() - t0;
|
|
const json = tryParseJson(stdout);
|
|
return { exitCode, wallClockMs, stdout, stderr, json, ok: exitCode === 0 && jsonOk(json) };
|
|
}
|
|
|
|
// Wrap a single command in its own `batch` invocation to read per-step durationMs.
|
|
export function invokeBatchStep(spec: BatchStepSpec, baseFlags: string[]): CliResult {
|
|
const result = invokeCli(['batch', '--steps', JSON.stringify([spec])], baseFlags);
|
|
// Defensive: today's stop-only batch surfaces a failed step as a top-level non-zero/ok:false
|
|
// (already caught by invokeCli). But if a future on-error mode keeps the batch ok while a step
|
|
// fails, don't silently count that step as a success — downgrade ok from the step's own ok.
|
|
const stepOk = firstBatchResult(result.json)?.ok;
|
|
if (result.ok && stepOk === false) {
|
|
return { ...result, ok: false };
|
|
}
|
|
return result;
|
|
}
|
|
|
|
function firstBatchResult(json: unknown): Record<string, unknown> | undefined {
|
|
const data = (json as { data?: { results?: unknown[] } } | undefined)?.data;
|
|
const first = data?.results?.[0];
|
|
return first && typeof first === 'object' ? (first as Record<string, unknown>) : undefined;
|
|
}
|
|
|
|
export function readBatchStepDurationMs(result: CliResult): number | undefined {
|
|
const v = firstBatchResult(result.json)?.durationMs;
|
|
return typeof v === 'number' ? v : undefined;
|
|
}
|
|
|
|
export function readBatchStepError(result: CliResult): { code?: string; message?: string } {
|
|
const err = (result.json as { error?: { code?: string; message?: string } } | undefined)?.error;
|
|
return { code: err?.code, message: err?.message };
|
|
}
|
|
|
|
// Proxy for a11y-tree size: snapshot node count (falls back to distinct @eN refs).
|
|
export function countElements(result: CliResult): number | undefined {
|
|
const stepData = firstBatchResult(result.json)?.data;
|
|
if (stepData === undefined || typeof stepData !== 'object') return undefined;
|
|
const nodes = (stepData as { nodes?: unknown }).nodes;
|
|
if (Array.isArray(nodes)) return nodes.length;
|
|
const matches = JSON.stringify(stepData).match(/@e\d+/g);
|
|
return matches ? new Set(matches).size : 0;
|
|
}
|