Files
Michał Pierzchała e832325e87 refactor(substrate): split host mechanics into @agent-device/host-kit capability ports (#2088)
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1)

The shared src/utils closure that blocked the platform-family moves lands
on declared owners: generic host mechanics form a new private
@agent-device/host-kit package between kernel and capture-kit, and
capture-kit keeps capture, snapshot, and recording behavior, depending on
host-kit for the mechanics it needs. tar-stream and yauzl move with the
archive code.

Every seam's exported subpaths are pinned in package-boundaries.test.ts,
the layering model ranks the new zone, R13's allow-list names it, and each
seam carries an exact eager-closure row. ADR-0019's substrate amendment
describes the layout.

Tests that mocked two of the moved modules separately became duplicate
same-seam vi.mock factories, where the second silently replaced the first;
those are merged, and the mocks that production code reaches past are
pinned at their injection points instead.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* refactor(host-kit): one narrow capability port per export

The four technical barrels (exec/fs/values/request) grouped by category
rather than by capability, so a consumer needing one mechanic evaluated
unrelated ones. Each export is now a single capability over the host
machine: command, process, diagnostics, retry, archive, file, request,
version. A port re-exports only what a consumer of that capability uses,
and every port carries its own eager-closure row.

Most of the old values barrel was never host mechanics. Pure record
readers, config-source values, result text, memoization, async scoping,
coordinate validation, and device-scope parsing touch no process, file, or
environment, so they join kernel's other primitives instead.

Closures fall accordingly: capture-kit's png-worker-client from 20 to 10,
png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from
386 to 380.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* chore: drop the migration inventories and trim the touched comments

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* docs: trim the touched host-kit and mutation-lane comments

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* docs: keep tool directives only in the touched files

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* docs: keep tool directives only across the touched tree

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* fix: point the Swift parity comment at the real TS twin and test

The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts,
which does not exist: the module went to capture-kit while isTapPointInsideViewport itself
went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at
the pre-move path. Both now resolve.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* fix: repoint comment citations at the homes this refactor moved them to

The W1 move left ~20 comment citations pointing at src/utils/*.ts and
src/request/*.ts paths that no longer exist. Each now names the capability
port that owns the symbol, which survives further file moves:

  exec -> host-kit/command          host-process, owner-identity -> host-kit/process
  diagnostics -> host-kit/diagnostics   atomic-file, process-lock -> host-kit/file
  retry -> host-kit/retry           request progress/cancel -> host-kit/request
  version -> host-kit/version       ttl-memo, source-value, parsing, device-isolation,
                                    keyed-lock, success-text -> kernel subpaths

Comment-only; no closure, budget, or behavior change. ADR citations are left
as written, being dated records of the decision rather than live references.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-08-28 07:46:48 +02:00

65 lines
2.4 KiB
TypeScript

import assert from 'node:assert/strict';
import fs from 'node:fs';
import path from 'node:path';
import { test } from 'node:test';
import { workspaceSpecifierTargets } from '../layering/package-boundaries.ts';
import { workspaceSourceAliases } from './workspace-aliases.ts';
const repoRoot = path.resolve(import.meta.dirname, '../..');
test('Stryker aliases every exported workspace subpath exactly', () => {
const targets = workspaceSpecifierTargets(repoRoot);
const aliases = workspaceSourceAliases(repoRoot, 'tracked-manifests');
for (const [specifier, target] of targets) {
const matches = aliases.filter(({ find }) => find.test(specifier));
assert.deepEqual(
matches.map(({ replacement }) => replacement),
[path.join(repoRoot, target)],
`${specifier} must resolve to its own export instead of a package-root prefix`,
);
}
assert.equal(
aliases.some(({ find }) => find.test('@agent-device/selectors/not-exported')),
false,
);
});
test('disk manifests alias an untracked sandbox copy the tracked reader cannot see', () => {
fs.mkdirSync(path.join(repoRoot, '.tmp'), { recursive: true });
const sandboxRoot = fs.mkdtempSync(path.join(repoRoot, '.tmp', 'stryker-sandbox-fixture-'));
try {
const packageDir = path.join(sandboxRoot, 'packages', 'kernel');
fs.mkdirSync(path.join(packageDir, 'src'), { recursive: true });
fs.writeFileSync(
path.join(packageDir, 'package.json'),
JSON.stringify({
name: '@agent-device/kernel',
exports: { './errors': { default: './src/errors.ts' } },
}),
);
fs.writeFileSync(path.join(packageDir, 'src', 'errors.ts'), 'export const mutated = true;\n');
assert.deepEqual(
workspaceSourceAliases(sandboxRoot, 'tracked-manifests'),
[],
'the git-backed reader must see nothing in an untracked copy',
);
const diskAliases = workspaceSourceAliases(sandboxRoot, 'disk-manifests');
const match = diskAliases.filter(({ find }) => find.test('@agent-device/kernel/errors'));
assert.deepEqual(
match.map(({ replacement }) => replacement),
[path.join(sandboxRoot, 'packages', 'kernel', 'src', 'errors.ts')],
'the disk reader must resolve the specifier inside the sandbox copy',
);
assert.equal(
diskAliases.some(({ find }) => find.test('@agent-device/kernel/not-exported')),
false,
);
} finally {
fs.rmSync(sandboxRoot, { recursive: true, force: true });
}
});