mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
e832325e87
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1) The shared src/utils closure that blocked the platform-family moves lands on declared owners: generic host mechanics form a new private @agent-device/host-kit package between kernel and capture-kit, and capture-kit keeps capture, snapshot, and recording behavior, depending on host-kit for the mechanics it needs. tar-stream and yauzl move with the archive code. Every seam's exported subpaths are pinned in package-boundaries.test.ts, the layering model ranks the new zone, R13's allow-list names it, and each seam carries an exact eager-closure row. ADR-0019's substrate amendment describes the layout. Tests that mocked two of the moved modules separately became duplicate same-seam vi.mock factories, where the second silently replaced the first; those are merged, and the mocks that production code reaches past are pinned at their injection points instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * refactor(host-kit): one narrow capability port per export The four technical barrels (exec/fs/values/request) grouped by category rather than by capability, so a consumer needing one mechanic evaluated unrelated ones. Each export is now a single capability over the host machine: command, process, diagnostics, retry, archive, file, request, version. A port re-exports only what a consumer of that capability uses, and every port carries its own eager-closure row. Most of the old values barrel was never host mechanics. Pure record readers, config-source values, result text, memoization, async scoping, coordinate validation, and device-scope parsing touch no process, file, or environment, so they join kernel's other primitives instead. Closures fall accordingly: capture-kit's png-worker-client from 20 to 10, png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from 386 to 380. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * chore: drop the migration inventories and trim the touched comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: trim the touched host-kit and mutation-lane comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only in the touched files Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only across the touched tree Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: point the Swift parity comment at the real TS twin and test The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts, which does not exist: the module went to capture-kit while isTapPointInsideViewport itself went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at the pre-move path. Both now resolve. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: repoint comment citations at the homes this refactor moved them to The W1 move left ~20 comment citations pointing at src/utils/*.ts and src/request/*.ts paths that no longer exist. Each now names the capability port that owns the symbol, which survives further file moves: exec -> host-kit/command host-process, owner-identity -> host-kit/process diagnostics -> host-kit/diagnostics atomic-file, process-lock -> host-kit/file retry -> host-kit/retry request progress/cancel -> host-kit/request version -> host-kit/version ttl-memo, source-value, parsing, device-isolation, keyed-lock, success-text -> kernel subpaths Comment-only; no closure, budget, or behavior change. ADR citations are left as written, being dated records of the decision rather than live references. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH --------- Co-authored-by: Claude <noreply@anthropic.com>
44 lines
2.1 KiB
TypeScript
44 lines
2.1 KiB
TypeScript
// `pnpm check:gate-manifest` — assert every registered gate is owned and wired.
|
|
//
|
|
// Reports every failure at once, grouped by assertion, so a rewiring round sees
|
|
// the whole picture instead of one error per run.
|
|
//
|
|
// There is no `--update`: everything this command reads is either derived from the tree or
|
|
// hand-written in declarations.ts. A generated baseline is what let an earlier design
|
|
// launder a new step past review by regenerating it.
|
|
|
|
import { pathToFileURL } from 'node:url';
|
|
import { runCmdSync } from '@agent-device/host-kit/command';
|
|
import { audit, formatFailures } from './audit.ts';
|
|
import { MANUAL_ONLY_OWNERS, UNPROVABLE_OWNERS } from './declarations.ts';
|
|
import { loadModel } from './model.ts';
|
|
|
|
function main(): number {
|
|
const repoRoot = runCmdSync('git', ['rev-parse', '--show-toplevel']).stdout.trim();
|
|
const tracked = runCmdSync('git', ['ls-files'], { cwd: repoRoot })
|
|
.stdout.split('\n')
|
|
.filter(Boolean);
|
|
const model = loadModel(repoRoot, tracked);
|
|
const failures = audit(model);
|
|
if (failures.length === 0) {
|
|
const gates = model.lanes.filter((lane) => lane.qualifying).flatMap((lane) => lane.gates);
|
|
// Unprovable owners are reported rather than folded into the count: a check whose lane
|
|
// this tree cannot show running should not read the same as one it can.
|
|
const unprovable = Object.keys(UNPROVABLE_OWNERS).length;
|
|
// Manual-only checks are named, not counted: "3 manual-only" reads like a tally, while the
|
|
// ids read like the list of things nothing runs until someone dispatches them.
|
|
const manual = Object.keys(MANUAL_ONLY_OWNERS).sort();
|
|
process.stdout.write(
|
|
`gate manifest: ok — ${new Set(gates).size} checks wired across ` +
|
|
`${model.lanes.filter((lane) => lane.gates.length > 0).length} lanes` +
|
|
`${unprovable > 0 ? `, ${unprovable} declared unprovable` : ''}` +
|
|
`${manual.length > 0 ? `, manual-only: ${manual.join(', ')}` : ''}.\n`,
|
|
);
|
|
return 0;
|
|
}
|
|
process.stderr.write(formatFailures(failures));
|
|
return 1;
|
|
}
|
|
|
|
if (import.meta.url === pathToFileURL(process.argv[1] ?? '').href) process.exit(main());
|