Files
callstack__agent-device/test/integration/provider-scenarios/assertions.ts
Szymon Dziedzic 3e4828d68d feat: add scale-only screenshot sizing (#1617)
* feat: add scale-only screenshot sizing

* fix: refuse retired --max-size inputs on every released surface

Released sizing inputs must fail closed with migration guidance instead of
silently producing native-size artifacts:

- contracts: RETIRED_SCREENSHOT_MAX_SIZE declaration + SCREENSHOT_SCALE_LIMITS
  as the single source for the scale bounds and migration messages
- .ad parser: released 'screenshot ... --max-size N' and 'record start ...
  --max-size N' lines now refuse at parse time (frozen replay-compat witnesses)
- daemon: screenshot rejects old-client screenshotMaxSize like recording does;
  the recording guard now shares the same contract data
- Node client: screenshot/record daemon writers refuse the removed { maxSize }
  option before transport
- CLI: --max-size unknown-flag error carries the migration guidance
- config/env: stale screenshotMaxSize config keys and the retired
  AGENT_DEVICE_SCREENSHOT_MAX_SIZE env var are refused for sizing commands
  (other commands keep working)

Quality: numberField now reuses the canonical readOptionalNumber contract
helper (AppError bounds instead of plain Error); png-resize inlines one-use
wrappers and restores the worker-thread rationale; docs typo fixed.

* test: drop retired maxSize entries from the MCP undocumented-input allowlist

* fix: refuse retired maxSize at the MCP field-projection seam + release-provenance corpus witnesses

- readFieldInput silently dropped undeclared keys before the daemon writers
  could refuse them, so an MCP call carrying { maxSize } reached transport and
  returned native-size success. New retiredField() combinator declares the
  removed key in the field map: the projection seam refuses it with the
  canonical migration message and the JSON schema no longer advertises it.
  Real-route MCP executor regressions cover screenshot and record.
- replay-compat corpus: derived v0.20.5 witnesses for the released screenshot
  and record --max-size forms (SHA-256 pinned, new retired-capture-size
  coverage surface) so check:replay-compat proves the shipped syntax refuses
  with migration guidance instead of degrading silently.

---------

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
2026-08-06 15:11:00 +02:00

116 lines
3.7 KiB
TypeScript

import assert from 'node:assert/strict';
import fs from 'node:fs';
import { PNG } from '../../../src/utils/png.ts';
import type { ProviderScenarioRpcResult } from './harness.ts';
export function assertCommandCall(calls: readonly string[][], expected: readonly string[]): void {
assert.ok(
calls.some((call) => arrayEqual(call, expected)),
`Expected command call ${JSON.stringify(expected)} in ${JSON.stringify(calls)}`,
);
}
export function assertFlatToolCall(
calls: Array<[string, ...string[]]>,
expected: [string, ...string[]],
): void {
assert.ok(
calls.some((call) => arrayEqual(call, expected)),
`Expected tool call ${JSON.stringify(expected)} in ${JSON.stringify(calls)}`,
);
}
export function assertFlatToolCallStartsWith(
calls: Array<[string, ...string[]]>,
expected: [string, ...string[]],
): void {
assert.ok(
calls.some((call) => arrayStartsWith(call, expected)),
`Expected tool call starting with ${JSON.stringify(expected)} in ${JSON.stringify(calls)}`,
);
}
export function assertRpcOk<TData extends Record<string, unknown> = Record<string, unknown>>(
response: ProviderScenarioRpcResult,
): TData {
assert.equal(response.statusCode, 200, JSON.stringify(response.json));
assert.equal(response.json?.error, undefined, JSON.stringify(response.json));
return (response.json?.result?.data ?? {}) as TData;
}
export function assertRpcError(
response: ProviderScenarioRpcResult,
code: string,
message: RegExp,
): Record<string, unknown> {
assert.equal(response.statusCode, 200, JSON.stringify(response.json));
assert.equal(response.json?.error?.data?.code, code, JSON.stringify(response.json));
assert.match(response.json?.error?.message ?? '', message);
return (response.json?.error?.data ?? {}) as Record<string, unknown>;
}
export function assertRecordingStarted(
response: ProviderScenarioRpcResult,
options: { outPath?: string; showTouches?: boolean } = {},
): void {
const data = assertRpcOk<{
recording?: unknown;
outPath?: unknown;
showTouches?: unknown;
}>(response);
assert.equal(data.recording, 'started');
if (options.outPath !== undefined) {
assert.equal(data.outPath, options.outPath);
}
if ('showTouches' in options) {
assert.equal(data.showTouches, options.showTouches);
}
}
export function assertRecordingStopped(
response: ProviderScenarioRpcResult,
outPath: string,
options: { showTouches?: boolean } = {},
): void {
const data = assertRpcOk<{
recording?: unknown;
outPath?: unknown;
showTouches?: unknown;
artifacts?: Array<{ path?: unknown }>;
}>(response);
assert.equal(data.recording, 'stopped');
assert.equal(data.outPath, outPath);
if ('showTouches' in options) {
assert.equal(data.showTouches, options.showTouches);
}
assert.equal(data.artifacts?.[0]?.path, outPath);
}
export function arrayEqual(left: readonly string[], right: readonly string[]): boolean {
return left.length === right.length && left.every((value, index) => value === right[index]);
}
function arrayStartsWith(left: readonly string[], right: readonly string[]): boolean {
return right.every((value, index) => left[index] === value);
}
export function validPng(): Buffer {
const png = new PNG({ width: 64, height: 64 });
png.data.fill(255);
return PNG.sync.write(png);
}
function pngSignature(): Buffer {
return Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a]);
}
export function assertPngFile(filePath: string): void {
assert.deepEqual(fs.readFileSync(filePath).subarray(0, 8), pngSignature());
}
export function assertPngDimensions(filePath: string, width: number, height: number): void {
const png = PNG.sync.read(fs.readFileSync(filePath));
assert.equal(png.width, width);
assert.equal(png.height, height);
}