mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
Michał Pierzchała
cba020de21
* fix: add iOS private AX snapshot fallback * fix: add public iOS snapshot query recovery * fix(ios): make private AX snapshot fallback recover deep React Native trees Four fixes that turn the #758 private AX fallback from works-on-one-tree-shape into reliable on Bluesky Home: - Depth ladder: the AX server rejects bulk snapshot requests outright (kAXErrorIllegalArgument) once requested depth crosses a tree-size-dependent limit that moves with live content. Retry at 56/40/24/12 instead of giving up after one attempt at 64. - Real attribute identifiers: the server silently ignored the raw keypath strings the bridge passed, so every node came back with a zero frame (breaking ref taps and the interactive/compact filters, which is why 'snapshot -i -c' stayed sparse). Map keypaths through XCElementSnapshot.axAttributesForElementSnapshotKeyPaths (it returns an NSSet) and drop the mapper's expensive extras (automation type, window display id, base type) that pushed deep requests past the 30s main-thread watchdog. - Viewport from the private root frame when the public windows query degrades to an infinite viewport, so off-screen drawer content stops passing the visibility filter. - Runner source fingerprint now includes .m/.h, so bridge edits stop reusing stale cached runner builds. Also hardens the bridge per review: UInt(exactly:) for untrusted element types, pid_t-sized objc_msgSend for process id matching, and objCType-checked NSValue frame decoding. * fix(ios): recover deadline-truncated near-empty compact snapshots The all-structural sparse detector misses the common large-RN-tree case where the typed-query sweep resolves one or two stray controls before its 1s deadline: the payload has 'content', so recovery never fires, yet 2 nodes is useless in practice. Treat deadline-truncated payloads with <= 8 nodes as needing recovery, and only replace the original payload when the recovered tree actually carries more nodes. Completed sweeps on legitimately minimal screens stay untouched (not truncated). * chore: fix CI for the AX snapshot fallback branch - Sync the setup metadata script's fingerprint extension list with the runtime (.m/.h were added for the ObjC bridge), fixing the cache metadata parity test. - Reduce find.ts complexity flagged by fallow: hoist the node fetcher into createFindNodeFetcher with a recoverSparseInteractiveSnapshot helper, split match disambiguation and resolution scoring into narrowMultipleMatches/resolvedTouchScore, extract rectsMatch. * feat(ios): make accessibility fallbacks and collapsed containers visible in snapshot output Two transparency gaps from #701's 'no silent fallback' requirement: - Runner-attached snapshot messages now surface as snapshot warnings (readAppleSnapshotResult previously dropped them), so every recovery through the fallback accessibility backend or query tier is announced, states what it usually means (the app publishes an unhealthy accessibility tree - fixing the app is the real cure), and points to screenshot as visual truth. - A leaf whose label merges many comma-joined segments is flagged as a collapsed accessible container: the app marks a container accessible, hiding every descendant from assistive tech and automation alike. Nothing can be recovered below it (VoiceOver sees the same merged element), so the warning names the node, estimates the merged label count, and gives the app-side fix plus the screenshot/coordinate-tap workaround. Validated live on the lab stress fixture (adlab://stress?accessible=1): the 6-node tree now carries '@e5 [Other] merges ~126 labels...'. * fix(ios): detect sparse trees with labeled roots and surface warnings through the daemon Validated against a real-world repro (a production React Native app's login screen, simulator build provided privately by the reporter): a full-screen accessibilityViewIsModal overlay leaves the public snapshot with just Application+Window. Two gaps kept recovery off: - The sparse detector counted the Application label (the app's display name) as content and the full-screen root as hittable, so the app name alone defeated recovery. Application/Window labels and root hittability say nothing about tree health and no longer count. - Interactor-level snapshot warnings were dropped by the daemon capture chain (only the runtime/commands layer kept them); they now thread through CaptureSnapshotResult into BackendSnapshotResult. With both fixes that login screen recovers through the public query tier: 16 nodes with every control addressable (fill @ref + read-back verified), and the output carries the recovery warning. Bluesky-class trees still ladder into the private fallback unchanged.
15 lines
416 B
Objective-C
15 lines
416 B
Objective-C
#import <Foundation/Foundation.h>
|
|
#import <XCTest/XCTest.h>
|
|
|
|
NS_ASSUME_NONNULL_BEGIN
|
|
|
|
@interface RunnerAXSnapshotBridge : NSObject
|
|
|
|
+ (NSDictionary<NSString *, id> *)snapshotTreeForApplication:(XCUIApplication *)application
|
|
maxDepth:(NSInteger)maxDepth
|
|
maxNodes:(NSInteger)maxNodes;
|
|
|
|
@end
|
|
|
|
NS_ASSUME_NONNULL_END
|