mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
e832325e87
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1) The shared src/utils closure that blocked the platform-family moves lands on declared owners: generic host mechanics form a new private @agent-device/host-kit package between kernel and capture-kit, and capture-kit keeps capture, snapshot, and recording behavior, depending on host-kit for the mechanics it needs. tar-stream and yauzl move with the archive code. Every seam's exported subpaths are pinned in package-boundaries.test.ts, the layering model ranks the new zone, R13's allow-list names it, and each seam carries an exact eager-closure row. ADR-0019's substrate amendment describes the layout. Tests that mocked two of the moved modules separately became duplicate same-seam vi.mock factories, where the second silently replaced the first; those are merged, and the mocks that production code reaches past are pinned at their injection points instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * refactor(host-kit): one narrow capability port per export The four technical barrels (exec/fs/values/request) grouped by category rather than by capability, so a consumer needing one mechanic evaluated unrelated ones. Each export is now a single capability over the host machine: command, process, diagnostics, retry, archive, file, request, version. A port re-exports only what a consumer of that capability uses, and every port carries its own eager-closure row. Most of the old values barrel was never host mechanics. Pure record readers, config-source values, result text, memoization, async scoping, coordinate validation, and device-scope parsing touch no process, file, or environment, so they join kernel's other primitives instead. Closures fall accordingly: capture-kit's png-worker-client from 20 to 10, png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from 386 to 380. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * chore: drop the migration inventories and trim the touched comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: trim the touched host-kit and mutation-lane comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only in the touched files Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only across the touched tree Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: point the Swift parity comment at the real TS twin and test The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts, which does not exist: the module went to capture-kit while isTapPointInsideViewport itself went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at the pre-move path. Both now resolve. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: repoint comment citations at the homes this refactor moved them to The W1 move left ~20 comment citations pointing at src/utils/*.ts and src/request/*.ts paths that no longer exist. Each now names the capability port that owns the symbol, which survives further file moves: exec -> host-kit/command host-process, owner-identity -> host-kit/process diagnostics -> host-kit/diagnostics atomic-file, process-lock -> host-kit/file retry -> host-kit/retry request progress/cancel -> host-kit/request version -> host-kit/version ttl-memo, source-value, parsing, device-isolation, keyed-lock, success-text -> kernel subpaths Comment-only; no closure, budget, or behavior change. ADR citations are left as written, being dated records of the decision rather than live references. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH --------- Co-authored-by: Claude <noreply@anthropic.com>
175 lines
6.2 KiB
TypeScript
175 lines
6.2 KiB
TypeScript
import assert from 'node:assert/strict';
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
|
|
import type {
|
|
AgentDeviceDaemonTransport,
|
|
CaptureSnapshotResult,
|
|
} from '@agent-device/contracts/client';
|
|
import { normalizeType } from '@agent-device/contracts/snapshot';
|
|
import {
|
|
type SnapshotCaptureBackend,
|
|
type SnapshotPreferredBackend,
|
|
} from '@agent-device/kernel/snapshot';
|
|
import { SNAPSHOT_BACKEND_CAPABILITIES } from '@agent-device/capture-kit/snapshot-quality-backend-capabilities';
|
|
import { isSemanticTouchTarget } from '../../../src/core/touch-semantics.ts';
|
|
|
|
export type SnapshotBackendConformanceFixture = {
|
|
screen: string;
|
|
minimumNodeCount: number;
|
|
requiredControls: readonly SnapshotBackendControl[];
|
|
};
|
|
|
|
type SnapshotBackendControl = {
|
|
identifier: string;
|
|
label: string;
|
|
role: string;
|
|
value?: string;
|
|
interactive: boolean;
|
|
};
|
|
|
|
export const SNAPSHOT_BACKEND_CONFORMANCE_TARGETS = Object.entries(SNAPSHOT_BACKEND_CAPABILITIES)
|
|
.filter(([, capability]) => capability.forceable)
|
|
.map(([backend]) => backend as SnapshotPreferredBackend);
|
|
|
|
/**
|
|
* Test-owned transport seam for the backend conformance probe. The public SDK deliberately has
|
|
* no backend-selection option; this wrapper adds the internal daemon flag after the public client
|
|
* has projected its ordinary snapshot request. Keeping the force field here makes it impossible
|
|
* for a published CaptureSnapshotOptions or generic CommandExecutionOptions value to leak this
|
|
* evidence-only control.
|
|
*/
|
|
export function createSnapshotBackendConformanceTransport(
|
|
backend: SnapshotPreferredBackend,
|
|
transport: AgentDeviceDaemonTransport,
|
|
): AgentDeviceDaemonTransport {
|
|
return async (request, context) =>
|
|
await transport(
|
|
{
|
|
...request,
|
|
flags: {
|
|
...(request.flags ?? {}),
|
|
snapshotPreferredBackend: backend,
|
|
},
|
|
},
|
|
context,
|
|
);
|
|
}
|
|
|
|
export function loadSnapshotBackendConformanceFixture(
|
|
fixturePath = path.resolve('contracts/fixtures/ios-snapshot-backend-conformance.json'),
|
|
): SnapshotBackendConformanceFixture {
|
|
return JSON.parse(fs.readFileSync(fixturePath, 'utf8')) as SnapshotBackendConformanceFixture;
|
|
}
|
|
|
|
/**
|
|
* Checks one backend against the fixture contract. It deliberately never accepts a second
|
|
* snapshot as a comparison oracle: a backend passes only by satisfying the seeded controls,
|
|
* semantic identity, interactivity, values, and its own quality verdict.
|
|
*/
|
|
export function assertSnapshotBackendConformance(
|
|
snapshot: Pick<CaptureSnapshotResult, 'nodes' | 'snapshotQuality' | 'truncated'>,
|
|
backend: SnapshotPreferredBackend,
|
|
fixture: SnapshotBackendConformanceFixture,
|
|
): void {
|
|
const quality = snapshot.snapshotQuality;
|
|
assert.equal(
|
|
quality?.backend,
|
|
backend,
|
|
`${backend} capture must prove its backend in snapshotQuality: ${JSON.stringify(quality)}`,
|
|
);
|
|
assert.ok(
|
|
quality?.state === 'healthy' || quality?.state === 'recovered',
|
|
`${backend} capture must have a non-sparse quality verdict: ${JSON.stringify(quality)}`,
|
|
);
|
|
// The existing wire contract marks any recovered capture as truncated, including a complete
|
|
// private-AX payload selected after the XCTest channel was deferred. Assert that relationship
|
|
// instead of conflating recovery provenance with missing fixture controls.
|
|
assert.equal(
|
|
snapshot.truncated,
|
|
quality.state !== 'healthy',
|
|
`${backend} quality/truncation flags disagree: ${JSON.stringify(quality)}`,
|
|
);
|
|
assert.ok(
|
|
snapshot.nodes.length >= fixture.minimumNodeCount,
|
|
`${backend} capture returned too few nodes (${snapshot.nodes.length} < ${fixture.minimumNodeCount})`,
|
|
);
|
|
|
|
for (const expected of fixture.requiredControls) {
|
|
const node = snapshot.nodes.find((candidate) => candidate.identifier === expected.identifier);
|
|
assert.ok(
|
|
node,
|
|
`${backend} capture is missing ${expected.identifier}: ${JSON.stringify(snapshot.nodes)}`,
|
|
);
|
|
assert.equal(node.label, expected.label, `${backend} label drift for ${expected.identifier}`);
|
|
assert.equal(
|
|
canonicalRole(node.role ?? node.type ?? ''),
|
|
expected.role,
|
|
`${backend} role drift for ${expected.identifier}`,
|
|
);
|
|
assert.equal(node.enabled, true, `${backend} did not mark ${expected.identifier} enabled`);
|
|
if (expected.interactive) {
|
|
// #1933 makes iOS snapshot hittable a backend-independent geometric-actionability
|
|
// predicate: enabled, non-empty geometry whose center lies inside the viewport. It is not
|
|
// native hit-testing or occlusion evidence, but it is still a promised control invariant.
|
|
assert.equal(
|
|
isSemanticTouchTarget(node),
|
|
true,
|
|
`${backend} did not expose ${expected.identifier} as a semantic control`,
|
|
);
|
|
assert.ok(
|
|
node.rect && node.rect.width > 0 && node.rect.height > 0,
|
|
`${backend} did not expose positive interaction geometry for ${expected.identifier}`,
|
|
);
|
|
assert.equal(
|
|
typeof node.hittable,
|
|
'boolean',
|
|
`${backend} omitted its structured hittable result for ${expected.identifier}`,
|
|
);
|
|
assert.equal(
|
|
node.hittable,
|
|
true,
|
|
`${backend} did not expose ${expected.identifier} as geometrically actionable`,
|
|
);
|
|
}
|
|
if (expected.value !== undefined) {
|
|
assert.equal(node.value, expected.value, `${backend} value drift for ${expected.identifier}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
function canonicalRole(value: string): string {
|
|
const normalized = normalizeType(value);
|
|
return (
|
|
(
|
|
{
|
|
edittext: 'text-field',
|
|
textfield: 'text-field',
|
|
textarea: 'text-view',
|
|
} as Record<string, string>
|
|
)[normalized] ?? normalized
|
|
);
|
|
}
|
|
|
|
export function snapshotBackendEvidence(
|
|
snapshot: Pick<CaptureSnapshotResult, 'nodes' | 'snapshotQuality' | 'truncated'>,
|
|
backend: SnapshotCaptureBackend,
|
|
) {
|
|
return {
|
|
backend,
|
|
quality: snapshot.snapshotQuality,
|
|
nodeCount: snapshot.nodes.length,
|
|
truncated: snapshot.truncated,
|
|
controls: snapshot.nodes
|
|
.filter((node) => typeof node.identifier === 'string')
|
|
.map((node) => ({
|
|
identifier: node.identifier,
|
|
label: node.label,
|
|
role: canonicalRole(node.role ?? node.type ?? ''),
|
|
value: node.value,
|
|
enabled: node.enabled,
|
|
hittable: node.hittable,
|
|
})),
|
|
};
|
|
}
|