mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
e832325e87
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1) The shared src/utils closure that blocked the platform-family moves lands on declared owners: generic host mechanics form a new private @agent-device/host-kit package between kernel and capture-kit, and capture-kit keeps capture, snapshot, and recording behavior, depending on host-kit for the mechanics it needs. tar-stream and yauzl move with the archive code. Every seam's exported subpaths are pinned in package-boundaries.test.ts, the layering model ranks the new zone, R13's allow-list names it, and each seam carries an exact eager-closure row. ADR-0019's substrate amendment describes the layout. Tests that mocked two of the moved modules separately became duplicate same-seam vi.mock factories, where the second silently replaced the first; those are merged, and the mocks that production code reaches past are pinned at their injection points instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * refactor(host-kit): one narrow capability port per export The four technical barrels (exec/fs/values/request) grouped by category rather than by capability, so a consumer needing one mechanic evaluated unrelated ones. Each export is now a single capability over the host machine: command, process, diagnostics, retry, archive, file, request, version. A port re-exports only what a consumer of that capability uses, and every port carries its own eager-closure row. Most of the old values barrel was never host mechanics. Pure record readers, config-source values, result text, memoization, async scoping, coordinate validation, and device-scope parsing touch no process, file, or environment, so they join kernel's other primitives instead. Closures fall accordingly: capture-kit's png-worker-client from 20 to 10, png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from 386 to 380. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * chore: drop the migration inventories and trim the touched comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: trim the touched host-kit and mutation-lane comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only in the touched files Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only across the touched tree Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: point the Swift parity comment at the real TS twin and test The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts, which does not exist: the module went to capture-kit while isTapPointInsideViewport itself went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at the pre-move path. Both now resolve. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: repoint comment citations at the homes this refactor moved them to The W1 move left ~20 comment citations pointing at src/utils/*.ts and src/request/*.ts paths that no longer exist. Each now names the capability port that owns the symbol, which survives further file moves: exec -> host-kit/command host-process, owner-identity -> host-kit/process diagnostics -> host-kit/diagnostics atomic-file, process-lock -> host-kit/file retry -> host-kit/retry request progress/cancel -> host-kit/request version -> host-kit/version ttl-memo, source-value, parsing, device-isolation, keyed-lock, success-text -> kernel subpaths Comment-only; no closure, budget, or behavior change. ADR citations are left as written, being dated records of the decision rather than live references. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH --------- Co-authored-by: Claude <noreply@anthropic.com>
81 lines
3.1 KiB
TypeScript
81 lines
3.1 KiB
TypeScript
/**
|
|
* Re-derives the frozen replay-compat corpus (#1417) from git history: every
|
|
* mined entry must still be the exact blob a RELEASED tag published at the path
|
|
* it claims, and every tag the corpus cites must be a tag that was actually cut.
|
|
*
|
|
* The unit gate (`test/replay-compat/corpus.test.ts`) hashes the checked-in
|
|
* bytes against the same object ids, which catches a rewritten script; only this
|
|
* check can say those object ids came from a release rather than from whoever
|
|
* wrote the manifest line.
|
|
*/
|
|
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
import {
|
|
REPLAY_COMPAT_CORPUS,
|
|
REPLAY_COMPAT_RELEASED_TAGS,
|
|
} from '../test/replay-compat/manifest.ts';
|
|
import { findProvenanceKindViolations } from '../test/replay-compat/provenance-rules.ts';
|
|
import { runCmdSync } from '@agent-device/host-kit/command';
|
|
import { repoGit, requireUnshallowHistory } from './lib/repo-git.ts';
|
|
|
|
const repoRoot = path.resolve(import.meta.dirname, '..');
|
|
const corpusRoot = path.join(repoRoot, 'test', 'replay-compat');
|
|
|
|
const git = repoGit(repoRoot);
|
|
requireUnshallowHistory(git, 'Corpus provenance');
|
|
|
|
// An entry that escaped `mined` would also escape the history check below, so
|
|
// the area rule is enforced here as well as in the unit lane.
|
|
const failures: string[] = [...findProvenanceKindViolations(REPLAY_COMPAT_CORPUS)];
|
|
|
|
const existingTags = new Set(git(['tag', '--list']).split('\n').filter(Boolean));
|
|
if (existingTags.size === 0) {
|
|
throw new Error('No release tags found. Run `git fetch --tags` first.');
|
|
}
|
|
for (const tag of REPLAY_COMPAT_RELEASED_TAGS) {
|
|
if (!existingTags.has(tag)) {
|
|
failures.push(`${tag} is cited as a released version but is not a tag in this repository`);
|
|
}
|
|
}
|
|
|
|
for (const entry of REPLAY_COMPAT_CORPUS) {
|
|
if (!REPLAY_COMPAT_RELEASED_TAGS.includes(entry.recordedBy)) {
|
|
failures.push(
|
|
`${entry.id}: recordedBy ${entry.recordedBy} is not in REPLAY_COMPAT_RELEASED_TAGS`,
|
|
);
|
|
continue;
|
|
}
|
|
if (entry.provenance.kind !== 'mined') continue;
|
|
|
|
const { path: sourcePath, blob } = entry.provenance;
|
|
const historical = git(['rev-parse', `${entry.recordedBy}:${sourcePath}`]);
|
|
if (historical !== blob) {
|
|
failures.push(
|
|
`${entry.id}: ${entry.recordedBy}:${sourcePath} is ${historical || '<missing>'}, manifest pins ${blob}`,
|
|
);
|
|
continue;
|
|
}
|
|
const frozen = fs.readFileSync(path.join(corpusRoot, entry.file));
|
|
const released = runCmdSync('git', ['cat-file', 'blob', blob], {
|
|
cwd: repoRoot,
|
|
binaryStdout: true,
|
|
}).stdoutBuffer;
|
|
if (!released?.equals(frozen)) {
|
|
failures.push(`${entry.id}: ${entry.file} no longer matches the released blob ${blob}`);
|
|
}
|
|
}
|
|
|
|
if (failures.length > 0) {
|
|
throw new Error(
|
|
`Replay-compat corpus provenance is broken (see test/replay-compat/README.md):\n${failures
|
|
.map((failure) => `- ${failure}`)
|
|
.join('\n')}`,
|
|
);
|
|
}
|
|
|
|
const mined = REPLAY_COMPAT_CORPUS.filter((entry) => entry.provenance.kind === 'mined').length;
|
|
process.stdout.write(
|
|
`Verified ${mined} mined replay-compat scripts against their released blobs across ${REPLAY_COMPAT_RELEASED_TAGS.length} tags (${REPLAY_COMPAT_CORPUS.length - mined} derived entries are digest-pinned).\n`,
|
|
);
|