mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
e832325e87
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1) The shared src/utils closure that blocked the platform-family moves lands on declared owners: generic host mechanics form a new private @agent-device/host-kit package between kernel and capture-kit, and capture-kit keeps capture, snapshot, and recording behavior, depending on host-kit for the mechanics it needs. tar-stream and yauzl move with the archive code. Every seam's exported subpaths are pinned in package-boundaries.test.ts, the layering model ranks the new zone, R13's allow-list names it, and each seam carries an exact eager-closure row. ADR-0019's substrate amendment describes the layout. Tests that mocked two of the moved modules separately became duplicate same-seam vi.mock factories, where the second silently replaced the first; those are merged, and the mocks that production code reaches past are pinned at their injection points instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * refactor(host-kit): one narrow capability port per export The four technical barrels (exec/fs/values/request) grouped by category rather than by capability, so a consumer needing one mechanic evaluated unrelated ones. Each export is now a single capability over the host machine: command, process, diagnostics, retry, archive, file, request, version. A port re-exports only what a consumer of that capability uses, and every port carries its own eager-closure row. Most of the old values barrel was never host mechanics. Pure record readers, config-source values, result text, memoization, async scoping, coordinate validation, and device-scope parsing touch no process, file, or environment, so they join kernel's other primitives instead. Closures fall accordingly: capture-kit's png-worker-client from 20 to 10, png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from 386 to 380. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * chore: drop the migration inventories and trim the touched comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: trim the touched host-kit and mutation-lane comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only in the touched files Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only across the touched tree Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: point the Swift parity comment at the real TS twin and test The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts, which does not exist: the module went to capture-kit while isTapPointInsideViewport itself went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at the pre-move path. Both now resolve. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: repoint comment citations at the homes this refactor moved them to The W1 move left ~20 comment citations pointing at src/utils/*.ts and src/request/*.ts paths that no longer exist. Each now names the capability port that owns the symbol, which survives further file moves: exec -> host-kit/command host-process, owner-identity -> host-kit/process diagnostics -> host-kit/diagnostics atomic-file, process-lock -> host-kit/file retry -> host-kit/retry request progress/cancel -> host-kit/request version -> host-kit/version ttl-memo, source-value, parsing, device-isolation, keyed-lock, success-text -> kernel subpaths Comment-only; no closure, budget, or behavior change. ADR citations are left as written, being dated records of the decision rather than live references. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH --------- Co-authored-by: Claude <noreply@anthropic.com>
80 lines
2.9 KiB
TypeScript
80 lines
2.9 KiB
TypeScript
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import path from 'node:path';
|
|
import { pathToFileURL } from 'node:url';
|
|
import { runCmd } from '@agent-device/host-kit/command';
|
|
import { PAYLOAD_MARKER } from './support/exit-payload.ts';
|
|
|
|
const SUPPORT_DIR = path.join(import.meta.dirname, 'support');
|
|
const FIXTURE_TIMEOUT_MS = 10_000;
|
|
const STUB_DAEMON_BASE_URL = 'https://agent-device-exit-flush.test/agent-device';
|
|
|
|
// Isolates the delivery guarantee from daemon lifecycle behavior. The fixture
|
|
// writes a large payload through a real piped subprocess without asserting
|
|
// that the unsafe alternative must truncate under a particular OS, Node
|
|
// version, pipe configuration, or scheduler interleaving.
|
|
test('exitAfterFlush (the #1596 fix) delivers the full write before the process exits', async () => {
|
|
const { exitCode, stderr } = await runFixture('exit-after-flush.ts');
|
|
assert.equal(exitCode, 1);
|
|
assert.ok(
|
|
stderr.includes(PAYLOAD_MARKER),
|
|
'expected the full payload, including its trailing marker',
|
|
);
|
|
});
|
|
|
|
test('the CLI success entrypoint flushes a complete JSON envelope before exit 0', async () => {
|
|
const { exitCode, stdout } = await runFixture('exit-after-flush.ts', ['--success']);
|
|
assert.equal(exitCode, 0);
|
|
const envelope = JSON.parse(stdout) as { success?: boolean; data?: { payload?: string } };
|
|
assert.equal(envelope.success, true);
|
|
assert.equal(envelope.data?.payload?.endsWith(PAYLOAD_MARKER), true);
|
|
});
|
|
|
|
test('the real source CLI flushes a complete successful snapshot response before exit 0', async () => {
|
|
const fetchFixtureUrl = pathToFileURL(path.join(SUPPORT_DIR, 'exit-after-flush.ts')).href;
|
|
const result = await runCmd(
|
|
process.execPath,
|
|
[
|
|
'--experimental-strip-types',
|
|
'src/bin.ts',
|
|
'snapshot',
|
|
'--daemon-base-url',
|
|
STUB_DAEMON_BASE_URL,
|
|
'--daemon-auth-token',
|
|
'test-daemon-token',
|
|
'--json',
|
|
],
|
|
{
|
|
allowFailure: true,
|
|
timeoutMs: FIXTURE_TIMEOUT_MS,
|
|
env: {
|
|
...process.env,
|
|
AGENT_DEVICE_TEST_PAYLOAD_MARKER: PAYLOAD_MARKER,
|
|
NODE_OPTIONS: [process.env.NODE_OPTIONS, `--import=${fetchFixtureUrl}`]
|
|
.filter(Boolean)
|
|
.join(' '),
|
|
},
|
|
},
|
|
);
|
|
|
|
assert.equal(result.exitCode, 0, result.stderr);
|
|
const envelope = JSON.parse(result.stdout) as {
|
|
success?: boolean;
|
|
data?: { nodes?: Array<{ label?: string }> };
|
|
};
|
|
assert.equal(envelope.success, true);
|
|
assert.equal(envelope.data?.nodes?.[0]?.label?.endsWith(PAYLOAD_MARKER), true);
|
|
});
|
|
|
|
async function runFixture(
|
|
name: string,
|
|
args: string[] = [],
|
|
): Promise<{ exitCode: number; stdout: string; stderr: string }> {
|
|
const result = await runCmd(
|
|
process.execPath,
|
|
['--experimental-strip-types', path.join(SUPPORT_DIR, name), ...args],
|
|
{ allowFailure: true, timeoutMs: FIXTURE_TIMEOUT_MS },
|
|
);
|
|
return { exitCode: result.exitCode, stdout: result.stdout, stderr: result.stderr };
|
|
}
|