Files
Michał Pierzchała e832325e87 refactor(substrate): split host mechanics into @agent-device/host-kit capability ports (#2088)
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1)

The shared src/utils closure that blocked the platform-family moves lands
on declared owners: generic host mechanics form a new private
@agent-device/host-kit package between kernel and capture-kit, and
capture-kit keeps capture, snapshot, and recording behavior, depending on
host-kit for the mechanics it needs. tar-stream and yauzl move with the
archive code.

Every seam's exported subpaths are pinned in package-boundaries.test.ts,
the layering model ranks the new zone, R13's allow-list names it, and each
seam carries an exact eager-closure row. ADR-0019's substrate amendment
describes the layout.

Tests that mocked two of the moved modules separately became duplicate
same-seam vi.mock factories, where the second silently replaced the first;
those are merged, and the mocks that production code reaches past are
pinned at their injection points instead.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* refactor(host-kit): one narrow capability port per export

The four technical barrels (exec/fs/values/request) grouped by category
rather than by capability, so a consumer needing one mechanic evaluated
unrelated ones. Each export is now a single capability over the host
machine: command, process, diagnostics, retry, archive, file, request,
version. A port re-exports only what a consumer of that capability uses,
and every port carries its own eager-closure row.

Most of the old values barrel was never host mechanics. Pure record
readers, config-source values, result text, memoization, async scoping,
coordinate validation, and device-scope parsing touch no process, file, or
environment, so they join kernel's other primitives instead.

Closures fall accordingly: capture-kit's png-worker-client from 20 to 10,
png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from
386 to 380.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* chore: drop the migration inventories and trim the touched comments

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* docs: trim the touched host-kit and mutation-lane comments

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* docs: keep tool directives only in the touched files

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* docs: keep tool directives only across the touched tree

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* fix: point the Swift parity comment at the real TS twin and test

The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts,
which does not exist: the module went to capture-kit while isTapPointInsideViewport itself
went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at
the pre-move path. Both now resolve.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

* fix: repoint comment citations at the homes this refactor moved them to

The W1 move left ~20 comment citations pointing at src/utils/*.ts and
src/request/*.ts paths that no longer exist. Each now names the capability
port that owns the symbol, which survives further file moves:

  exec -> host-kit/command          host-process, owner-identity -> host-kit/process
  diagnostics -> host-kit/diagnostics   atomic-file, process-lock -> host-kit/file
  retry -> host-kit/retry           request progress/cancel -> host-kit/request
  version -> host-kit/version       ttl-memo, source-value, parsing, device-isolation,
                                    keyed-lock, success-text -> kernel subpaths

Comment-only; no closure, budget, or behavior change. ADR citations are left
as written, being dated records of the decision rather than live references.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-08-28 07:46:48 +02:00

93 lines
3.7 KiB
TypeScript

/**
* Daemon RPC wire-surface gate, released-baseline half (#1432).
*
* The unit lane (`test/wire-compat/wire-compat.test.ts`) proves the ledger
* matches the source it describes. It cannot prove the thing ADR 0006 actually
* requires — that a wire change since the last RELEASED version came with a
* protocol bump — because from a single commit a bumped ledger and an unbumped
* one are both just an edited file.
*
* So this reads the ledger as it stood at the last released tag and hands both
* to `model.ts`. Baseline is the released tag, never arbitrary git history: an
* unreleased shape has no peer in the wild to be incompatible with (AGENTS.md,
* "Unreleased API surface dies free"), so mid-branch churn is free and only the
* net change since publication has to be justified.
*
* Needs full history and tags, so it runs in its own fetch-depth: 0 CI job
* rather than inside the shallow-clone-safe unit lane — the same split the
* replay-compat corpus provenance verifier uses.
*/
import path from 'node:path';
import { repoGit, requireUnshallowHistory } from '../lib/repo-git.ts';
import { digestDeclaration } from '../../test/wire-compat/declaration-digest.ts';
import {
digestWireSurface,
parseWireLedger,
readWireLedger,
WIRE_LEDGER_PATH,
} from '../../test/wire-compat/ledger.ts';
import { WIRE_DECLARATIONS } from '../../test/wire-compat/surface.ts';
import { compareWireLedgers } from './model.ts';
const repoRoot = path.resolve(import.meta.dirname, '..', '..');
const git = repoGit(repoRoot);
requireUnshallowHistory(git, 'Daemon wire compatibility');
/** Released tags newest-first by semver, not by tag-creation order. */
function releasedTagsNewestFirst(): string[] {
return git(['tag', '--list', 'v*'])
.split('\n')
.map((tag) => ({ tag, version: /^v(\d+)\.(\d+)\.(\d+)$/.exec(tag) }))
.filter((entry) => entry.version !== null)
.map((entry) => ({ tag: entry.tag, parts: entry.version!.slice(1, 4).map(Number) }))
.sort(
(a, b) => b.parts[0]! - a.parts[0]! || b.parts[1]! - a.parts[1]! || b.parts[2]! - a.parts[2]!,
)
.map((entry) => entry.tag);
}
const tags = releasedTagsNewestFirst();
if (tags.length === 0) {
throw new Error('No release tags found. Run `git fetch --tags` first.');
}
/**
* The newest release that carries a ledger. Releases cut before this gate
* landed have none — those are skipped rather than read as an empty wire
* surface, which would report every declaration as "added since release".
*/
const baseline = tags
.map((tag) => ({ tag, raw: git(['show', `${tag}:${WIRE_LEDGER_PATH}`]) }))
.find((entry) => entry.raw.length > 0);
if (!baseline) {
process.stdout.write(
`No released tag carries ${WIRE_LEDGER_PATH} yet (newest checked: ${tags[0]}). The ledger ` +
`becomes enforceable against a released baseline at the next publish; until then the unit ` +
`lane holds it to its source. Rule coverage meanwhile: scripts/wire-compat/model.test.ts.\n`,
);
process.exit(0);
}
const result = compareWireLedgers({
baselineTag: baseline.tag,
released: parseWireLedger(baseline.raw, `${baseline.tag}:${WIRE_LEDGER_PATH}`),
current: readWireLedger(repoRoot),
digests: digestWireSurface(repoRoot, WIRE_DECLARATIONS, digestDeclaration),
});
if (result.failures.length > 0) {
throw new Error(
`Daemon RPC wire compatibility (#1432, ADR 0006):\n${result.failures.join('\n')}`,
);
}
process.stdout.write(
`Daemon RPC wire surface checked against ${baseline.tag} ` +
`(protocol ${result.bumped ? 'bumped' : 'unchanged'}): ${WIRE_DECLARATIONS.length} ` +
`declarations, ${result.changed.length} changed, ${result.removed.length} removed, ` +
`${result.added.length} added.\n`,
);