mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
3937036e5e
* feat: support --settle on scroll and back (#1638) Scroll-then-observe and back-then-observe are legitimate agent pairs, but the post-action observation registry never grew past the touch commands, so `--settle` on either was rejected with INVALID_ARGS — burning a tool call each in AppControlBench's bsky-16. Both commands now carry the `settle` descriptor trait, and every surface derives from it rather than a hand list: CLI allowed flags, MCP/SDK input fields, the flag-sourced timeout envelope, and MCP ref-pinning. The CLI flag/metadata helpers moved out of the interaction family into post-action-observation-grammar.ts (back is a system command), and SETTLE_REF_ISSUING_TOOLS became a derivation — a hand list would have silently stopped pinning the new commands' refs. settleAfterInteraction and the new settleObservationCommand are two entry points over one engine: same loop, storage, hints, and diff bounds, with the target-less path supplying its own baseline and no proximity point. The daemon reaches that command through the runtime surface, never by importing `commands/` (R2) — the same seam the touch handlers use for press/fill — and generic-settle.ts is loaded through a lazy `await import` returning a closure, so the interaction runtime subgraph stays out of this dispatcher's static graph (a static edge folded ~18 files into the daemon-server type cycle; R10 caught it). Both of generic-settle's orderings are load-bearing and tested: the baseline is frozen before dispatch (and before the Android dialog preflight), and the observation runs after markDeferredInteractionOutcome so settle's first capture folds in the #1542 stabilization rather than racing it. The ADR 0014 "a settled diff publishes refs" rule moved to settle-ref-issuance.ts, shared by both routes. One divergence is deliberate: scroll/back resolve no element, so the diff baseline is the session's STORED pre-action tree — "settled tree vs the last tree you observed" — not press's freshly resolved pre-action capture. Both commands also switch to preserve-daemon on timeout, which changes the non-settle path too: with --settle their dominant hang mode is now a wedged accessibility bridge, and a timed-out capture must not reset the daemon and lose every session (#1105). The reviewed-set gate records it. Live-validated on an iOS 26.2 simulator (Settings): scroll --settle settled in 1786ms with a +6/-6 diff carrying fresh refs; back --settle in 771ms with +15/-6. Alternating cost runs, one call vs the pair it replaces: scroll 2.9-3.0s vs 5.3-5.6s, back 3.1-3.2s vs 4.7-5.1s. Those include the #1627 deep-capture extension. * fix: render settled-diff refs paste-ready in CLI output A settled diff activates a PARTIAL ref frame (ADR 0014), which admits only the pinned `@eN~s<gen>` form of the refs it issued. The unchanged-interactive tail already rendered that way, but the diff's own added lines rendered the bare `@eN` embedded in the snapshot line — so a CLI caller who copied the ref the diff just handed them got `plain_ref_requires_complete_frame` and had to append the generation by hand. Added lines now render pinned when the response carries `refsGeneration`, exactly like the tail. Removed lines render verbatim: they name elements that just left the screen, and `SettleDiffLine` never gives them a ref. This is not new to scroll/back — press/click/fill/longpress had the same gap since #1101. MCP was never affected: its ref-pin store rewrites plain refs on the way in, which is why the model never sees a suffix. Live: `scroll down --settle` now emits `+ @e14~s218078 [cell] "Game Center"`, and `press @e14~s218078` copied straight out of that line taps successfully. * test: record the pinned-diff-ref bytes in the output-economy baseline Rendering added diff-line refs pinned costs 8 bytes in the two settle CLI text samples (two `~s<gen>` suffixes). The output-economy baseline is the tripwire for exactly this, so the increase takes an explicit reviewed waiver rather than a silent baseline bump — the same one the settled TAIL's pins already carry, for the same ADR 0014 reason. Only `bytes` moves: lines, refs, hints, and shape are unchanged, which is the evidence that this is a suffix on existing refs and not a new payload. Caught by CI, not locally: `pnpm test:unit` runs unit-core and subprocess-stub only, while the Coverage lane runs every vitest project. * test: prove the generic settle degrades when its runtime cannot be built `createGenericSettleRuntime` catches and returns undefined so an observation that cannot even start does not fail an action that already succeeded. That was a claim in a docstring with nothing behind it — the one changed line the coverage gate reported uncovered (95/96). The test puts the session in the state the catch exists for: the router handed us a session that is no longer in the store, so building the settle runtime throws SESSION_NOT_FOUND. The response keeps its scroll result and simply carries no settle payload. Removing the try/catch fails it. * build: teach fallow that vi.mock reaches pinOwnProcessStartTime dynamically Not from this PR: #1642 added `pinOwnProcessStartTime` on main, and its three consumers reach it the only way a Vitest module mock can — `vi.mock(path, async (importOriginal) => (await import('...')).pinOwnProcessStartTime(...))`. Dependency analysis cannot follow that dynamic import to a consumer, so the export reads as dead the moment any PR pulls that file into its audit scope. This PR is the one that did. The entry records the consumers by path and the reason, matching the daemon route-handler entry directly above it, which exists for the same dynamic-`import()` limitation. * refactor: adopt the best of the parallel #1653 implementation Two sessions independently built #1638 (PR #1650 and PR #1653) and converged on the same architecture — trait in the registry, one engine with two entry points, runtime-command seam, lazy import, preserve-daemon, stored-baseline honesty. #1650 continues; this folds in what #1653 did better: - The agent-facing help core loop (cli-help.ts) now names scroll and back as settle-capable. Without this, the benchmarked closed-grammar help line kept instructing agents that --settle is only for press/click/fill/longpress — actively steering the AppControlBench models away from what #1638 shipped. - issueSettleRefs moves into session-snapshot.ts, beside the partial-frame primitive it wraps, deleting the single-function settle-ref-issuance module. - Their seam tests: back reader→writer settle plumbing, back CLI settle rendering, and a trait-less generic command (home) ignoring a stray settle flag rather than observing or rejecting. What #1650 had that #1653 lacked, for the record: the SETTLE_REF_ISSUING_TOOLS registry derivation (without it, MCP never pins a scroll/back settle diff's refs and the partial frame rejects every follow-up), BackCommandResult.settle in contracts, back's MCP output schema, paste-ready pinned diff refs, and the docs/changelog/baseline surfaces. * bench: help-conformance case for settled scroll-to-find planning The #1638 extension of the closed --settle grammar to scroll/back is the feature's entire payoff — collapsing scroll-then-observe into one call — and the closed command list is an enumerated N whose enumerator is this bench. The regex over the help text proves the sentence exists; this case checks whether a model plans differently because of it. One focused case, deliberately not coached: a pinned visible-first snapshot (rendered by formatSnapshotText, pinned by the sample-producers gate) whose wanted row is summarized off-screen with no ref anywhere in the output. The tempting pre-#1638 plan is `scroll` plus a separate `snapshot -i`; acceptance is the single settled call. Scoring was verified against eight plan shapes in both directions before recording. Model-backed record (claude-haiku-4-5, 3 trials, current help): 0/3 — but the decomposition is the finding. Settle eligibility GENERALIZED (3/3 trials put --settle on scroll unprompted; the mutation-suffix framing concern did not materialize) and the two-call habit is residual (1/3). All three trials failed on `scroll @e3 down --settle` — the pre-existing #1366 scroll-takes-no-target confusion, which the live CLI recovers with a dedicated hint but a single-shot bench cannot. The recorded gap is therefore a first-30 doc gap (nothing teaches that scroll takes no target), not a settle-eligibility gap; tuning the case until it passes would just delete the evidence.
150 lines
7.1 KiB
JavaScript
150 lines
7.1 KiB
JavaScript
// Captured agent-device output embedded in benchmark quiz cases. Each sample
|
|
// is { command, output }: the command line the prompt claims was run, and the
|
|
// exact text the CLI would print for it. Every `output` is pinned to the real
|
|
// renderer by scripts/__tests__/help-conformance-sample-outputs.test.ts, which
|
|
// rebuilds it through src/commands/interaction/output.ts or
|
|
// src/utils/output.ts printHumanError — a rendering change fails that test
|
|
// instead of silently leaving the benchmark grading against stale output.
|
|
|
|
export function sampleText(sample) {
|
|
return `${sample.command}\n${sample.output}`;
|
|
}
|
|
|
|
// Settled press whose diff carried no added ref, so the response appended the
|
|
// unchanged-interactive tail (#1167/#1172). The response carried a diff plus
|
|
// refsGeneration, so the tail refs render pinned (ADR 0014).
|
|
export const SETTLE_TAIL_SAMPLE = {
|
|
command: 'agent-device press @e37 --settle',
|
|
output: `Tapped @e37 (203, 88)
|
|
settled after 540ms: +0 -1 (~15 unchanged)
|
|
- @e50 [text] "Suggested for you"
|
|
unchanged interactive (4):
|
|
= @e64~s5 [text-field] "Search"
|
|
= @e65~s5 [text] "Recent searches"
|
|
= @e12~s5 [tab] "Home"
|
|
= @e40~s5 [tab] "Profile"`,
|
|
};
|
|
|
|
// Settled fill whose diff exposes the next target directly.
|
|
export const SETTLE_DIFF_SAMPLE = {
|
|
command: `agent-device fill 'id="account-search"' "callstack" --settle`,
|
|
output: `Filled 9 chars
|
|
settled after 610ms: +2 -0 (~18 unchanged)
|
|
+ @e64 [button] "@callstack.com"
|
|
+ @e65 [text] "Callstack"`,
|
|
};
|
|
|
|
// Metamorphic twin of SETTLE_DIFF_SAMPLE on a different app and ref range, so
|
|
// a pass cannot come from memorizing the callstack sample.
|
|
export const SETTLE_DIFF_SAMPLE_NOTES = {
|
|
command: `agent-device fill 'id="notes-search"' "groceries" --settle`,
|
|
output: `Filled 9 chars
|
|
settled after 480ms: +2 -0 (~11 unchanged)
|
|
+ @e21 [button] "Groceries list"
|
|
+ @e22 [text] "3 items"`,
|
|
};
|
|
|
|
// Visible-first snapshot of a scrollable list whose remaining rows sit below
|
|
// the viewport: the off-screen content is summarized, not listed as refs. The
|
|
// scroll-to-find quiz case hangs off this — the wanted row exists but no ref
|
|
// for it appears anywhere in the output.
|
|
export const OFFSCREEN_TARGET_SNAPSHOT_SAMPLE = {
|
|
command: 'agent-device snapshot -i',
|
|
output: `Snapshot: 8 visible nodes (12 total)
|
|
@e1 [application] "Preferences"
|
|
@e2 [window]
|
|
@e3 [collection]
|
|
@e4 [cell] "General"
|
|
@e5 [cell] "Display"
|
|
@e6 [cell] "Sounds"
|
|
@e7 [cell] "Focus"
|
|
@e8 [cell] "Screen Time"
|
|
[content below collection hidden]`,
|
|
};
|
|
|
|
// Never-settled press: success response, no diff, NEVER_SETTLED_HINT attached.
|
|
export const NOT_SETTLED_SAMPLE = {
|
|
command: 'agent-device press @e12 --settle',
|
|
output: `Tapped @e12 (166, 240)
|
|
not settled after 10000ms
|
|
hint: The UI kept changing for the whole settle budget (animation, carousel, or ticker?), so no settled diff is shown. Raise --timeout, wait for specific content, or take a fresh snapshot.`,
|
|
};
|
|
|
|
// Recovered snapshot: the private-ax fallback fired but still exposed
|
|
// actionable refs. Warning wording is renderSnapshotQualityWarnings
|
|
// (src/snapshot/snapshot-quality.ts); lines are the structured snapshot
|
|
// renderer (src/utils/output.ts formatSnapshotText).
|
|
export const PRIVATE_AX_RECOVERY_SAMPLE = {
|
|
command: 'agent-device snapshot -i',
|
|
output: `Snapshot: 2 nodes
|
|
Detected an overly complex or slow accessibility tree. Fell back to the private-ax snapshot backend. It is OK to continue; use --json to inspect snapshotQuality.reason if you need recovery details.
|
|
@e5 [button] "Search"
|
|
@e8 [tab] "Home" [selected]`,
|
|
};
|
|
|
|
// DEVICE_IN_USE from buildDeviceInUseBySessionError
|
|
// (src/daemon/handlers/session-open.ts) — the parity test drives that exact
|
|
// producer.
|
|
export const DEVICE_IN_USE_SAMPLE = {
|
|
command: `agent-device press 'label="Place order"' --settle`,
|
|
output: `Error (DEVICE_IN_USE): Device is already in use by session "checkout".
|
|
Hint: Run agent-device session list to inspect active sessions. To reuse this device, rerun the command with --session checkout. To open a new session on this device, first run agent-device close --session checkout.`,
|
|
};
|
|
|
|
// ADR 0014 mutation rejection from
|
|
// src/daemon/handlers/interaction-ref-policy.ts: a pinned ref minted from a
|
|
// superseded generation is rejected before dispatch. The daemon strips the
|
|
// `~s5` pin at the boundary (interaction-touch-targets.ts), so the message
|
|
// names the plain ref; the hint is the precise resolveRefStalenessWarning.
|
|
export const STALE_REF_SAMPLE = {
|
|
command: 'agent-device press @e12~s5 --settle',
|
|
output: `Error (COMMAND_FAILED): Ref @e12 was minted from a superseded snapshot generation
|
|
Hint: Ref @e12 was minted from snapshot s5 but the session's ref frame is now s7 — re-run snapshot -i.`,
|
|
};
|
|
|
|
// AMBIGUOUS_MATCH from buildAmbiguousMatchError (src/daemon/handlers/find.ts)
|
|
// — the parity test drives that exact producer. The by-design rejection
|
|
// instead of silent disambiguation: #1597 made the candidate refs (ref, role,
|
|
// label/identifier — the same compact rendering as snapshot -i) print
|
|
// unconditionally via formatErrorCandidateLines
|
|
// (src/utils/error-candidates.ts), capped at AMBIGUOUS_MATCH_CANDIDATE_LIMIT (5) with a
|
|
// "+N more" marker. Here all 3 candidates share the identical "Follow" label,
|
|
// so the printed refs still cannot be told apart from this output alone —
|
|
// the agent must re-observe or narrow, not guess which @ref is the right row.
|
|
export const AMBIGUOUS_MATCH_SAMPLE = {
|
|
command: 'agent-device find text "Follow"',
|
|
output: `Error (AMBIGUOUS_MATCH): find matched 3 elements for text "Follow". Use a more specific locator or selector.
|
|
Hint: Multiple candidates matched. Narrow the query or pass an exact identifier.
|
|
Candidates:
|
|
@e2 [button] "Follow"
|
|
@e5 [button] "Follow"
|
|
@e9 [button] "Follow"`,
|
|
};
|
|
|
|
// APP_NOT_INSTALLED from buildAppNotInstalledError
|
|
// (src/platforms/apple/core/app-resolution.ts) — the parity test drives that
|
|
// exact producer; the hint is defaultHintForCode('APP_NOT_INSTALLED').
|
|
export const APP_NOT_INSTALLED_SAMPLE = {
|
|
command: 'agent-device open Shoply --platform ios',
|
|
output: `Error (APP_NOT_INSTALLED): No app found matching "Shoply"
|
|
Hint: Run apps to discover the exact installed package or bundle id, or install the app before open.`,
|
|
};
|
|
|
|
// Successful BrowserStack connect output from renderConnectSuccess. The
|
|
// provider resources are already verified, but allocation remains deferred;
|
|
// the next command must use the installed package id instead of probing a
|
|
// not-yet-created device with devices/apps.
|
|
export const BROWSERSTACK_CONNECT_SAMPLE = {
|
|
command:
|
|
'agent-device connect browserstack --platform android --device "Google Pixel 8" --provider-os-version 14.0 --provider-app bs://app-id',
|
|
output: `Connected successfully with BrowserStack.
|
|
Verified: Credentials, device, and uploaded app verified.
|
|
Device: Google Pixel 8 (android 14.0) — verified
|
|
App: sample.apk — verified
|
|
No live device session has been created. The first device command shown below will allocate one.
|
|
Next:
|
|
agent-device open <package-id> --relaunch
|
|
Use the installed package or bundle identifier in open, not the app artifact name.
|
|
After close, run agent-device artifacts --json for provider video and logs.`,
|
|
};
|