mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
Michał Pierzchała
a7efcd468f
* chore(fallow): fit config to repo profile so baselines stay near-empty - Raise health thresholds in .fallowrc.json to the smallest values that pass on a clean tree (maxCyclomatic 58, maxCognitive 77, maxCrap 591) instead of grandfathering ~180 findings in fallow-baselines/health.json. - Raise duplicates.minTokens to 66, the smallest value covering the four tolerated clone groups (largest is 65 tokens). - Regenerate baselines: health.json shrinks from ~18.6 KB of grandfathered finding counts to refactoring-target metadata only; dead-code.json is empty. - Upgrade fallow 2.52.0 -> 2.91.0: 2.87.0 made ignorePatterns silence the "examples/test-app is not declared as a workspace" warning, which 2.52.0 emitted regardless of config. - Remove the unused ensureAdb export (and its now-unused imports) from src/platforms/android/adb.ts; it is not re-exported by any public entry and has no references anywhere in the repo. - Document local (pnpm fallow) vs CI (fallow audit) usage in CONTRIBUTING.md. https://claude.ai/code/session_01LXZXzxi55sZ11DSyqWyBA2 * chore(fallow): keep default thresholds, gate locally via diff-based audit Revise the previous commit after review: pinning global thresholds at the repo's historical maxima (cyclomatic 58, cognitive 77, CRAP 591, minTokens 66) weakened the gate for brand-new code and left zero headroom on the worst existing functions. Restore the original design — fallow default thresholds with legacy findings grandfathered per-file in fallow-baselines/health.json — and fix the local-DX problem at the script level instead: - .fallowrc.json: drop the health/duplicates overrides so fallow defaults (cyclomatic 20, cognitive 15, CRAP 30, minTokens 50) apply to new code. - fallow-baselines/health.json: regenerate at default thresholds under fallow 2.91 (201 grandfathered findings across 108 files); dead-code baseline stays empty. - package.json: `pnpm fallow` now runs `fallow audit --base origin/main`, the same diff-based gate CI uses, so it passes on a clean tree. The old full-tree summary moves to `pnpm fallow:all` (expected to report legacy findings). `check:fallow` is unchanged (CI passes an explicit --base). - CONTRIBUTING.md: correct the fallow docs accordingly. Verified: clean tree passes; a new unused export fails the audit; a new cyclomatic-25 function fails the audit; +1 branch growth in an already- grandfathered function (classifyBootFailure) is absorbed by the baseline. https://claude.ai/code/session_01LXZXzxi55sZ11DSyqWyBA2 --------- Co-authored-by: Claude <noreply@anthropic.com>
26 lines
704 B
JSON
26 lines
704 B
JSON
{
|
|
"unused_files": [],
|
|
"unused_exports": [],
|
|
"unused_types": [],
|
|
"private_type_leaks": [],
|
|
"unused_dependencies": [],
|
|
"unused_dev_dependencies": [],
|
|
"circular_dependencies": [],
|
|
"re_export_cycles": [],
|
|
"unused_optional_dependencies": [],
|
|
"unused_enum_members": [],
|
|
"unused_class_members": [],
|
|
"unresolved_imports": [],
|
|
"unlisted_dependencies": [],
|
|
"duplicate_exports": [],
|
|
"type_only_dependencies": [],
|
|
"test_only_dependencies": [],
|
|
"boundary_violations": [],
|
|
"stale_suppressions": [],
|
|
"unused_catalog_entries": [],
|
|
"empty_catalog_groups": [],
|
|
"unresolved_catalog_references": [],
|
|
"unused_dependency_overrides": [],
|
|
"misconfigured_dependency_overrides": []
|
|
}
|