mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
60400d04b7
* feat(mutation): add target-annotation-serde + snapshot-occlusion kernels Both are pure decision kernels the lane's own membership rule covers (target-annotation-serde: parse/validate/normalize the .ad comment-line codec, zero I/O; snapshot-occlusion: pure covered/not-covered decision where a wrong answer silently blocks or mis-allows a tap) but were excluded from KERNEL_MODULES. Fixing the harness's packages/*/src blind spot was required, not optional: test-scope.ts, ownership.ts, and vitest.mutation.config.ts all hardcoded `src/` as the only place a kernel's tests could live. target-annotation-serde's own tests live under packages/ad-script/src/internal/__tests__/, so without this fix the module would score 0% from day one — not from weak tests, but because its test file was silently invisible to the lane. Widened the same three places, plus mutation-affected.yml's path filter and isTestFile/ownedTestFiles in ownership.ts, to also recognize packages/*/src/**/*.test.ts (mirroring vitest.config.ts's own unit-core project include list). Triaged every surviving mutant from the initial run: real coverage gaps got a new/adjusted test (kill-with-test), everything else is documented equivalent with an inline comment at the mutation site explaining the invariant that makes it unobservable (redundant early-returns, JSON.stringify dropping undefined-valued keys, Number.isFinite/isSafeInteger's total-function safety, caller-enforced positiveRect/candidate invariants, etc). Baseline recorded from the actual measured run, not inherited or guessed: 94.03% (315/335) and 89.74% (175/195). * style: run the formatter over the four files the gate flagged
181 lines
6.6 KiB
TypeScript
181 lines
6.6 KiB
TypeScript
// Enumerated decision kernels the mutation lane measures (issue #1415).
|
|
//
|
|
// Mutation score is the only mechanical answer to "is this test load-bearing or
|
|
// decorative", but a full-suite sweep is unaffordable. This registry is the
|
|
// single source of truth for what Stryker mutates: `stryker.config.json`'s
|
|
// `mutate` globs are asserted against it, and PR-affected gating maps changed
|
|
// files onto modules through it.
|
|
//
|
|
// Membership rule: pure decision kernels only — a surviving mutant here means a
|
|
// silently wrong agent-facing decision. Anything that spawns subprocesses or
|
|
// waits real time is out of scope by construction (its mutants would be timeout
|
|
// noise, not test-strength signal).
|
|
|
|
export type ModuleId =
|
|
| 'kernel-errors'
|
|
| 'daemon-ref-frame'
|
|
| 'interaction-settle'
|
|
| 'scroll-edge-state'
|
|
| 'selectors'
|
|
| 'target-annotation-serde'
|
|
| 'snapshot-occlusion';
|
|
|
|
export type KernelModule = {
|
|
readonly id: ModuleId;
|
|
readonly label: string;
|
|
/** Globs handed to Stryker's `mutate`. */
|
|
readonly mutate: readonly string[];
|
|
/**
|
|
* Paths this module owns; a trailing `/` marks a directory prefix. Sources
|
|
* only — the tests whose strength the score measures are derived from the
|
|
* import graph in `ownership.ts`, never listed here.
|
|
*/
|
|
readonly owns: readonly string[];
|
|
/**
|
|
* How many parallel jobs the module's mutants are sliced across. One job per
|
|
* module is the default; a module big enough to outrun the lane's 30-minute
|
|
* budget declares more (`--shard i/n` picks the slice).
|
|
*/
|
|
readonly shards?: number;
|
|
};
|
|
|
|
export const KERNEL_MODULES: readonly KernelModule[] = [
|
|
{
|
|
id: 'kernel-errors',
|
|
label: 'Error retriability + hints',
|
|
mutate: ['packages/kernel/src/errors.ts'],
|
|
owns: ['packages/kernel/src/errors.ts'],
|
|
},
|
|
{
|
|
id: 'daemon-ref-frame',
|
|
label: 'Ref-frame admission matrix (ADR 0014)',
|
|
mutate: ['src/daemon/ref-frame.ts'],
|
|
owns: ['src/daemon/ref-frame.ts'],
|
|
},
|
|
{
|
|
id: 'interaction-settle',
|
|
label: 'Interaction settle decisions',
|
|
mutate: ['src/commands/interaction/runtime/settle.ts'],
|
|
owns: ['src/commands/interaction/runtime/settle.ts'],
|
|
},
|
|
{
|
|
id: 'scroll-edge-state',
|
|
label: 'Scroll edge-state detection',
|
|
mutate: ['src/utils/scroll-edge-state.ts'],
|
|
owns: ['src/utils/scroll-edge-state.ts'],
|
|
},
|
|
{
|
|
id: 'selectors',
|
|
label: 'Selector parsing + matching',
|
|
mutate: ['src/selectors/**/*.ts', '!src/selectors/**/*.test.ts', '!src/selectors/__tests__/**'],
|
|
// Selector tests live under the owned directory, so the prefix covers them.
|
|
owns: ['src/selectors/'],
|
|
// ~1,280 mutants at the observed ~3s/mutant on a 2-core runner is ~64
|
|
// minutes in one job — past the acceptance budget and its own timeout.
|
|
shards: 4,
|
|
},
|
|
{
|
|
id: 'target-annotation-serde',
|
|
label: 'Target-annotation comment-line codec (ADR 0012 decision 3)',
|
|
mutate: ['packages/ad-script/src/internal/target-annotation-serde.ts'],
|
|
owns: ['packages/ad-script/src/internal/target-annotation-serde.ts'],
|
|
},
|
|
{
|
|
id: 'snapshot-occlusion',
|
|
label: 'Snapshot occlusion (covered/not-covered) decisions',
|
|
mutate: ['src/snapshot/snapshot-occlusion.ts'],
|
|
owns: ['src/snapshot/snapshot-occlusion.ts'],
|
|
},
|
|
];
|
|
|
|
export const ALL_MODULE_IDS: readonly ModuleId[] = KERNEL_MODULES.map((module) => module.id);
|
|
|
|
export function moduleById(id: ModuleId): KernelModule {
|
|
const found = KERNEL_MODULES.find((module) => module.id === id);
|
|
if (!found) throw new Error(`Unknown mutation module: ${id}`);
|
|
return found;
|
|
}
|
|
|
|
export function isModuleId(value: string): value is ModuleId {
|
|
return ALL_MODULE_IDS.includes(value as ModuleId);
|
|
}
|
|
|
|
/** Mutate globs for a module subset, in registry order. */
|
|
export function mutateGlobs(ids: readonly ModuleId[] = ALL_MODULE_IDS): string[] {
|
|
return KERNEL_MODULES.filter((module) => ids.includes(module.id)).flatMap((module) => [
|
|
...module.mutate,
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* The module a lane-tooling change proves itself against before graduation.
|
|
* `kernel-errors` is the cheapest real sweep in the registry (one file, ~183
|
|
* mutants), so a change to the ratchet, the config, or the baseline runs actual
|
|
* mutants end to end without paying for the full sweep.
|
|
*/
|
|
export const LANE_CANARY: ModuleId = 'kernel-errors';
|
|
|
|
/** One mutation job: a module, optionally one slice of it. */
|
|
export type ShardSpec = { name: string; module: ModuleId; shard?: string };
|
|
|
|
/**
|
|
* The jobs a module set expands into. Both workflows' matrices are this list, so
|
|
* a registry module (or a change to its shard count) can never leave the sweep
|
|
* without the workflow assertions noticing.
|
|
*/
|
|
export function shardMatrix(ids: readonly ModuleId[] = ALL_MODULE_IDS): ShardSpec[] {
|
|
return KERNEL_MODULES.filter((module) => ids.includes(module.id)).flatMap((module) => {
|
|
const count = module.shards ?? 1;
|
|
if (count === 1) return [{ name: module.id, module: module.id }];
|
|
return Array.from({ length: count }, (_unused, index) => ({
|
|
name: `${module.id}-${index + 1}`,
|
|
module: module.id,
|
|
shard: `${index + 1}/${count}`,
|
|
}));
|
|
});
|
|
}
|
|
|
|
export function normalizePath(filePath: string): string {
|
|
return filePath.replaceAll('\\', '/').replace(/^\.\//, '');
|
|
}
|
|
|
|
/**
|
|
* Where the mutation lane can ever find a kernel's owning test: root `src/` or
|
|
* a workspace package's `src/` — the same two roots `unit-core`'s `include`
|
|
* (`vitest.config.ts`) draws tests from. A kernel whose test lives outside
|
|
* both (e.g. `scripts/__tests__`) is unreachable by construction, not silently
|
|
* dropped.
|
|
*/
|
|
const KERNEL_TEST_FILE_RE = /^(?:src\/|packages\/[^/]+\/src\/).*\.test\.ts$/;
|
|
|
|
export function isKernelTestFile(filePath: string): boolean {
|
|
return KERNEL_TEST_FILE_RE.test(normalizePath(filePath));
|
|
}
|
|
|
|
/**
|
|
* Which kernel module owns a repository-relative *source* path, if any.
|
|
*
|
|
* Test-file attribution is derived from the import graph — see
|
|
* `derivedAffectedModules` in `ownership.ts`, which is what the PR lane calls.
|
|
*/
|
|
export function moduleForFile(filePath: string): ModuleId | undefined {
|
|
const normalized = normalizePath(filePath);
|
|
for (const module of KERNEL_MODULES) {
|
|
for (const owned of module.owns) {
|
|
const match = owned.endsWith('/') ? normalized.startsWith(owned) : normalized === owned;
|
|
if (match) return module.id;
|
|
}
|
|
}
|
|
return undefined;
|
|
}
|
|
|
|
/** Kernel modules whose registry-owned paths a diff touches. */
|
|
export function affectedModules(changedFiles: readonly string[]): ModuleId[] {
|
|
const ids = new Set<ModuleId>();
|
|
for (const file of changedFiles) {
|
|
const id = moduleForFile(file);
|
|
if (id) ids.add(id);
|
|
}
|
|
return KERNEL_MODULES.filter((module) => ids.has(module.id)).map((module) => module.id);
|
|
}
|