2 Commits

Author	SHA1	Message	Date
Michał Pierzchała	801734d433	feat(ai-sdk): add agent-device/ai-sdk tool set and document the MCP zero-code path (#1804) ... * feat(ai-sdk): add agent-device/ai-sdk tool set and document the MCP zero-code path Adds `createAgentDeviceTools()` under a new `agent-device/ai-sdk` subpath, built from the same command registry the MCP server uses so both stay in lockstep without a hand-maintained tool list. Introduces a `frameworkTier` descriptor facet ('core' | 'extended') so the factory can default to a curated perceive/act loop instead of handing a model dozens of tools. `ai` is wired as an optional peer dependency, imported lazily inside the factory rather than at module scope, so importing the subpath itself never requires `ai` to be installed - only calling it does. The package's own publishing gate (scripts/lib/shipped-imports.ts) is extended to recognize peerDependencies as a valid resolution source, since this is the first optional peer this package has shipped. Also restructures the AI SDK doc around three tiers (zero-code via @ai-sdk/mcp, the new typed tool set, hand-written tools) and fixes a stale `needsApproval` reference in favor of the current `toolApproval` API. * fix(layering): classify src/ai-sdk as a rank-4 zone The layering guard requires every src/<folder>/ to be explicitly ranked or unranked; the new src/ai-sdk/ subpath (added in the prior commit) was left unclassified, failing CI's Layering Guard job. It sits at the same tier as client/compat/daemon-server/metro/remote/sdk - a public integration surface consuming mcp (3) and core (2), imported by nothing else in the tree. * fix(ci): cover, exempt, and pack the new ai-sdk subpath Fixes the remaining CI failures on the ai-sdk subpath commit: - Coverage: src/ai-sdk/index.ts had no dedicated unit test (only manual/ integration verification), so changed-line coverage sat at 6.9% against the 70% gate. Adds src/ai-sdk/__tests__/index.test.ts (core vs 'all' tool filtering, session/platform pinning and schema hiding, error normalization, toolApproval passthrough) with createCommandToolExecutor and createAgentDeviceClient mocked the same way command-tools.test.ts does, plus a dedicated missing-peer-dependency.test.ts that mocks `ai` itself to throw, isolated to its own file so it doesn't affect the other tests' use of the real, installed `ai` package. Changed-line coverage is now 29/29 (100%). - Fallow Code Quality: src/ai-sdk/index.ts and examples/sdk/ai-sdk-tools.ts are entry points with no in-repo importer (reached only via package.json exports / run directly), and the new subpath's exports are unused internally by design - both need the same treatment src/sdk/*.ts and its examples already have in .fallowrc.json. - Integration Tests: test/integration/installed-package-metro.test.ts and src/__tests__/package-exports.test.ts each hand-list every published subpath and smoke-check it from a real packed install; added ./ai-sdk to both so the new subpath is actually exercised, not just silently passing. * fix(ai-sdk): hide MCP transport/config fields from the model too createAgentDeviceTools() only removed session and mcpOutputFormat from tool schemas. stateDir was still model-visible and reached the shared executor as client configuration, letting a tool call redirect into a different daemon state directory - defeating the "one pinned session" guarantee the factory exists to provide. includeCost and responseLevel are MCP tool-config knobs in the same category, irrelevant to this adapter. Widens the hidden-field set to session/stateDir/mcpOutputFormat/ includeCost/responseLevel, and now strips them from the runtime input inside execute() too (not just the schema), so the guarantee holds even if a caller bypasses schema validation. The schema-properties filter and the input filter now share one omitHidden() helper instead of two near- duplicate implementations. Addresses the P1 review comment on #1804.	2026-08-18 11:57:34 +02:00
Michał Pierzchała	80feff42d6	build: verify the published tarball instead of grepping the bundle (#1578) ... * build: verify the published tarball instead of grepping the bundle Replaces the bundle-dependency grep with one gate that packs the tarball npm would publish and proves it sound from a clean consumer install: publint and attw on the tarball, a two-way dependency-closure audit, an import of every `exports` subpath, and the CLI smoke run — all from outside the workspace, where no pnpm link can mask an unresolvable specifier. Also stops the build from emitting a publishable bundle in the first place: a missing workspace link now fails `pnpm build` instead of warning and exiting 0, which is how 0.20.4 shipped an unresolvable `@agent-device/ad-script` import. publint found 12 real defects in the current package — every `exports` entry listed `types` after `import`, so TypeScript resolved declarations by accident rather than by condition. The dependency audit found `pngjs` declared as a runtime dependency while tsdown inlines it, an install every user paid for and no shipped code reached; it moves to devDependencies. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NamFJUgn9DGHrT2za11JbD * fix(ci): run the package gate without pnpm on the Node floor pnpm 11.17 requires Node >= 22.13, so `pnpm check:package` could not start on the 22.12 floor the Packaged CLI job exists to cover. The gate needs only `node` and `npm`, so the job invokes the script directly. Splits the dependency-closure audit into a collector and a message builder to clear Fallow's complexity threshold, and classifies both packaging linters in ignoreDependencies: they are subprocess CLIs with no importable API here, which dependency analysis cannot follow to an import. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NamFJUgn9DGHrT2za11JbD * fix(publishing): read every literal resolution form in the closure audit The dependency-closure audit derived shipped imports from the ESM module record alone, so it could not see a package resolved through `require` or a `createRequire` result: neither produces a module-record entry. A lazy `createRequire('@agent-device/…')` would therefore clear the audit, the all-export probe and the exercised CLI paths, reintroducing the 0.20.4 published-install failure class for another command. Measuring the built bundle turned up a second, larger hole in the same reader. The shipped files are minified, and the minifier rewrites every string literal to a no-substitution template literal, so the dynamic-import extraction — which accepted quoted strings only — matched 0 of the 99 dynamic imports the bundle contains. The lazy `import()` path that broke 0.20.4 was reported as covered while checking nothing. Specifiers now come from the module record plus an AST walk over every literal runtime-resolution form: `import()`, `require()`, `require.resolve()`, an immediately-invoked `createRequire(...)`, and calls through a `createRequire` result under any import or minified alias. Both spellings of a string literal count everywhere, and `.cjs` joins the scanned extensions. Computed specifiers stay explicitly out of scope, and are pinned as such. Rejecting them is not available: minifiers reuse short identifiers across scopes, and the packed bundle really does contain an unrelated `a(h[t],f,g,l,e,m)` that no name-based match can distinguish from a require call. Those are covered by the gate's runtime half instead, which resolves them for real. Bare-identifier calls need the one-string-argument shape for the same reason. The audit moves to scripts/lib/shipped-imports.ts so fixture packages can exercise it. The gate needs a real `npm pack` behind minutes of Swift and Android builds, so every check that runs it can only watch a healthy package pass — which is how a reader that matched nothing looked covered. The new fixtures assert the failure direction per resolution form: 16 of the 22 fail against the previous reader, and the 6 that pass are the quoted-spelling and pinned-limitation cases. A wiring assertion keeps the audit and both runtime probes attached to the gate, since fixtures alone would stay green if the call were deleted. Verified against the real built bundle: the closure resolves to exactly the two declared dependencies, so the stricter reader adds no false positives. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NamFJUgn9DGHrT2za11JbD --------- Co-authored-by: Claude <noreply@anthropic.com>	2026-08-04 12:28:05 +02:00