mirror of
https://github.com/browser-use/browser-use.git
synced 2026-09-14 19:59:47 +08:00
Saurav Panda
782535c34f
An unconditional re-raise sent BrowserErrors without long_term_memory (e.g. upload_file's failure paths) into Tools.act's handle_browser_error, which re-raises exactly those — escaping act() as an exception where callers previously got a recoverable ActionResult(error=...). Guard the bypass on long_term_memory being present (the exact condition handle_browser_error formats without re-raising; short_term_memory alone would still re-raise), and flatten plain BrowserErrors to RuntimeError as before. Regression test covers the plain-BrowserError path through tools.act.
47 lines
2.0 KiB
Python
47 lines
2.0 KiB
Python
"""Regression test: BrowserError raised inside an action must reach Tools.act with its
|
|
structured short/long-term memory intact, instead of being flattened into a generic
|
|
'Error executing action ...' RuntimeError by execute_action's catch-all handler."""
|
|
|
|
from browser_use.browser.views import BrowserError
|
|
from browser_use.tools.service import Tools
|
|
|
|
|
|
async def test_browser_error_memory_survives_execute_action():
|
|
tools = Tools()
|
|
|
|
@tools.registry.action(description='Test action that raises a structured BrowserError')
|
|
async def raise_structured_error():
|
|
raise BrowserError(
|
|
message='element is a select, not clickable',
|
|
short_term_memory='Available options: alpha, beta, gamma',
|
|
long_term_memory='Tried to click a dropdown; use select_dropdown instead',
|
|
)
|
|
|
|
ActionModel = tools.registry.create_action_model()
|
|
action = ActionModel(**{'raise_structured_error': {}})
|
|
|
|
result = await tools.act(action, browser_session=None) # type: ignore[arg-type] -- action doesn't touch the browser
|
|
|
|
assert result.error == 'Tried to click a dropdown; use select_dropdown instead', (
|
|
f'structured long_term_memory lost: {result.error!r}'
|
|
)
|
|
assert result.extracted_content == 'Available options: alpha, beta, gamma'
|
|
|
|
|
|
async def test_plain_browser_error_still_returns_recoverable_action_result():
|
|
"""A BrowserError without long_term_memory must not escape Tools.act as an
|
|
exception — it must still come back as a recoverable ActionResult (as it did
|
|
when the generic execute_action handler flattened it)."""
|
|
tools = Tools()
|
|
|
|
@tools.registry.action(description='Test action that raises a plain BrowserError')
|
|
async def raise_plain_error():
|
|
raise BrowserError(message='element with index 5 does not exist')
|
|
|
|
ActionModel = tools.registry.create_action_model()
|
|
action = ActionModel(**{'raise_plain_error': {}})
|
|
|
|
result = await tools.act(action, browser_session=None) # type: ignore[arg-type] -- action doesn't touch the browser
|
|
|
|
assert result.error is not None and 'element with index 5 does not exist' in result.error
|