Files
browser-use__browser-use/browser_use/actor/mouse.py
Andrew Chen db8a1d4af0 Fix Mouse.scroll() silently redirecting an explicit x=0/y=0 to viewport center
scroll_x = x if x > 0 else viewport_width / 2 (and the y equivalent) treats
an explicitly-passed x=0/y=0 the same as "not provided", since 0 > 0 is
False. page.mouse is a public actor API (browser_use/actor/page.py's
`mouse` property), so any caller explicitly requesting a scroll anchored at
the left edge (x=0) or top edge (y=0) instead gets silently redirected to
the horizontal/vertical center of the viewport -- no error, no warning, just
a wrong anchor point for the dispatched mouseWheel/synthesizeScrollGesture
CDP event. The only in-repo call site (actor/playground/playground.py:123,
`mouse.scroll(x=0, y=100, delta_y=500)`) was itself silently hitting this
bug.

Fix: change the x/y parameters to `int | None = None` and only fall back to
the viewport center when the coordinate is genuinely unset (None), extracted
into a small pure `_resolve_scroll_anchor()` helper so the anchor-resolution
logic is unit-testable without a real browser session. Also moved the
viewport-metrics fetch and anchor resolution above both CDP methods (mouse
wheel event, then synthesizeScrollGesture fallback) so both consistently
anchor at the same resolved point -- previously the synthesizeScrollGesture
fallback used the raw, un-centered x/y args instead.

Added tests/ci/test_actor_mouse_scroll_anchor.py covering: explicit x=0,
explicit y=0, both-unset (center fallback), and normal positive coordinates
passed straight through.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-15 13:40:49 +08:00

153 lines
4.7 KiB
Python

"""Mouse class for mouse operations."""
from typing import TYPE_CHECKING
if TYPE_CHECKING:
from cdp_use.cdp.input.commands import DispatchMouseEventParameters, SynthesizeScrollGestureParameters
from cdp_use.cdp.input.types import MouseButton
from browser_use.browser.session import BrowserSession
def _resolve_scroll_anchor(x: int | None, y: int | None, viewport_width: float, viewport_height: float) -> tuple[float, float]:
"""Resolve the (x, y) point a scroll event should be dispatched at.
An explicit 0 must be honored as "left/top edge", not treated as "unset".
Only a genuinely missing (None) coordinate falls back to the viewport center.
"""
scroll_x = x if x is not None else viewport_width / 2
scroll_y = y if y is not None else viewport_height / 2
return scroll_x, scroll_y
class Mouse:
"""Mouse operations for a target."""
def __init__(self, browser_session: 'BrowserSession', session_id: str | None = None, target_id: str | None = None):
self._browser_session = browser_session
self._client = browser_session.cdp_client
self._session_id = session_id
self._target_id = target_id
async def click(self, x: int, y: int, button: 'MouseButton' = 'left', click_count: int = 1) -> None:
"""Click at the specified coordinates."""
# Mouse press
press_params: 'DispatchMouseEventParameters' = {
'type': 'mousePressed',
'x': x,
'y': y,
'button': button,
'clickCount': click_count,
}
await self._client.send.Input.dispatchMouseEvent(
press_params,
session_id=self._session_id,
)
# Mouse release
release_params: 'DispatchMouseEventParameters' = {
'type': 'mouseReleased',
'x': x,
'y': y,
'button': button,
'clickCount': click_count,
}
await self._client.send.Input.dispatchMouseEvent(
release_params,
session_id=self._session_id,
)
async def down(self, button: 'MouseButton' = 'left', click_count: int = 1) -> None:
"""Press mouse button down."""
params: 'DispatchMouseEventParameters' = {
'type': 'mousePressed',
'x': 0, # Will use last mouse position
'y': 0,
'button': button,
'clickCount': click_count,
}
await self._client.send.Input.dispatchMouseEvent(
params,
session_id=self._session_id,
)
async def up(self, button: 'MouseButton' = 'left', click_count: int = 1) -> None:
"""Release mouse button."""
params: 'DispatchMouseEventParameters' = {
'type': 'mouseReleased',
'x': 0, # Will use last mouse position
'y': 0,
'button': button,
'clickCount': click_count,
}
await self._client.send.Input.dispatchMouseEvent(
params,
session_id=self._session_id,
)
async def move(self, x: int, y: int, steps: int = 1) -> None:
"""Move mouse to the specified coordinates."""
# TODO: Implement smooth movement with multiple steps if needed
_ = steps # Acknowledge parameter for future use
params: 'DispatchMouseEventParameters' = {'type': 'mouseMoved', 'x': x, 'y': y}
await self._client.send.Input.dispatchMouseEvent(params, session_id=self._session_id)
async def scroll(
self, x: int | None = None, y: int | None = None, delta_x: int | None = None, delta_y: int | None = None
) -> None:
"""Scroll the page using robust CDP methods."""
if not self._session_id:
raise RuntimeError('Session ID is required for scroll operations')
# Get viewport dimensions (used to resolve x/y when the caller doesn't specify a coordinate)
try:
layout_metrics = await self._client.send.Page.getLayoutMetrics(session_id=self._session_id)
viewport_width = layout_metrics['layoutViewport']['clientWidth']
viewport_height = layout_metrics['layoutViewport']['clientHeight']
except Exception:
viewport_width = viewport_height = 0
scroll_x, scroll_y = _resolve_scroll_anchor(x, y, viewport_width, viewport_height)
# Calculate scroll deltas (positive = down/right)
scroll_delta_x = delta_x or 0
scroll_delta_y = delta_y or 0
# Method 1: Try mouse wheel event (most reliable)
try:
await self._client.send.Input.dispatchMouseEvent(
params={
'type': 'mouseWheel',
'x': scroll_x,
'y': scroll_y,
'deltaX': scroll_delta_x,
'deltaY': scroll_delta_y,
},
session_id=self._session_id,
)
return
except Exception:
pass
# Method 2: Fallback to synthesizeScrollGesture
try:
params: 'SynthesizeScrollGestureParameters' = {
'x': scroll_x,
'y': scroll_y,
'xDistance': delta_x or 0,
'yDistance': delta_y or 0,
}
await self._client.send.Input.synthesizeScrollGesture(
params,
session_id=self._session_id,
)
except Exception:
# Method 3: JavaScript fallback
scroll_js = f'window.scrollBy({delta_x or 0}, {delta_y or 0})'
await self._client.send.Runtime.evaluate(
params={'expression': scroll_js, 'returnByValue': True},
session_id=self._session_id,
)