Files
boshu2__agentops/tests/scripts/test-codex-plugin-metadata-schema.sh
Bo e431339c40 feat(hookless)!: remove all hooks — skills + CLI only (soc-57b7f #remove-all-hooks) (#511)
## What

AgentOps 3.0 goes **fully hookless**. This removes the entire hook
product surface — the product is now skills + the `ao` CLI with **zero
hooks**. CI is the authoritative gate.

## Deleted

- `hooks/` — 46 hook scripts + `hooks.json` + examples (whole directory)
- `cli/embedded/hooks/` + embedded `hooks.json` +
`embedded/lib/hook-helpers.sh`
- `lib/hook-helpers.sh`
- `ao hooks` CLI command: `cli/cmd/ao/hooks.go`, `hooks_run.go` + 5 hook
test files; `cli/internal/bridge/hooks.go`;
`cli/internal/doctor/fix_hooks.go` + test
- Codex hook manifest (`hooks/codex-hooks.json`) + handler/audit scripts
(`scripts/audit-codex-hooks.sh`, `install-dev-hooks.sh`,
`test-hooks-output.sh`, `test-codex-hookless-lifecycle.sh`,
`test-hookless-rpi-phased.sh`)
- Hook lease surface: `docs/contracts/hook-lease-*`,
`schemas/hook-lease.v1.schema.json`,
`scripts/check-hook-lease-inventory.sh`,
`check-hook-port-replacements.sh`, `generate-hook-lease-inventory.py`
- Hook docs: `docs/HOOKS.md`, `cli/docs/HOOKS.md`,
`docs/architecture/hook-noise-audit.md`,
`docs/contracts/hook-runtime-contract.md`
- `tests/hooks/` (whole dir) + hook test scripts; 5 hook eval suites +
fixtures

## CI gates removed

`hook-preflight`, `validate-hooks-doc-parity`, `hook-output-schema-lint`
(+ scripts/bats), the hook eval suites, the `test-runtime-codex-smoke` /
`test-codex-native-install` / `test-codex-plugin-install` hook-handler
assertions, the cli-integration hook-lifecycle steps, the bats
`tests/hooks/*` glob + orphan-hooks audit, and the `--with-hooks`
install path. `embedded-sync` now validates only lib/skills. Both
summary `needs:` lists + the summary echo +
`docs/contracts/ci-jobs.yaml` updated; `validate-ci-policy-parity`
passes (66 rows). `.codex-plugin/plugin.json` drops the "Hooks"
capability.

## Load-bearing PRESERVED (reported, not forced)

- **`cli/cmd/ao/codex_runtime.go`** — the codex runtime *lifecycle
profile* (`HookCapable`/`HookConfigured` detection) is a
runtime-capability abstraction used by 6 `validate-codex-*` CI gates,
distinct from the hook product. Deleting it is a separate refactor.
- **`hooks-authoring` skill** + `schemas/hooks-manifest.v1.schema.json`
— reframed as an opt-in "author your own hooks" guide. Deleting the
skill cascades into catalog/domain-map/dispositions/context-map golden
files (skill-count sync), out of scope for the hook-product removal.
- **`scripts/pre-push-gate.sh`** — retired local gate (not in CI);
self-skips deleted hook scripts via `[[ -x ]]` guards; its 55 bats tests
still pass.
- Domain-enforcement audit keeps the `enforced`-mode schema for
backward-compatible JSON readers, but the hookless resolver only returns
`audited`/`unavailable`.

## Verification

`go build` / `go vet` clean; `go test ./...` = **11849 passed, 0
failed** (68 pkgs). gofmt clean on all touched files. Green: registry
`--check` (0 hooks), `regen-codex-hashes --check`,
`validate-ci-policy-parity`, `check-wiring-closure`,
`validate-embedded-sync`, `validate-manifests`, `validate-agents-split`,
`doc-release` (0 broken links), `generate-cli-reference --check`,
`heal.sh --strict`, codex/claude/plugin smoke tests, baseline-audit (0
stale). Diff: 231 files, +354 / −39803.

Closes-scenario: soc-57b7f#remove-all-hooks
Bounded-context: BC5-Runtime
Evidence: .github/workflows/validate.yml
2026-05-24 11:19:37 -04:00

170 lines
3.6 KiB
Bash
Executable File

#!/usr/bin/env bash
set -euo pipefail
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
PASS=0
FAIL=0
pass() {
echo "PASS: $1"
PASS=$((PASS + 1))
}
fail() {
echo "FAIL: $1"
FAIL=$((FAIL + 1))
}
TMP_DIR="$(mktemp -d)"
trap 'rm -rf "$TMP_DIR"' EXIT
setup_fixture() {
local fixture="$1"
mkdir -p \
"$fixture/.claude-plugin" \
"$fixture/.codex-plugin" \
"$fixture/plugins" \
"$fixture/schemas"
cp "$ROOT/schemas/plugin-manifest.v1.schema.json" "$fixture/schemas/plugin-manifest.v1.schema.json"
cp "$ROOT/schemas/codex-plugin-manifest.v1.schema.json" "$fixture/schemas/codex-plugin-manifest.v1.schema.json"
cp "$ROOT/schemas/codex-marketplace.v1.schema.json" "$fixture/schemas/codex-marketplace.v1.schema.json"
cat > "$fixture/.claude-plugin/plugin.json" <<'EOF'
{
"name": "agentops",
"version": "0.0.0"
}
EOF
}
write_legacy_codex_metadata() {
local fixture="$1"
cat > "$fixture/.codex-plugin/plugin.json" <<'EOF'
{
"name": "agentops",
"description": "Legacy thin Codex plugin manifest.",
"skills": "./skills-codex"
}
EOF
cat > "$fixture/plugins/marketplace.json" <<'EOF'
{
"name": "agentops-marketplace",
"plugins": [
{
"name": "agentops",
"source": {
"source": "local",
"path": "./"
}
}
]
}
EOF
}
write_plugin_creator_metadata() {
local fixture="$1"
cat > "$fixture/.codex-plugin/plugin.json" <<'EOF'
{
"name": "agentops",
"version": "0.0.0",
"description": "Modern Codex plugin manifest.",
"skills": "./skills-codex",
"mcpServers": "./mcp",
"interface": {
"displayName": "AgentOps",
"shortDescription": "Repo-native memory and validation.",
"longDescription": "AgentOps packages repo-native memory, validation gates, and repeatable agent workflows.",
"developerName": "AgentOps",
"category": "Productivity",
"capabilities": [
"Skills",
"Hooks"
],
"defaultPrompt": [
"Use AgentOps to plan this change.",
"Use AgentOps to validate this change."
],
"brandColor": "#111827"
}
}
EOF
cat > "$fixture/plugins/marketplace.json" <<'EOF'
{
"name": "agentops-marketplace",
"interface": {
"displayName": "AgentOps"
},
"plugins": [
{
"name": "agentops",
"source": {
"source": "local",
"path": "./"
},
"policy": {
"installation": "AVAILABLE",
"authentication": "ON_INSTALL"
},
"category": "Productivity"
}
]
}
EOF
}
run_manifest_validation() {
local fixture="$1"
local out="$2"
bash "$ROOT/scripts/validate-manifests.sh" --repo-root "$fixture" > "$out" 2>&1
}
test_legacy_codex_metadata_shape_still_validates() {
local fixture="$TMP_DIR/legacy"
local out="$fixture/out.txt"
setup_fixture "$fixture"
write_legacy_codex_metadata "$fixture"
if run_manifest_validation "$fixture" "$out"; then
pass "legacy Codex plugin metadata shape validates"
else
fail "legacy Codex plugin metadata shape should validate"
sed 's/^/ /' "$out"
fi
}
test_plugin_creator_metadata_shape_validates() {
local fixture="$TMP_DIR/plugin-creator"
local out="$fixture/out.txt"
setup_fixture "$fixture"
write_plugin_creator_metadata "$fixture"
if run_manifest_validation "$fixture" "$out"; then
pass "plugin-creator Codex plugin metadata shape validates"
else
fail "plugin-creator Codex plugin metadata shape should validate"
sed 's/^/ /' "$out"
fi
}
echo "== test-codex-plugin-metadata-schema =="
test_legacy_codex_metadata_shape_still_validates
test_plugin_creator_metadata_shape_validates
echo ""
echo "Results: $PASS PASS, $FAIL FAIL"
if [[ "$FAIL" -gt 0 ]]; then
exit 1
fi
exit 0