mirror of
https://github.com/boshu2/agentops.git
synced 2026-09-14 15:08:13 +08:00
89f05739b0
'ao help <anything>' always exits 0, so the help-mode predicate detected ZERO removed commands — the skills snippet gate was decorative. Default is now AO_RESOLVE_MODE=strict (env override kept), resolving against a source-built binary carrying the archived-command tags. Strict measurement over skills/ + skills-codex/ found exactly one offender: a fabricated 'ao daemon status' citation in the release skill's worked-example notes (ao daemon removed, ADR-0009) — fixed at source and hand-mirrored into the bespoke twin (hashes regenerated). No baseline needed. Teeth proven: a probe skill citing 'ao rpi status' passes help-mode, FAILS strict. Verified: strict validator green over both trees; fixture bats 5/5 (fake-ao made mode-agnostic); codex manifest OK (60 skills); docs validator (shared lib) unaffected; shellcheck clean.
199 lines
5.4 KiB
Bash
199 lines
5.4 KiB
Bash
#!/usr/bin/env bash
|
|
set -euo pipefail
|
|
|
|
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
SCRIPT="$ROOT/scripts/validate-skill-cli-snippets.sh"
|
|
|
|
PASS=0
|
|
FAIL=0
|
|
|
|
pass() { echo "PASS: $1"; PASS=$((PASS + 1)); }
|
|
fail() { echo "FAIL: $1"; FAIL=$((FAIL + 1)); }
|
|
|
|
if [[ ! -f "$SCRIPT" ]]; then
|
|
echo "FAIL: missing script: $SCRIPT" >&2
|
|
exit 1
|
|
fi
|
|
|
|
TMP_DIR="$(mktemp -d)"
|
|
trap 'rm -rf "$TMP_DIR"' EXIT
|
|
|
|
setup_fixture() {
|
|
local repo="$1"
|
|
mkdir -p "$repo/scripts/lib" "$repo/skills/example" "$repo/skills-codex/example" "$repo/cli"
|
|
cp "$SCRIPT" "$repo/scripts/validate-skill-cli-snippets.sh"
|
|
chmod +x "$repo/scripts/validate-skill-cli-snippets.sh"
|
|
# The validator sources scripts/lib/ao-snippet-resolve.sh and its inline
|
|
# Python imports ao_snippet_resolve from AO_SNIPPET_LIB_DIR (the same lib
|
|
# dir) — the fixture must carry both alongside the copied validator.
|
|
cp "$ROOT/scripts/lib/ao-snippet-resolve.sh" "$repo/scripts/lib/ao-snippet-resolve.sh"
|
|
cp "$ROOT/scripts/lib/ao_snippet_resolve.py" "$repo/scripts/lib/ao_snippet_resolve.py"
|
|
|
|
# Mode-agnostic fake `ao`: understands BOTH resolution shapes so the fixture
|
|
# exercises whichever predicate the validator's AO_RESOLVE_MODE selects —
|
|
# help mode: `ao help <chain>` (trust rc==0)
|
|
# strict mode: `ao <chain> --help` (reject "unknown command" in stdout)
|
|
# Normalize either invocation to the bare <chain>, then dispatch. An unknown
|
|
# chain prints cobra's "unknown command" to stdout and exits non-zero, so it
|
|
# fails BOTH predicates (rc!=0 for help mode; matched regex for strict mode).
|
|
cat > "$repo/fake-ao" <<'EOF'
|
|
#!/usr/bin/env bash
|
|
args=("$@")
|
|
# Drop a leading `help` (help-mode) or a trailing `--help`/`-h` (strict-mode),
|
|
# and drop the root-help forms so `ao --help` == `ao help` == global help.
|
|
if [[ "${args[0]:-}" == "help" ]]; then
|
|
args=("${args[@]:1}")
|
|
fi
|
|
if [[ "${#args[@]}" -gt 0 ]]; then
|
|
last_idx=$(( ${#args[@]} - 1 ))
|
|
case "${args[$last_idx]}" in
|
|
--help|-h) unset 'args[last_idx]'; args=("${args[@]}") ;;
|
|
esac
|
|
fi
|
|
chain="${args[*]}"
|
|
case "$chain" in
|
|
"")
|
|
cat <<'INNER'
|
|
Usage:
|
|
ao [command]
|
|
|
|
Flags:
|
|
-h, --help
|
|
INNER
|
|
exit 0
|
|
;;
|
|
"lookup")
|
|
cat <<'INNER'
|
|
Usage:
|
|
ao lookup [flags]
|
|
|
|
Flags:
|
|
--query string
|
|
--json
|
|
INNER
|
|
exit 0
|
|
;;
|
|
"goals measure")
|
|
cat <<'INNER'
|
|
Usage:
|
|
ao goals measure [flags]
|
|
|
|
Flags:
|
|
--json
|
|
INNER
|
|
exit 0
|
|
;;
|
|
*)
|
|
echo "Error: unknown command \"${args[0]:-}\" for \"ao\"" >&2
|
|
echo "unknown command"
|
|
exit 1
|
|
;;
|
|
esac
|
|
EOF
|
|
chmod +x "$repo/fake-ao"
|
|
}
|
|
|
|
test_passes_for_current_commands() {
|
|
local repo="$TMP_DIR/pass"
|
|
setup_fixture "$repo"
|
|
|
|
cat > "$repo/skills/example/SKILL.md" <<'EOF'
|
|
Use `ao lookup --query "topic" --json`.
|
|
EOF
|
|
cat > "$repo/skills-codex/example/SKILL.md" <<'EOF'
|
|
Use `ao goals measure --json`.
|
|
EOF
|
|
|
|
if (cd "$repo" && AGENTOPS_AO_BIN="$repo/fake-ao" bash scripts/validate-skill-cli-snippets.sh >/dev/null); then
|
|
pass "passes for valid ao command snippets"
|
|
else
|
|
fail "should pass for valid ao command snippets"
|
|
fi
|
|
}
|
|
|
|
test_fails_for_unknown_command() {
|
|
local repo="$TMP_DIR/fail-command"
|
|
setup_fixture "$repo"
|
|
|
|
cat > "$repo/skills/example/SKILL.md" <<'EOF'
|
|
Use `ao work goals`.
|
|
EOF
|
|
cat > "$repo/skills-codex/example/SKILL.md" <<'EOF'
|
|
Use `ao lookup --query "topic"`.
|
|
EOF
|
|
|
|
if (cd "$repo" && AGENTOPS_AO_BIN="$repo/fake-ao" bash scripts/validate-skill-cli-snippets.sh >/dev/null 2>&1); then
|
|
fail "should fail for unknown ao command snippets"
|
|
else
|
|
pass "fails for unknown ao command snippets"
|
|
fi
|
|
}
|
|
|
|
test_fails_for_unknown_flag() {
|
|
local repo="$TMP_DIR/fail-flag"
|
|
setup_fixture "$repo"
|
|
|
|
cat > "$repo/skills/example/SKILL.md" <<'EOF'
|
|
Use `ao lookup --badflag`.
|
|
EOF
|
|
cat > "$repo/skills-codex/example/SKILL.md" <<'EOF'
|
|
Use `ao goals measure --json`.
|
|
EOF
|
|
|
|
if (cd "$repo" && AGENTOPS_AO_BIN="$repo/fake-ao" bash scripts/validate-skill-cli-snippets.sh >/dev/null 2>&1); then
|
|
fail "should fail for unknown flags"
|
|
else
|
|
pass "fails for unknown flags"
|
|
fi
|
|
}
|
|
|
|
test_passes_for_pipeline_and_placeholder_flags() {
|
|
local repo="$TMP_DIR/pipeline-placeholder"
|
|
setup_fixture "$repo"
|
|
|
|
cat > "$repo/skills/example/SKILL.md" <<'EOF'
|
|
Use `ao lookup --query="topic" --json | head -20`.
|
|
EOF
|
|
cat > "$repo/skills-codex/example/SKILL.md" <<'EOF'
|
|
Use `ao --help` and `ao goals measure --json`.
|
|
EOF
|
|
|
|
if (cd "$repo" && AGENTOPS_AO_BIN="$repo/fake-ao" bash scripts/validate-skill-cli-snippets.sh >/dev/null); then
|
|
pass "passes for shell pipelines and normalized flag values"
|
|
else
|
|
fail "should pass for shell pipelines and normalized flag values"
|
|
fi
|
|
}
|
|
|
|
test_fails_for_stale_beads_resolver() {
|
|
local repo="$TMP_DIR/fail-beads-resolver"
|
|
setup_fixture "$repo"
|
|
|
|
cat > "$repo/skills/example/SKILL.md" <<'EOF'
|
|
Read the bead with `BEADS_DIR=$PWD/_beads br show ag-123`.
|
|
EOF
|
|
cat > "$repo/skills-codex/example/SKILL.md" <<'EOF'
|
|
Use `ao lookup --query "topic"`.
|
|
EOF
|
|
|
|
if (cd "$repo" && AGENTOPS_AO_BIN="$repo/fake-ao" bash scripts/validate-skill-cli-snippets.sh >/dev/null 2>&1); then
|
|
fail "should fail for stale BEADS_DIR=$PWD/_beads skill examples"
|
|
else
|
|
pass "fails for stale BEADS_DIR=$PWD/_beads skill examples"
|
|
fi
|
|
}
|
|
|
|
echo "== test-skill-cli-snippets =="
|
|
test_passes_for_current_commands
|
|
test_fails_for_unknown_command
|
|
test_fails_for_unknown_flag
|
|
test_passes_for_pipeline_and_placeholder_flags
|
|
test_fails_for_stale_beads_resolver
|
|
|
|
echo ""
|
|
echo "Results: $PASS PASS, $FAIL FAIL"
|
|
if [[ "$FAIL" -gt 0 ]]; then
|
|
exit 1
|
|
fi
|
|
exit 0
|