Commit Graph

4 Commits

Author SHA1 Message Date
Bo fcacbed3f9 fix(scripts): clean 6 pre-existing shellcheck warnings (soc-j026) (#349)
## Summary

Child arc of `soc-l4n8` (drift surfaced during #348). Mechanical cleanup
of 6 pre-existing shellcheck warnings in scripts I did not previously
touch — all SC2034 unused-vars, SC2088 intended-literal, SC2089/SC2090
template-string, SC2221/SC2222 redundant-case.

Per anti-pattern #2 (no bundling pre-existing fixes), filed as an atomic
side-quest off the #348 `soc-1lp1` PR rather than bundled into it.

Closes: soc-j026
Discovered-from: soc-l4n8

## Diff

| File | Fix |
|---|---|
| `validate-codex-api-conformance.sh:59` | SC2088 disable directive —
grep is intentionally matching the literal documented path |
| `goal-failure-taxonomy.sh:30` | Trim redundant case patterns
(`*toolchain-security*`, `*release-security*`, `*ci-security*` all
already matched by `*security*`) |
| `purge-global-garbage.sh:24` | Remove unused `bodylen` |
| `nightly-pr-digest.sh:316` | Remove unused `landing_policy` (local +
assignment) |
| `add-validate-job.sh` | File-level SC2089/SC2090 disable for the
template-string section |
| `check-skill-size.sh:34` | Remove unused `name` |

## Validation

- `shellcheck -S warning` clean on all 6 files.
- `scripts/ship.sh` routes to `--fast` (no inventory touched).
- Pre-push gate (fast): PASSED, 31 skipped, 1 advisory WARN
(executable-spec, unrelated).

Bounded-context: BC0-foundations (scripts)
Evidence: `shellcheck -S warning scripts/*` (clean for the 6 files)

Co-authored-by: Codex <codex@example.invalid>
2026-05-19 10:52:40 +00:00
Boden Fuller 4e0dbecffe feat(nightly): make morning digest admission-aware and durable
Add build_admission_context section to nightly-pr-digest.sh that renders
GH evidence status, main CI baseline, open PR blocker count, blocker PR
table, and admission verdict (dry-run/admitted/stopped). The JSON format
includes the full admission_context object from digest.json.

BATS tests verify the PR body markdown contains the admission table and
the JSON format exposes admission fields.

Closes soc-y8b.11.5.
2026-05-05 14:15:16 -04:00
Boden Fuller 36c53c75f9 fix(nightly): remove unused variable declarations (shellcheck SC2034) 2026-05-04 20:01:13 -04:00
Boden Fuller 54bd161aab feat(nightly): add PR digest generator from structured run state
Reads digest.json, cycle-history.jsonl, fitness baselines, bd tracker,
and git log to produce a markdown PR body covering baseline/final goals,
cycle history, runtime-artifact flips, open PR overlap, tracker
degradation, transient flakes, auto-reverts, and tag-push status.

Wired into nightly-evolution.sh as an automatic post-run step.
2026-05-04 19:55:32 -04:00