Commit Graph

4 Commits

Author SHA1 Message Date
Bo a5ecfa7818 fix(ci): suppress false-positive SC2088 in lint-codex-native.sh (ag-nrn7 #shellcheck-sc2088) (#623)
## What

`scripts/lint-codex-native.sh` line 145 (`Check 3`) runs `grep -n
'~/\.claude/' "$skill_file"` — the `~/.claude/` is a **literal grep
pattern** (the check detects non-portable `~/.claude/` strings inside
codex skill files), not a path meant to expand. shellcheck SC2088 flags
it as a non-expanding tilde, which is a false positive here. This was 1
of the 8 `pre-push-gate.sh` failures triaged in ag-nrn7.

## Fix

Add a scoped `# shellcheck disable=SC2088` with a rationale comment
directly above the line. 3 lines, single file.

## Test

- `shellcheck scripts/lint-codex-native.sh` → **exit 0, 0 findings**
(was: 1 SC2088 warning → gate FAIL).
- `bash -n` syntax OK; the grep pattern is unchanged so Check 3 behavior
is identical.
- `bats tests/scripts/pre-push-shellcheck-unconditional.bats` → green
(no regression).

Closes the **last actionable** item in ag-nrn7's full-gate triage. The
remaining ag-nrn7 failures are tolerate (mkdocs-venv; CI venv passes),
elsewhere (distribution-install-update canary → soc-3csze), or
local-state only — none blocks CI.

Closes-scenario: ag-nrn7#shellcheck-sc2088
Bounded-context: BC5-Runtime
Evidence: shellcheck scripts/lint-codex-native.sh
2026-05-30 03:39:43 -04:00
Boden Fuller 6ba1a76f52 fix(ci): fix skill schema, runtime format, and CLI snippet validation
- Add output_contract, cross-vendor, knowledge to valid schema keys/tiers
- Fix codex lint regex to exclude $-prefixed slash-commands
- Fix codex forge/post-mortem/scenario skills: /cmd → $/cmd prefix
- Fix scenario SKILL.md: replace non-existent --source/--scope flags
  with valid --status variants
2026-04-06 21:51:08 -04:00
Boden Fuller 9205270833 Harden local codex skill validation 2026-03-07 13:26:49 -05:00
Boden Fuller ac7c3af74f sync codex-native skill updates 2026-02-26 06:36:11 -05:00