 Bo
|
8c02ded329
|
fix(bats): disable background gc in fixtures to kill the flaky teardown (soc-72gkw #bats-flaky-teardown) (#439)
P2 agentops-core bug. verified-rebase.bats test 919 intermittently
failed in teardown `rm -rf $TMP` — a git background process
(auto-gc/fsmonitor) held a file in $TMP/.git when rm fired (failed on
#438 run 1, passed on re-run). Would keep biting future PRs.
Root fix (shared helper, covers all fixtures):
- lib/bats-common.bash bats_init_repo: gc.auto 0 + maintenance.auto
false + core.fsmonitor false
Defense-in-depth:
- verified-rebase.bats teardown: cd / before rm, best-effort rm
How tested: shellcheck clean; bats-common 5/5; verified-rebase 4/4 × 3
consecutive runs (was flaky).
NOTE: claude-review infra-red (weekly limit, resets May 25) —
operator-authorized bypass when sole red.
Closes-scenario: soc-72gkw#bats-flaky-teardown
Bounded-context: BC5-Runtime
Evidence: lib/bats-common.bash
|
2026-05-23 02:00:07 -04:00 |
|
|
Bo
|
566f7bd69f
|
feat(lib): bats-common.bash shared fixture helpers (soc-jhq6 #bats-common-helpers) (#435)
P2 agentops-core fix. 15 script-test bats files re-derive the same
fixture boilerplate (mktemp, git init + identity, bin-stubbing) →
setup-drift bugs. Centralized.
- lib/bats-common.bash (NEW): bats_repo_root, bats_init_repo,
bats_stub_bin — functions only, no top-level shell opts
- tests/scripts/bats-common.bats (NEW): 5 self-tests
- verified-rebase.bats: refactored to use the lib (proof-of-adoption)
Bounded: lib + self-test + 1 adoption. Broader adoption (~14 files) is
incremental follow-up.
How tested: shellcheck clean; bats 5/5 + 4/4 under CI-like env (EDITOR
unset). Caught + fixed the worktree-.git-is-a-file gotcha locally.
NOTE: claude-review infra-red (weekly limit, resets May 25) —
operator-authorized bypass when sole red.
Closes-scenario: soc-jhq6#bats-common-helpers
Bounded-context: BC5-Runtime
Evidence: lib/bats-common.bash
|
2026-05-23 01:03:41 -04:00 |
|