mirror of
https://github.com/backnotprop/plannotator.git
synced 2026-09-14 14:17:26 +08:00
47bdd210dc
Adversarial QA findings. (1) install.ps1 and install.cmd spliced the absolute exe path UNQUOTED into the generated hooks.json commands — any Windows user with a space in their profile path (C:\Users\John Smith\...) got hook commands that word-split when the hook shell runs them, so plan review silently never intercepted (install.sh is immune: it writes the PATH-resolved bare name). Both hook commands in both installers now wrap the path in JSON-escaped quotes, pinned by updated harness assertions. (2) install.cmd still carried 32 em-dashes + 2 ellipses — several in user-facing echo lines — which render as mojibake on cmd.exe's default non-UTF-8 codepages; #1021 fixed exactly this class in install.ps1 but left cmd untouched. Full ASCII purge, with a new ASCII-only regression test mirroring the ps1 one. Harness: 85 pass / 0 fail. Claude-Session: https://claude.ai/code/session_01SFy9fY27SA8g5BtotWPi1G