Files
김영준E 41059d8e43 fix: Support Windows markdown paths in CLI annotate flow (#267)
* fix(annotate): support Windows markdown paths in CLI annotate flow

* fix tmp path

* fix resolve-file.ts

* Update command to use EXE_PATH variable

* Update command path for plugin hooks in install.ps1

* test: add core test suite for path resolution, storage, remote detection, and install scripts

- resolve-file: absolute paths, relative paths, case-insensitive search, ignored dirs, extension filtering, ambiguity, Windows separators
- storage: slug generation, tilde expansion, version history, deduplication
- remote: env var detection (PLANNOTATOR_REMOTE, SSH_TTY), port config and validation
- image: tmpdir usage, extension validation
- install scripts: JSON structure validation, checksum verification, arch detection, full exe path in hooks

79 tests, 35ms

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: add test workflow and gate release builds on tests

- New test.yml: runs `bun test` on PRs and pushes to main
- release.yml: tests must pass before build job runs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: resolve pre-existing test failures for CI compatibility

- project.test.ts: make repo name assertion portable (works in CI where
  checkout dir differs from local dev)
- vscode mock: add missing APIs needed by editor-annotations.ts
  (comments, languages, Range, CodeActionKind, decorations)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: remove Viewer.test.tsx and happy-dom dependency

Tests didn't exercise any application code — they manually constructed
DOM elements inline and verified DOM API behavior, not Viewer.tsx logic.
The mock highlighter didn't simulate real hljs, and one test could never
fail due to its try/catch structure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: use targeted markdown glob and restore clean lockfile

- Replace **/* glob with **/*.[mM][dD]{,[xX]} to only scan markdown
  files during case-insensitive search (avoids iterating every file)
- Restore package.json key ordering from main, only removing happy-dom
- Regenerate bun.lock from main's base to eliminate version drift

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: drop redundant test and fix weak assertion

- Remove redundant PLANNOTATOR_REMOTE=TRUE test (already covered by true)
- Fix UPLOAD_DIR assertion that would pass even with hardcoded /tmp

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Michael Ramos <mdramos8@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-10 17:47:07 -07:00

64 lines
2.1 KiB
TypeScript

/**
* Image Validation Tests
*
* Run: bun test packages/server/image.test.ts
*/
import { describe, expect, test } from "bun:test";
import { tmpdir } from "node:os";
import { validateImagePath, validateUploadExtension, UPLOAD_DIR } from "./image";
describe("UPLOAD_DIR", () => {
test("uses os.tmpdir(), not hardcoded /tmp", () => {
// On macOS tmpdir() returns something like /var/folders/...
// On Linux it returns /tmp
// On Windows it returns C:\Users\...\AppData\Local\Temp
// The key thing: it should NOT be hardcoded to /tmp/plannotator
expect(UPLOAD_DIR).toContain("plannotator");
expect(UPLOAD_DIR.startsWith(tmpdir())).toBe(true);
});
});
describe("validateImagePath", () => {
test("accepts supported extensions", () => {
for (const ext of ["png", "jpg", "jpeg", "gif", "webp", "svg", "avif"]) {
const result = validateImagePath(`/tmp/image.${ext}`);
expect(result.valid).toBe(true);
}
});
test("rejects unsupported extensions", () => {
expect(validateImagePath("/tmp/file.txt").valid).toBe(false);
expect(validateImagePath("/tmp/script.js").valid).toBe(false);
expect(validateImagePath("/tmp/page.html").valid).toBe(false);
});
test("rejects files with no extension", () => {
expect(validateImagePath("/tmp/noextension").valid).toBe(false);
});
test("resolves path", () => {
const result = validateImagePath("relative/image.png");
expect(result.resolved).toMatch(/^\//); // absolute on POSIX
});
});
describe("validateUploadExtension", () => {
test("accepts supported extensions", () => {
expect(validateUploadExtension("photo.png").valid).toBe(true);
expect(validateUploadExtension("photo.jpg").valid).toBe(true);
});
test("rejects unsupported extensions", () => {
const result = validateUploadExtension("file.exe");
expect(result.valid).toBe(false);
expect(result.error).toBeDefined();
});
test("defaults to png when no extension", () => {
const result = validateUploadExtension("noext");
expect(result.valid).toBe(true);
expect(result.ext).toBe("png");
});
});