mirror of
https://github.com/backnotprop/plannotator.git
synced 2026-09-14 14:17:26 +08:00
Andrew
bb6a65ac76
* fix(plugin): consolidate system prompt injections into single array element The plugin previously pushes planning prompts and improvement contexts as separate elements in the output.system array. This change appends them to output.system[0] with newline separators instead. This keeps all system instructions within a single message block to prevent potential parsing or formatting issues when the agent processes the context. * refactor(opencode-plugin): extract composeSystemPrompt helper to centralize system prompt assembly and add unit tests * style(opencode-plugin): remove extra newline before plan submission reminder heading * fix(opencode-plugin): store composed prompt result before clearing system array to prevent data loss Previously, `output.system` was cleared with `length = 0` before being passed into `composeSystemPrompt`, causing the function to compose from an empty array instead of the original system content. The fix stores the composition result in a variable first, then pushes it after clearing. Additionally, add `.trim()` in `stripConflictingPlanModeRules` to normalize whitespace before filtering empty entries, and include a test case for empty string collapse behavior. * refactor(plan-mode.ts): move string trimming from stripConflictingPlanModeRules to composeSystemPrompt for centralized whitespace handling * test(plan-mode): add test case for trimming trailing newlines in composeSystemPrompt
90 lines
3.3 KiB
TypeScript
90 lines
3.3 KiB
TypeScript
import { describe, expect, test } from "bun:test";
|
|
import {
|
|
composeSystemPrompt,
|
|
normalizeEditPermission,
|
|
stripConflictingPlanModeRules,
|
|
} from "./plan-mode";
|
|
|
|
describe("normalizeEditPermission", () => {
|
|
test("returns empty object for undefined", () => {
|
|
expect(normalizeEditPermission(undefined)).toEqual({});
|
|
});
|
|
|
|
test("converts 'deny' string to wildcard object", () => {
|
|
// Triggered by `tools: { edit: false }` or `permission: { edit: "deny" }`
|
|
expect(normalizeEditPermission("deny")).toEqual({ "*": "deny" });
|
|
});
|
|
|
|
test("converts 'allow' string to wildcard object", () => {
|
|
expect(normalizeEditPermission("allow")).toEqual({ "*": "allow" });
|
|
});
|
|
|
|
test("converts 'ask' string to wildcard object", () => {
|
|
expect(normalizeEditPermission("ask")).toEqual({ "*": "ask" });
|
|
});
|
|
|
|
test("passes through an existing object unchanged", () => {
|
|
const obj = { "*.ts": "deny", "src/**": "allow" };
|
|
expect(normalizeEditPermission(obj)).toEqual(obj);
|
|
});
|
|
|
|
test("merging with '*.md': 'allow' preserves deny-all + md-allow", () => {
|
|
// This is the main scenario fixed by this function:
|
|
// user has tools: { edit: false } which produces permission.edit = "deny",
|
|
// and we need to merge in "*.md": "allow" without string-spreading.
|
|
const base = normalizeEditPermission("deny");
|
|
const merged = { ...base, "*.md": "allow" };
|
|
expect(merged).toEqual({ "*": "deny", "*.md": "allow" });
|
|
// Crucially, no char-index keys like "0", "1", "2", "3"
|
|
expect(Object.keys(merged)).not.toContain("0");
|
|
});
|
|
});
|
|
|
|
describe("stripConflictingPlanModeRules", () => {
|
|
test("removes OpenCode's blanket file-edit prohibition", () => {
|
|
expect(
|
|
stripConflictingPlanModeRules([
|
|
"Read-only mode\nSTRICTLY FORBIDDEN: ANY file edits.\nUse the tools carefully.",
|
|
]),
|
|
).toEqual(["Read-only mode\nUse the tools carefully."]);
|
|
});
|
|
|
|
test("drops conversation-only plan storage lines and keeps unrelated instructions", () => {
|
|
expect(
|
|
stripConflictingPlanModeRules([
|
|
"The plan lives only in the agent's conversation, not on disk.\nKeep the plan concise.",
|
|
]),
|
|
).toEqual(["Keep the plan concise."]);
|
|
});
|
|
|
|
test("drops experimental plan path lines", () => {
|
|
expect(
|
|
stripConflictingPlanModeRules([
|
|
"Create your plan at /tmp/.opencode/plans/1234-test.md\nKeep the plan concise.",
|
|
]),
|
|
).toEqual(["Keep the plan concise."]);
|
|
});
|
|
|
|
test("drops experimental plan_exit instructions", () => {
|
|
expect(
|
|
stripConflictingPlanModeRules([
|
|
"Call plan_exit when the plan is ready.\nKeep the plan concise.",
|
|
]),
|
|
).toEqual(["Keep the plan concise."]);
|
|
});
|
|
});
|
|
|
|
describe("composeSystemPrompt", () => {
|
|
test.each([
|
|
["always one element", ["a"], ["b"], ["a\n\nb"]],
|
|
["empty strip case", [], ["prompt"], ["prompt"]],
|
|
["multi-element order", ["base", "extra"], ["add1", "add2"], ["base\n\nextra\n\nadd1\n\nadd2"]],
|
|
["content order (plan path)", ["strip1"], ["plan", "improve"], ["strip1\n\nplan\n\nimprove"]],
|
|
["trailing newlines trimmed", ["base\n"], ["add\n\n"], ["base\n\nadd"]],
|
|
["empty string entry collapses", ["", "a"], ["b"], ["a\n\nb"]],
|
|
["empty inputs", [], [], [""]],
|
|
])("%s", (_name, system, additions, expected) => {
|
|
expect(composeSystemPrompt(system, additions)).toEqual(expected);
|
|
});
|
|
});
|