mirror of
https://github.com/backnotprop/plannotator.git
synced 2026-09-14 14:17:26 +08:00
Michael Ramos
afac44b940
Replaces the all-files renderer with Pierre's virtualized CodeView (one scroller, identical look, scales to huge diffs); deletes the legacy AllFilesDiffView/LazyFileDiff and their flag; single-file panels stay on FileDiff. @pierre/diffs pinned exact 1.2.8 (1.2.9's tree is broken on npm — see #880). Also ships: diff staleness detection ('Diff out of date · Refresh' toolbar notice backed by shared per-VCS fingerprints + GET /api/diff/fresh on both Bun and Pi servers), a stale-content guard so files edited mid-review degrade to raw-patch view instead of breaking virtualization, the Ask AI wrong-file fix (pre-existing), and toolbar/header UI polish (global settings cog, aligned sem badges, no all-files split dragger). Hardened through five review waves; tested with 1384 passing tests incl. real-git fingerprint and patch-consistency suites. Known minor gaps documented in the PR.
59 lines
2.2 KiB
TypeScript
59 lines
2.2 KiB
TypeScript
import { describe, expect, test } from 'bun:test';
|
|
import { isContentConsistentWithPatch } from './patchConsistency';
|
|
|
|
const lines = (n: number, prefix = 'line') =>
|
|
Array.from({ length: n }, (_, i) => `${prefix}${i + 1}`).join('\n') + '\n';
|
|
|
|
// A patch replacing 2 lines with 5 (net +3) somewhere in a 10-line file.
|
|
const NET_PLUS_3_PATCH = [
|
|
'diff --git a/foo.ts b/foo.ts',
|
|
'--- a/foo.ts',
|
|
'+++ b/foo.ts',
|
|
'@@ -4,4 +4,7 @@',
|
|
' line4',
|
|
'-line5',
|
|
'-line6',
|
|
'+new5',
|
|
'+new6',
|
|
'+new7',
|
|
'+new8',
|
|
'+new9',
|
|
' line7',
|
|
'',
|
|
].join('\n');
|
|
|
|
describe('isContentConsistentWithPatch', () => {
|
|
test('accepts contents whose totals match the patch net', () => {
|
|
// old: 10 lines, new: 13 lines, patch net: +3
|
|
expect(isContentConsistentWithPatch(NET_PLUS_3_PATCH, lines(10), lines(13))).toBe(true);
|
|
});
|
|
|
|
test('rejects stale contents (file changed since the diff was captured)', () => {
|
|
// new side drifted by +3 again (e.g. mid-review edit): 16 ≠ 10 + 3
|
|
expect(isContentConsistentWithPatch(NET_PLUS_3_PATCH, lines(10), lines(16))).toBe(false);
|
|
// old side drifted
|
|
expect(isContentConsistentWithPatch(NET_PLUS_3_PATCH, lines(8), lines(13))).toBe(false);
|
|
});
|
|
|
|
test('passes one-sided contents through (added / deleted files)', () => {
|
|
expect(isContentConsistentWithPatch(NET_PLUS_3_PATCH, null, lines(999))).toBe(true);
|
|
expect(isContentConsistentWithPatch(NET_PLUS_3_PATCH, lines(999), null)).toBe(true);
|
|
});
|
|
|
|
test('passes hunkless patches through', () => {
|
|
expect(isContentConsistentWithPatch('Binary files a/x and b/x differ\n', lines(1), lines(2))).toBe(true);
|
|
});
|
|
|
|
test('handles omitted hunk counts (single-line hunks)', () => {
|
|
// @@ -3 +3 @@ → oldCount=1, newCount=1, net 0
|
|
const patch = '--- a/f\n+++ b/f\n@@ -3 +3 @@\n-old\n+new\n';
|
|
expect(isContentConsistentWithPatch(patch, lines(5), lines(5))).toBe(true);
|
|
expect(isContentConsistentWithPatch(patch, lines(5), lines(7))).toBe(false);
|
|
});
|
|
|
|
test('is insensitive to trailing-newline differences', () => {
|
|
const tenNoTrailing = lines(10).slice(0, -1);
|
|
expect(isContentConsistentWithPatch(NET_PLUS_3_PATCH, tenNoTrailing, lines(13))).toBe(true);
|
|
});
|
|
});
|