2 Commits

Author	SHA1	Message	Date
Michael Ramos	7ee366d8a1	fix(opencode): show the session URL on OpenCode 2's native command path (#1435) ... * fix(opencode): show the session URL on OpenCode 2's native command path On OpenCode 2 a remote session's URL was invisible. runNativeCommand builds its bridge client with createV2BridgeClient, which deliberately has no tui domain, so toastPlannotatorUrl optional-chained to a no-op; both URL delivery paths (the CLI stderr forwarder and the ready-file poller) route through it. The V2 client's app.log is console.error, and OpenCode discards a server plugin's stderr under both default launch modes (packages/cli/src/services/ standalone.ts uses stderr: "ignore" unless OPENCODE_PRINT_LOGS=1). Remote mode also suppresses the browser, so /plannotator-review showed the user nothing at all and presented as a hang. Deliver the URL as a visible transcript notice instead. createSessionUrlNotifier duck-types ctx.session.synthetic and exposes it to cli-bridge as notifyUrl, a seam toastPlannotatorUrl prefers over the toast when present; OpenCode 1 clients carry no notifyUrl and keep their real toast unchanged. The notice is posted with resume: false, which upstream skips the wake for, so nothing starts a model turn, and it carries the URL in both text and description because the TUI drops a synthetic row whose description is empty and renders the description rather than the text. Everything is guarded: a host without session.synthetic, or a call with no session, gets no notifier and falls back to today's log-only behavior, and a rejecting synthetic is caught and leaves the URL retryable by the other delivery path. The README's remedy line claimed remote sessions should read the URL from the OpenCode log, which was never true; it now describes the transcript notice and names OPENCODE_PRINT_LOGS=1 for older hosts. Also fixes two bugs in the OpenCode 2 native-command smoke: - scripts/opencode2-native-commands-smoke.sh looked for a node_modules/.bin/ opencode binary. @opencode-ai/cli publishes opencode2 on every dist-tag, so the script failed before it started a server. It now tries both names and reports which it looked for. - The command-ownership check read /api/command once, immediately after activation, racing the reclaim schedule whose last tick lands about 15.5s later. Under PLANNOTATOR_SMOKE_EXPECT_NATIVE=1 that reported a shadowing bug the reclaim had simply not reached yet. It now polls to a 30s deadline (PLANNOTATOR_SMOKE_COMMAND_TIMEOUT_MS), still only after /api/plugin reports the plugin loaded. AI-assisted (Claude) under maintainer direction. * fix(opencode): deliver the session URL on OpenCode 2's plan review path too The first commit fixed only the native command path. The plan path builds its own client (createV2Client, typed as { app: { agents, log } } with no notifier), so a remote OpenCode 2 user who reached a review through submit_plan still never saw the URL: no browser is opened for them and the plugin's console output is discarded by the host. The plan path now builds the same bridge client the command path uses, with toolContext.sessionID, so it carries notifyUrl whenever the host exposes session.synthetic. That covers both runtimes: the CLI runtime already prefers notifyUrl inside toastPlannotatorUrl, and the embedded runtime's previously empty logReady hook is now createPlanReadyNotifier. That hook still does not log. app.log is console.error, the same stderr handleServerReady already printed the URL to, so logging there would duplicate the line in remote mode and add a stray one locally, which is why the hook was empty. The transcript notice is a different surface, and it is the only one a remote reviewer can see. Without session.synthetic the hook stays silent exactly as before. createV2Client is gone: it duplicated the bridge client's URL-deduped app.log verbatim, and nothing else used it. Three tests on the plan path (delivers the notice; stays silent and does not re-log without synthetic; catches a rejecting notice) plus one that pins the two wiring seams at source level, since the notifier tests all pass while the plan path is wired to nothing, which is the shape the bug had. Also from review: console.error is stubbed across the V2 URL delivery block, so those tests no longer print URL lines into the suite output. The README bullet now says the notice covers every way a session opens rather than slash commands alone. AI-assisted (Claude) under maintainer direction.	2026-08-31 13:12:23 -07:00
Michael Ramos	82a8f236ec	feat(opencode): restore the slash commands on OpenCode 2 (#1434) ... * feat(opencode): restore the slash commands on OpenCode 2 OpenCode's V2 plugin API gained native command execution upstream (anomalyco/opencode issue #2185, PR #44765): ctx.command.transform lets a plugin add a command whose execute callback fully owns the invocation. That shape currently ships on the beta and dev dist-tags of @opencode-ai/plugin while next and latest still carry the older context, so the capability is duck-typed at runtime and never imported. On a host that exposes it the V2 adapter registers /plannotator-review, /plannotator-annotate and /plannotator-last and runs the same handleCliCommand machinery OpenCode 1 uses, passing the raw argument tail straight through to the CLI. On a host without it nothing new is registered and behavior is byte-identical to before. Also wires ctx.session.switchAgent (same API generation, same probe) so an agent switch chosen in the review UI is applied instead of only warned about, and accepts both agent.list() response shapes: the HTTP client types it as a { location, data } envelope while the in-process plugin domain answers with a bare array, where reading .data threw and silently emptied the agent list. The shared command stubs get model-mediated fallback bodies for OpenCode 2 hosts on the stale channels. They carry no shell interpolation on purpose: OpenCode 1 evaluates a template's !`...` before the V1 plugin's command.execute.before hook can clear the parts, so a bang template there would launch a second Plannotator session on every OC1 invocation. A source level test pins that. AI-assisted (Claude) under maintainer direction. * fix(opencode): probe the command draft and reclaim the names from the stubs Review found the capability probe was wrong in the direction that matters. ctx.command.transform exists on pre-#44765 hosts too: our own pinned @opencode-ai/plugin@0.0.0-next-16775 declares CommandDraft as { list, get, update, remove } with no add. The probe therefore returned true on next and latest, draft.add was undefined, and because transforms are stored and replayed the TypeError landed in the batched reload flush and aborted it before commit, plausibly taking every command registration on the host down with it. Capability is now read from the draft handed to the callback, which is the only witness, and the registration call is wrapped so no transform rejection can fail plugin setup. The stubs also shadowed the native definitions on new hosts. Command definitions land in a name-keyed map where add is Map.set, transforms replay in registration order, and OpenCode's own ConfigCommandPlugin activates in the post group after package plugins while scanning the exact directory the installer writes the three stubs to. A setup-time registration is therefore always overwritten on a normal install. The plugin now re-registers the same transform once activation settles, so its definitions are last in the replay order, and calls ctx.command.reload() explicitly because a late registration only adds its reload to the already-flushed boot batch. Ownership is read back from ctx.command.list() by description, which is why the native descriptions and the stub frontmatter are deliberately distinct. If the reclaim cannot run the stubs keep the names and the commands still work through their fallback bodies. Also: a failing switchAgent no longer costs the reviewer their feedback on the command path, feedback is delivered as "queue" rather than replaying the invocation's admission mode minutes later when a steer would land mid-turn, and the agent-list comment no longer asserts a bare-array response that could not be reproduced upstream (accepting both shapes is still right, since reading .data blindly throws into a catch that degrades silently). Tests: the real old-host draft shape registers nothing and throws nothing, the shadowing contest is modelled against upstream's replay semantics, the OpenCode 1 parts-clearing invariant is pinned for all three commands in both plan-agent and manual mode now that the stubs carry real instructions, and the V2 smoke asserts the plugin did not activate as failed and that all three commands resolve. The smoke now also installs the stubs into its sandbox config dir so the contest actually happens there. scripts/opencode2-native-commands-smoke.sh runs the same smoke against a dev-channel build with native commands required; CI cannot, because it pins a next build. AI-assisted (Claude) under maintainer direction. * fix(opencode): keep the reclaim ticking and stop an unbuilt checkout failing setup The reclaim ended the loop when the draft-probe flag read false, but that flag only flips when the transform replays, which under boot batching is the flush after every plugin has loaded. Plannotator loads before the post-group config plugins, so the first tick legitimately reads false and the loop exited for good: the reclaim was inert in exactly the shape production has. The tick is skipped now instead, with a test that flips the flag between ticks. The V1 entry called resolveBundledHtmlPath synchronously during plugin construction, outside the .catch that was there to absorb a missing asset, so an unbuilt checkout threw out of construction before any code path that needs the HTML. The Test workflow runs bun test with no build step, so the new OpenCode 1 interception tests failed there. Both preloads are guarded; the lazy getters still raise a clear error if something actually needs the file. The smoke's failed-plugin guard read entry.state.status, but Plugin.Info carries status and error at the top level, so a failed activation slipped through. Reads the top level first and keeps the nested one as a fallback. Comment corrections: State.batch clears its active flag before flushing, so a late transform registration materializes on its own; the explicit reload() is redundant-but-defensive rather than required. The reclaim schedule is a list of deltas the loop awaits in turn, so the ticks land near 0.3s, 1.5s, 5.5s and 15.5s, not at the raw numbers. AI-assisted (Claude) under maintainer direction.	2026-08-31 10:42:26 -07:00