Austin Griffith f42b7402a2 feedback: lower friction, capture praise, draft-and-ask flow (#155) ...

* feedback: lower friction, capture praise, draft-and-ask flow

Changes the feedback system from "fire-and-forget after permission"
to "draft-then-ask," and broadens it from issue-only to issue + praise.

feedback/SKILL.md
- Lower the threshold: "anything that confused you, slowed you down,
  or genuinely helped" instead of "factually wrong + significant time
  wasted." Bias toward sending; weak signals are easy to ignore in the
  inbox, but missing signals can't be recovered.
- Add `kind: "issue" | "praise"` so the corpus captures what's working,
  not just what broke.
- Replace the two-step "ask permission, then silently POST" flow with
  a single draft-and-ask: the agent shows the rendered JSON inside the
  permission ask, the human approves or edits inline, the agent POSTs
  once. Same number of human turns; full review for free.
- Document the pre-authorization escape hatch: humans who put
  "ethskills feedback is pre-approved" in their CLAUDE.md let agents
  skip the per-event ask.
- Make `agent` required so model-pivoted analysis is possible. Keep
  `skill` optional but strongly encouraged.

api/feedback.js
- Accept `kind` field, validate as "praise" or fall back to "issue"
  (legacy entries without a kind are treated as issues).
- Require non-empty `agent`; return 400 if missing.
- Store kind in the persisted entry.

inbox.html
- Add Issues / Praise filter tabs alongside Unread / All.
- Color-code praise (green accent + left border) so the two streams
  are visually distinct at a glance.
- Show kind badge on each entry. Legacy entries without a kind render
  as issues.

SKILL.md / CLAUDE.md (root index)
- Refresh the Feedback skill description to match the new flow:
  bias-toward-sending framing, required fields, pre-auth note.

index.html
- Update the homepage Feedback section copy: drop the "if your human
  is unsatisfied" bar, invite both issues and praise.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feedback: keep agent param permissive at the API

The previous commit made `agent` required at the API and would 400
on missing values. That's the wrong call:

- The validation is theater. Any client can pass it by sending
  "agent": "unknown" — we can't verify the value, so the 400 only
  punishes well-meaning clients that happen to omit the field.
- It contradicts the rest of this PR's thesis ("missing signals
  can't be recovered"). An agent reading a stale SKILL.md, or one
  that just forgot the field, would get rejected and give up.
- The SKILL.md is the lever that shapes agent behavior, not the
  API. Mark the field required in the docs, keep the API permissive
  as a safety net.

Drops the 400 and lets missing agent fall through as null, matching
how legacy entries already render.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feedback: review cleanup — PII first, robust kind, schema clarity

- feedback/SKILL.md: move sensitive-data section to step 1 so
  pre-authorized agents see it before any "skip the ask" guidance.
- feedback/SKILL.md: replace the JSON-shaped (but unparseable) endpoint
  block with a clear required/optional field list. Agents that copy code
  fences sometimes try to parse them.
- api/feedback.js: case- and whitespace-tolerant kind normalization
  ("Praise", " praise " no longer silently coerce to issue).
- inbox.html: collapse the dead ternary that produced the same string
  in both branches.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feedback: rename problem→message, strict kind, sentinel pre-auth

- Rename `problem` → `message` so the field reads correctly for both
  issues and praise. API accepts legacy `problem` for back-compat;
  inbox falls back to `e.problem` for entries already stored.
- Reject unknown `kind` values with 400 instead of silently coercing
  to "issue". Empty/missing still defaults to "issue" (legacy compat).
  Stops `kind: "praize"` from polluting the issue bucket.
- Move `agent` from required to strongly-encouraged in the skill so
  the doc matches the API's permissive validation.
- Replace the natural-language pre-auth hint with a literal sentinel
  (`ethskills-feedback-preauthorized`) so the agent's check is a
  string match, not a judgment call. Add a line noting that pre-auth
  removes the human PII review — the agent is the only safeguard.
- Clarify that the YAML-ish ask is a rendering; the wire format is
  JSON below.

---------

Co-authored-by: Agent <agent@example.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: austintgriffith <austin.griffith@ethereum.org>

2026-04-29 21:51:28 -06:00

..

feedback.js

feedback: lower friction, capture praise, draft-and-ask flow (#155)

2026-04-29 21:51:28 -06:00