Commit Graph

2 Commits

Author SHA1 Message Date
Arnav 3f29e56d0b fix(cli): report the install mode that actually happened (#205)
On Windows without symlink privilege, install_skills falls back to copying
per agent directory. The fallback was tracked per call, so the warning
printed 12 times and the setup summary still claimed 'mode: symlink'.

Track the fallback module-wide: warn once, and report 'mode: copy'.

Verified on a Windows Server 2022 box (ACP 936, non-admin user).
2026-08-31 15:54:37 -07:00
georgelichen 7620af79ff Keep Windows skill setup working without link privileges (#189)
Windows agent installs can contain directory junctions, and standard accounts
often cannot create new symbolic links. Detect link-like entries safely, remove
junctions without traversing their targets, fall back to copied skills only for
WinError 1314, and make status output tolerant of GBK consoles.

Constraint: Windows users may lack Developer Mode or Create symbolic links privilege
Rejected: Require elevation or Developer Mode | blocks standard Windows accounts
Confidence: high
Scope-risk: moderate
Reversibility: clean
Directive: Keep --copy as the explicit deterministic mode; only WinError 1314 may trigger automatic fallback
Tested: pytest -q tests/test_cli_install.py tests/test_ast_extractor.py tests/test_cache.py tests/test_graph_analysis.py tests/test_graphrag.py (196 passed); py_compile; actual obsidian-wiki setup with the target vault (exit 0)
Not-tested: Full suite still has unrelated Windows doctor/environment failures
Related: #186 #187 #188

Co-authored-by: Chen Li <george_lichne@163.com>
2026-08-23 06:49:57 -07:00