angular__angular

mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00

Files

T

Paul Gschwendtner 866271a1c6 refactor(core): EventEmitter implements OutputRef. (#54650 )

An `EventEmitter` is a construct owned by Angular that should be
used for outputs as of right now.

As we are introducing the new `OutputRef` interface for the new output
function APIs, we also think `EventEmitter` should implement
`OutputRef`— ensuring all "known" outputs follow the same contract.

This commit ensures `EventEmitter` implements an `OutputRef`

Note: An output ref captures the destroy ref from the current injection
context for clean-up purposes. This is also done for `EventEmitter` in a
backwards compatible way:

- not requiring an injection context. EventEmitter may be used
  elsewhere.
- not cleaning up subscriptions/completing the emitter when the
  directive/component is destroyed. This would be a change in behavior.

Note 2: The dependency on `DestroyRef` causes it to be retained in all
bundling examples because ironically `NgZone` uses `EventEmitter`- not
for outputs. The code is pretty minimal though, so that should be
acceptable.

`EventEmitter` will now always retain `NgZone. This increases the
payload size slightly around 800b for AIO. Note that the other increases
were coming from previous changes. This commit just pushed it over the
threshold.

PR Close #54650

2024-03-06 12:34:39 +01:00

circular-deps

refactor(core): EventEmitter implements OutputRef. (#54650 )

2024-03-06 12:34:39 +01:00

public-api

refactor(core): EventEmitter implements OutputRef. (#54650 )

2024-03-06 12:34:39 +01:00

size-tracking

refactor(core): EventEmitter implements OutputRef. (#54650 )

2024-03-06 12:34:39 +01:00

BUILD.bazel

build: use api-golden tool from dev-infra for testing public API (#42688 )

2021-06-30 11:43:48 -07:00

README.md

docs: remove redudant word in goldens/README.md (#44192 )

2021-11-17 10:34:08 -08:00

README.md

`public-api/`

This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of our bazel tests.

To check or update the public api goldens, run one of the following commands:

yarn public-api:check
yarn public-api:update

`packages-circular-deps.json`

This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.

To check or update the golden, run the following commands:

yarn ts-circular-deps:check
yarn ts-circular-deps:approve