mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
Andrew Scott
dc23ad4978
This commit extracts the Router's navigation "transitions" to a separate file. The goal here is twofold: - Separate the Router's logic into more manageable chunks. Rather than having to always edit a 1000+ line file, this separates different pieces into smaller, more focused files - More importantly, this sets the groundwork for separating the Router state from the individual navigation transition. That is, it would be good for the rxjs pipeline to _not_ modify the Router state but only keep track of its own intermediate stages and emit outwards during important events. The Router can subscribe to those events and make updates to its state. This would theoretically allow us to swap those implementations independently. That is, the Router's state management can be changed without changing the transition handling and vice-versa. PR Close #48187
public-api/
This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of our bazel tests.
To check or update the public api goldens, run one of the following commands:
yarn public-api:check
yarn public-api:update
packages-circular-deps.json
This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.
To check or update the golden, run the following commands:
yarn ts-circular-deps:check
yarn ts-circular-deps:approve