mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
Paul Gschwendtner
862aafbec9
The recent update to CLDR 41 highlighted (internally) that some time formats have changed to rely on locale-specific day periods. In particular the `zh_TW` (or canonical: `zh_Hant`) has changed some time formats/patterns from the universal `AM/PM` symbols (`a`) to `B`. The `b`/`B` symbols rely on locale-specific day period rules. This data is only extracted from CLDR into the so-called extra locale data that Angular provides. To fix this, and to be able to reverse the internal workaround that doesn't allow us to use the actual CLDR 41 data here, we always provide the locale extra data when conditonally loading CLDR data based on `goog.LOCALE`. This will result in additional payload cost that locale-specific JS bundles have to pay, but the only alternative would be to break Angular's `b`/`B` symbol support in favor of falling back to `AM/PM` rules (similar to how Closure Libray itself does it). For our external users (something I want to note here), they will be able to load the extra data easily (like it was possible before). Angular has some good erroring if the extra data is required. Most of our users will always use the global locale files anyway (the Angular CLI always uses them). These come with the extra data by default. Resources: - https://github.com/unicode-org/cldr/commit/0d538327d1ea2a31d1614d8989007b97a3ee5021 - https://github.com/unicode-org/cldr/blob/0d538327d1ea2a31d1614d8989007b97a3ee5021/common/main/zh_Hant.xml - https://github.com/angular/angular/blob/6a4353cb40227330be2a5685adca485a8b8e8a0b/packages/common/src/i18n/format_date.ts#L609-L639 - https://cldr.unicode.org/translation/date-time/date-time-symbols - https://cs.github.com/angular/angular-cli/blob/4be7cdce8283a177b92594bb7b34b4718d0a39c3/packages/angular_devkit/build_angular/src/utils/i18n-options.ts?q=%22locales%2Fglobal%22#L23 PR Close #46167