mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
7d9492353d
currently if a user tries to navigate via keyboard, once the are presented with search results, the search results panel remains present and can potentially hide most of the content on the page, in such case keyboard navigation will be severly hindered and the only option for the user would be to go back to the seach input text and clear its value, fix such inconvenience by looping the focus in the header area close to the search results and the results panel itself note: an alternative implementation using the cdkTrapFocus has been attempted in PR #45194, such alternative implementation presented a number of (minor) drawbacks (including the increase main bundle size due to the inclusion of the A11yModule), so it was agreed to proceed with the manual implementation present in these changes instead. PR Close #44989
public-api/
This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of our bazel tests.
To check or update the public api goldens, run one of the following commands:
yarn public-api:check
yarn public-api:update
packages-circular-deps.json
This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.
To check or update the golden, run the following commands:
yarn ts-circular-deps:check
yarn ts-circular-deps:approve