angular__angular

mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00

Files

T

Andrew Scott fe3e4d6865 fix(compiler-cli): Handle ng-template with structural directive in indexer (#44788 )

An `ng-template` with an inline template (i.e. has a structural
directive) would previously not get an `undefined` `tagName` because the
logic assumed the element would be `t.Element` or `t.Content` and read
the tag name from the `name` property. For a `t.Template`, this exists
instead on the `t.tagName`. The final result would be an `tagName` of `undefined`
for the parent `t.Template`, causing failures in the indexer downstream.

This `undefined` value is actually expected in the renderer code, even
though the type does not specify this possibility. This change updates
the type of `tagName` to be `string|null` and explicitly handles the
case where there is a structural directive on an `ng-template`. You can
see how the two are differentiated in the compliance code that was
modified in this commit.

PR Close #44788

2022-01-25 14:15:45 -08:00

design

refactor: fix various typos across different packages (#44523 )

2022-01-07 18:11:10 +00:00

src

fix(compiler-cli): Handle ng-template with structural directive in indexer (#44788 )

2022-01-25 14:15:45 -08:00

test

fix(compiler-cli): Handle ng-template with structural directive in indexer (#44788 )

2022-01-25 14:15:45 -08:00

testing

test: remove view-engine-only tests (#43884 )