mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
772e08d14e
The commit which made the `canceledNavigationResolution` property on the `Router` public did not add the corresponding configuration in the `ExtraOptions`. https://github.com/angular/angular/commit/3c6b653089837459809a370ebcaf8911c3bab9ed This was a mistake and is being corrected in this commit. We should not encourage changing the properties post-setup (i.e. `inject(Router).canceledNavigationResolution = 'computed'`). This manner of configuration makes the options non-tree shakeable because we have to keep both implementations in case the value changes at runtime. PR Close #43842
public-api/
This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of the our bazel tests.
To check or update the public api goldens, run one of the following commands:
yarn public-api:check
yarn public-api:update
packages-circular-deps.json
This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.
To check or update the golden, run the following commands:
yarn ts-circular-deps:check
yarn ts-circular-deps:approve