angular__angular

mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00

Files

T

Andrew Scott ccb09b4558 fix(router): null/undefined routerLink should disable navigation (#43087 )

The current behavior of `routerLink` for `null` and `undefined` inputs is to treat
the input the same as `[]`. This creates several unresolvable issues with
correctly disabling the links because `commands = []` does _not_ behave the same
as disabling a link. Instead, it navigates to the current page, but will also
clear any fragment and/or query params.

The new behavior of the `routerLink` input will be to completely disable navigation
for `null` and `undefined` inputs. For HTML Anchor elements, this will also mean
removing the `href` attribute.

Fixes #21457
Fixes #13980
Fixes #31154

BREAKING CHANGE:
Previously `null` and `undefined` inputs for `routerLink` were
equaivalent to empty string and there was no way to disable the link's
navigation.
In addition, the `href` is changed from a property `HostBinding()` to an
attribute binding (`HostBinding('attr.href')`). The effect of this
change is that `DebugElement.properties['href']` will now return the
`href` value returned by the native element which will be the full URL
rather than the internal value of the `RouterLink` `href` property.

PR Close #43087

2021-08-20 12:51:09 -07:00

circular-deps

refactor(compiler): remove cyclic dependencies (#43129 )

2021-08-16 13:07:23 -07:00

public-api

fix(router): null/undefined routerLink should disable navigation (#43087 )

2021-08-20 12:51:09 -07:00

size-tracking

fix(core): incorrect error reported when trying to re-create view which had an error during creation (#43005 )

2021-08-04 08:58:28 -07:00

BUILD.bazel

build: use api-golden tool from dev-infra for testing public API (#42688 )

2021-06-30 11:43:48 -07:00

README.md

…

README.md

`public-api/`

This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of the our bazel tests.

To check or update the public api goldens, run one of the following commands:

yarn public-api:check
yarn public-api:update

`packages-circular-deps.json`

This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.

To check or update the golden, run the following commands:

yarn ts-circular-deps:check
yarn ts-circular-deps:approve