mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
Matthew Beck
547d85addf
- Run comparison benchmark in an isolated git worktree to prevent workspace pollution and local branch conflicts. - Harden security by passing benchmark target and SHA as environment variables to prevent shell injection, and adding '--' to bazel query and git rev-parse. - Optimize workflow by removing pnpm caching to mitigate cache poisoning risks. - Improve robustness of benchmark log parsing, supporting both ZIP outputs and raw directories, and safely checking for JSON reports. - Centralize git command execution on the dev-infra GitClient for consistency. - Add tslib to benchpress dependencies to prevent module resolution failures.
57 lines
1.7 KiB
TypeScript
57 lines
1.7 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.dev/license
|
|
*/
|
|
|
|
import fs from 'fs';
|
|
import path from 'path';
|
|
import {exec, projectDir} from './utils.mts';
|
|
|
|
/** Branded string representing a resolved Bazel benchmark target. */
|
|
export type ResolvedTarget = string & {
|
|
__resolvedTarget: true;
|
|
};
|
|
|
|
/** Finds all benchmark Bazel targets in the project. */
|
|
export async function findBenchmarkTargets(): Promise<string[]> {
|
|
return (
|
|
await exec('pnpm', [
|
|
'bazel',
|
|
'query',
|
|
'--output=label',
|
|
`kind("^js_test|^web_test", //modules/...) intersect attr("name", "^perf$", //modules/...)`,
|
|
])
|
|
)
|
|
.split(/\r?\n/)
|
|
.filter((t) => t !== '');
|
|
}
|
|
|
|
/** Gets the testlog path of a given Bazel target. */
|
|
export async function getTestlogPath(
|
|
target: ResolvedTarget,
|
|
cwd: string = projectDir,
|
|
): Promise<string> {
|
|
const symlinkPath = path.join(cwd, 'dist/testlogs', target.substring(2).replace(':', '/'));
|
|
if (fs.existsSync(path.join(cwd, 'dist/testlogs'))) {
|
|
return symlinkPath;
|
|
}
|
|
try {
|
|
const bazelTestlogs = (
|
|
await exec('pnpm', ['bazel', 'info', 'bazel-testlogs', '--lockfile_mode=update'], cwd)
|
|
).trim();
|
|
return path.join(bazelTestlogs, target.substring(2).replace(':', '/'));
|
|
} catch (e) {
|
|
return symlinkPath;
|
|
}
|
|
}
|
|
|
|
/** Resolves a given benchmark Bazel target to the fully expanded label. */
|
|
export async function resolveTarget(target: string): Promise<ResolvedTarget> {
|
|
return (
|
|
await exec('pnpm', ['bazel', 'query', '--output=label', '--', target])
|
|
).trim() as ResolvedTarget;
|
|
}
|