angular__angular

mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00

Files

T

History

Andrew Scott 658cf8c384 fix(core): ComponentFixture stability should match ApplicationRef (#54949 )

This change aligns the stability of `ComponentFixture` with that of
`ApplicationRef`, preventing confusing differences between the two as
more APIs start using the `PendingTasks` that may not be tracked by
`NgZone`.

BREAKING CHANGE: `ComponentFixture.whenStable` now matches the
`ApplicationRef.isStable` observable. Prior to this change, stability
of the fixture did not include everything that was considered in
`ApplicationRef`. `whenStable` of the fixture will now include unfinished
router navigations and unfinished `HttpClient` requests. This will cause
tests that `await` the `whenStable` promise to time out when there are
incomplete requests. To fix this, remove the `whenStable`,
instead wait for another condition, or ensure `HttpTestingController`
mocks responses for all requests. Try adding `HttpTestingController.verify()`
before your `await fixture.whenStable` to identify the open requests.
Also, make sure your tests wait for the stability promise. We found many
examples of tests that did not, meaning the expectations did not execute
within the test body.

In addition, `ComponentFixture.isStable` would synchronously switch to
true in some scenarios but will now always be asynchronous.

PR Close #54949

2024-03-27 11:01:28 -07:00

circular-deps

refactor(compiler): Delete TemplateDefinitionBuilder and helpers (#54757 )

2024-03-08 16:51:01 -08:00

public-api

fix(core): ComponentFixture stability should match ApplicationRef (#54949 )

2024-03-27 11:01:28 -07:00

size-tracking

build: fix size failure (#54756 )

2024-03-07 16:13:43 -08:00

BUILD.bazel

build: use api-golden tool from dev-infra for testing public API (#42688 )

2021-06-30 11:43:48 -07:00

README.md

docs: remove redudant word in goldens/README.md (#44192 )

2021-11-17 10:34:08 -08:00

README.md

`public-api/`

This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of our bazel tests.

To check or update the public api goldens, run one of the following commands:

yarn public-api:check
yarn public-api:update

`packages-circular-deps.json`

This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.

To check or update the golden, run the following commands:

yarn ts-circular-deps:check
yarn ts-circular-deps:approve