mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
Paul Gschwendtner
acf98268f8
The Angular Language Service package is now tested & compiled using ESM. Previously it was a mismatch of CommonJS and ESM. Still the language-service ESM output is transformed into a single UMD bundle to allow for module resolution to be overriden. See `bundles/BUILD`. This is kept as is. To fully ship ESM (language-service is an exception here), we need to: * Update all code to no longer reference typescript via import. Instead typescript needs to be passed around so that the extension can control the version * The VSCode extension/ the TS server needs to be able to load ESM. It looks like the server supports ESM global plugins, but the extension might not yet. This is out of scope for the dev-infra effort as it requires more insight into VSCode & the extension system & the TS language server. PR Close #48521
88 lines
3.0 KiB
TypeScript
88 lines
3.0 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright Google LLC All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
* found in the LICENSE file at https://angular.io/license
|
|
*/
|
|
|
|
import ts from 'typescript/lib/tsserverlibrary';
|
|
|
|
import {APP_COMPONENT, MockService, setup, TEST_TEMPLATE} from './mock_host';
|
|
|
|
/**
|
|
* The following specs do not directly test the CompilerFactory class, rather
|
|
* it asserts our understanding of the project/program/template interaction
|
|
* which forms the underlying assumption used in the CompilerFactory.
|
|
*/
|
|
|
|
describe('tsserver', () => {
|
|
let project: ts.server.Project;
|
|
let service: MockService;
|
|
|
|
beforeAll(() => {
|
|
const {project: _project, service: _service} = setup();
|
|
project = _project;
|
|
service = _service;
|
|
});
|
|
|
|
beforeEach(() => {
|
|
service.reset();
|
|
});
|
|
|
|
describe('project version', () => {
|
|
it('is updated after TS changes', () => {
|
|
const v0 = project.getProjectVersion();
|
|
service.overwriteInlineTemplate(APP_COMPONENT, `{{ foo }}`);
|
|
const v1 = project.getProjectVersion();
|
|
expect(v1).not.toBe(v0);
|
|
});
|
|
|
|
it('is updated after template changes', () => {
|
|
const v0 = project.getProjectVersion();
|
|
service.overwrite(TEST_TEMPLATE, `{{ bar }}`);
|
|
const v1 = project.getProjectVersion();
|
|
expect(v1).not.toBe(v0);
|
|
});
|
|
});
|
|
|
|
describe('program', () => {
|
|
it('is updated after TS changes', () => {
|
|
const p0 = project.getLanguageService().getProgram();
|
|
expect(p0).toBeDefined();
|
|
service.overwriteInlineTemplate(APP_COMPONENT, `{{ foo }}`);
|
|
const p1 = project.getLanguageService().getProgram();
|
|
expect(p1).not.toBe(p0);
|
|
});
|
|
|
|
it('is not updated after template changes', () => {
|
|
const p0 = project.getLanguageService().getProgram();
|
|
expect(p0).toBeDefined();
|
|
service.overwrite(TEST_TEMPLATE, `{{ bar }}`);
|
|
const p1 = project.getLanguageService().getProgram();
|
|
expect(p1).toBe(p0);
|
|
});
|
|
});
|
|
|
|
describe('external template', () => {
|
|
it('should not be part of the project root', () => {
|
|
// Templates should _never_ be added to the project root, otherwise they
|
|
// will be parsed as TS files.
|
|
const scriptInfo = service.getScriptInfo(TEST_TEMPLATE);
|
|
expect(project.isRoot(scriptInfo)).toBeFalse();
|
|
});
|
|
|
|
it('should be attached to project', () => {
|
|
const scriptInfo = service.getScriptInfo(TEST_TEMPLATE);
|
|
// Script info for external template must be attached to a project because
|
|
// that's the primary mechanism used in the extension to locate the right
|
|
// language service instance. See
|
|
// https://github.com/angular/vscode-ng-language-service/blob/b048f5f6b9996c5cf113b764c7ffe13d9eeb4285/server/src/session.ts#L192
|
|
expect(scriptInfo.isAttached(project)).toBeTrue();
|
|
// Attaching a script info to a project does not mean that the project
|
|
// will contain the script info. Kinda like friendship on social media.
|
|
expect(project.containsScriptInfo(scriptInfo)).toBeFalse();
|
|
});
|
|
});
|
|
});
|