mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
Paul Gschwendtner
90c2088679
This is basically a pre-step for combining devmode and prodmode into a
single compilation. We are already achieving this now, and can claim
with confidence that we reduced possible actions by half. This is
especially important now that prodmode is used more often, but rules
potentially still using the devmode ESM sources. We can avoid double
compilations (which existed before the whole ESM migration too!).
We will measure this more when we have more concrete documentation
of the changes & a better planning document.
Changes:
* ts_library will no longer generate devmode `d.ts`. Definitions are
generated as part of prodmode. That way only prodmode can be exposed
via providers.
* applied the same to `ng_module`.
* updates migrations to bundle because *everything* using `ts_library`
is now ESM. This is actually also useful in the future if
schematics rely on e.g. the compiler.
* updates schematics for localize to also bundle. similar reason as
above.
PR Close #48521
55 lines
2.0 KiB
Python
55 lines
2.0 KiB
Python
load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
|
|
load("//tools:defaults.bzl", "nodejs_binary", "npm_package_bin")
|
|
|
|
def partial_compliance_golden(filePath):
|
|
"""Creates the generate and testing targets for partial compile results.
|
|
"""
|
|
|
|
# Remove the "TEST_CASES.json" substring from the end of the provided path.
|
|
path = filePath[:-len("/TEST_CASES.json")]
|
|
generate_partial_name = "partial_%s" % path
|
|
data = [
|
|
"//packages/compiler-cli/test/compliance/partial:generate_golden_partial_lib",
|
|
"//packages/compiler-cli/test/compliance/test_cases",
|
|
"//packages/compiler-cli/src/ngtsc/testing/fake_core:npm_package",
|
|
filePath,
|
|
]
|
|
|
|
nodejs_binary(
|
|
name = generate_partial_name,
|
|
testonly = True,
|
|
data = data,
|
|
visibility = [":__pkg__"],
|
|
entry_point = "//packages/compiler-cli/test/compliance/partial:cli.ts",
|
|
templated_args = ["$(execpath %s)" % filePath],
|
|
)
|
|
|
|
nodejs_binary(
|
|
name = generate_partial_name + ".debug",
|
|
testonly = True,
|
|
data = data,
|
|
visibility = [":__pkg__"],
|
|
entry_point = "//packages/compiler-cli/test/compliance/partial:cli.ts",
|
|
templated_args = ["--node_options=--inspect-brk", filePath],
|
|
)
|
|
|
|
npm_package_bin(
|
|
name = "_generated_%s" % path,
|
|
tool = generate_partial_name,
|
|
testonly = True,
|
|
stdout = "%s/_generated.js" % path,
|
|
link_workspace_root = True,
|
|
# Disable the linker and rely on patched resolution which works better on Windows
|
|
# and is less prone to race conditions when targets build concurrently.
|
|
args = ["--nobazel_run_linker"],
|
|
visibility = [":__pkg__"],
|
|
data = [],
|
|
)
|
|
|
|
generated_file_test(
|
|
visibility = ["//visibility:public"],
|
|
name = "%s.golden" % path,
|
|
src = "//packages/compiler-cli/test/compliance/test_cases:%s/GOLDEN_PARTIAL.js" % path,
|
|
generated = "_generated_%s" % path,
|
|
)
|