mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
George Kalpakas
33f9dba686
The `mergeOverridenImplementation` processor tries to ensure that any doc used with the `@overrideImplementation` annotation is not itself public (and explicitly marks is as internal if it is). Previously, it determined the public/private status of a doc by only checking the value of the doc's `internal` property (which is mainly set via the `@internal` annotation). This failed to account for docs marked as "private exports" (such as those prefixed with `ɵ`), which are essentially also treated as internal. This would result in incorrect warnings. [Example warning][1]: > Constructor doc forms/ɵFormControlCtor was not marked '@internal'; > adding this annotation. This commit prevents the incorrect warning by also checking the value of the doc's `privateExport` property to determine its public/private status. [1]: https://circleci.com/gh/angular/angular/1215057#step-104-164 PR Close #47201