Paul Gschwendtner
8d308dc4ec
The `NgComponentTemplateVisitor` helper was always referring back to the original source file on disk rather than the virtual file in the migration. This meant that some template migrations could attempt to modify the template multiple times resulting in invalid output. As an example the `migration-v13-router-link-empty-expression` migrates the following template: ``` <div [routerLink]></div> ``` to ``` <div [routerLink]="[]"></div> ``` But if the template was referenced multiple times in the program, such as when the component was referenced in the source and test entry-points, the migration would result in things like: ``` <div [routerLink]="[]"="[]"></div> ``` Fixes #44005. PR Close #44013
RouterLink null and undefined inputs
The previous behavior of RouterLink for null and undefined inputs was to treat
the input the same as [] or ''. This creates several unresolvable issues with
correctly disabling the links because commands = [] does not behave the same
as disabling a link. Instead, it navigates to the current page, but will also
clear any fragment and/or query params.
The new behavior of the routerLink input will be to completely disable navigation
for null and undefined inputs. For HTML Anchor elements, this will also mean
removing the href attribute.
<button [routerLink]="" fragment="section_2">section 2</button>
In the example from above, there is no value provided to the routerLink input.
This button would previously navigate to the current page and update the fragment to "section_2".
The updated behavior is to disable this link because the input
for routerLink is undefined.
If the intent for the link is to link to the current page rather than disable navigation, the template should be updated to one of the following options:
<button [routerLink]="[]" fragment="section_2">section 2</button>
<button [routerLink]="''" fragment="section_2">section 2</button>
<button routerLink fragment="section_2">section 2</button>