angular__angular

mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00

Files

T

History

George Kalpakas e09556fe2b refactor(service-worker): avoid unnecessary writes to cache when version fails (#43680 )

When an app version is detected as broken, the SW calls the
`Driver#versionFailed()` method. Previously, this method would in turn
call the `Driver#sync()` method, which writes some metadata about the
SW's state to the `ngsw:/:db:contol` cache. More specifically,
`Driver#sync()` persists info about all known app versions, which one is
the latest and also what version each client is assigned to.

However, no relevant info is changed inside `Driver#versionFailed()`, so
the call to `Driver#sync()` is redundant (since there are no changes
that need to be synced with the cache). This is a left-over from
before #43518, when `Driver#versionFailed()` used to update version
assignments and thus did require synchronization with the cache.

This commit removes the redundant `Driver#sync()` call to avoid an
unnecessary write to the cache.

PR Close #43680

2021-10-21 14:20:51 +00:00

cli

build: enable noImplicitOverride in project (#42512 )

2021-07-12 13:11:14 -07:00

config

fix(service-worker): make ngsw.json generation deterministic and correct (#43679 )

2021-10-05 13:34:31 -07:00

src

docs(service-worker): add missing comma in example JSON data (#42606 )

2021-07-08 10:27:16 -07:00

test

test(service-worker): better align mock client implementations with actual implementations (#42736 )