George Kalpakas
52ed53d071
build(docs-infra): upgrade cli command docs sources to b5e796a03 ( #28467 )
...
Updating [angular#7.2.x](https://github.com/angular/angular/tree/7.2.x ) from [cli-builds#7.3.x](https://github.com/angular/cli-builds/tree/7.3.x ).
Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/699743282...b5e796a03 ):
**Modified**
- help/add.json
- help/build.json
- help/generate.json
- help/new.json
PR Close #28467
2019-02-05 13:05:39 -05:00
Adam Plumer
dad1bc7ca3
build: bump year ( #28220 )
...
PR Close #28220
2019-02-04 16:41:00 -05:00
LHearen
2109c30afe
docs: fix shadow variable in tutorial example ( #28499 )
...
PR Close #28499
2019-02-04 14:54:53 -05:00
WilliamKoza
874919a25b
fix(docs-infra): remove polyfill web-animations since we use Angular > 6 and we don't use AnimationBuilder ( #28514 )
...
PR Close #28514
2019-02-04 14:54:26 -05:00
George Kalpakas
60c5ebd46a
ci(docs-infra): compile with Ivy ( #28421 )
...
Jira: FW-552
PR Close #28421
2019-02-04 11:02:40 -05:00
George Kalpakas
b71d1987cd
build(docs-infra): upgrade @angular/cli to 7.2.1 ( #28421 )
...
PR Close #28421
2019-02-04 11:02:40 -05:00
George Kalpakas
e6325eb9ef
refactor(docs-infra): get rid of on component input ( #28421 )
...
PR Close #28421
2019-02-04 11:02:40 -05:00
Filipe Silva
5f9d574d4d
build(docs-infra): update terser version in lockfile ( #28512 )
...
See https://github.com/angular/angular-cli/issues/13582#issuecomment-460261055 .
PR Close #28512
2019-02-04 10:52:07 -05:00
George Kalpakas
fa130e9445
ci: pin ChromeDriver to a version compatible with docker image's Chrome ( #28494 )
...
By default, `webdriver-manager update` will download the latest
ChromeDriver version, which might not be compatible with the Chrome
version included in the [docker image used on CI], causing CI failures.
Previously, we used to pin the ChromeDriver version on CI in
[ngcontainer's Dockerfile][2]. This was accidentally broken in #26691 ,
while moving from ngcontainer to default CircleCI docker images.
This commit fixes the issue by pinning ChromeDriver to a known
compatible version.
[1]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/.circleci/config.yml#L16
[2]: https://github.com/angular/angular/blob/bfd48d156d5663cc49d1ec40c2d73ff76a2fe62f/tools/ngcontainer/Dockerfile#L63
PR Close #28494
2019-02-01 20:22:04 -05:00
George Kalpakas
6ae5e2b32a
ci(docs-infra): reduce output verbosity to improve log readability ( #28494 )
...
PR Close #28494
2019-02-01 20:22:04 -05:00
Jeremy Elbourn
1a25144297
perf: pngcrush all pngs ( #28479 )
...
This is the result of running
```sh
find ./ -iname "*.png" -exec pngcrush -brute -ow -- {} \;
```
[Summary of size reductions](https://docs.google.com/spreadsheets/d/12Qgx7DfKabWw0PJza6ozC1kCHTofi6wyBLWGtwLW7G4/preview )
Last done in July, 2017 in #18243
PR Close #28479
2019-02-01 13:56:02 -05:00
Jeff Cross
5c85b4f1e9
docs: add Jeff Cross to contributors ( #28432 )
...
PR Close #28432
2019-01-29 16:41:32 -08:00
jithil-kore
22bc6ef22a
docs: fix typo for Browserslist in build guide ( #28328 )
...
PR Close #28328
2019-01-29 16:35:27 -08:00
Matti Järvinen
bf928d1c9e
docs: fix typo for Browserslist in file structure guide ( #28312 )
...
PR Close #28312
2019-01-29 16:33:19 -08:00
Nazar Nasirzada
d11c2f915b
docs: fix typo in lifecycle-hooks.md ( #28206 )
...
## PR Checklist
Please check if your PR fulfills the following requirements:
* [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
* [ ] Tests for the changes have been added (for bug fixes / features)
* [x] Docs have been added / updated (for bug fixes / features)
## PR Type
What kind of change does this PR introduce?
* [ ] Bugfix
* [ ] Feature
* [ ] Code style update (formatting, local variables)
* [ ] Refactoring (no functional changes, no api changes)
* [ ] Build related changes
* [ ] CI related changes
* [x] Documentation content changes
* [ ] angular.io application / infrastructure changes
* [ ] Other... Please describe:
## What is the current behavior?
Issue Number: N/A
## What is the new behavior?
## Does this PR introduce a breaking change?
* [ ] Yes
* [x] No
## Other information
PR Close #28206
2019-01-29 16:32:03 -08:00
Janghyun Han
98c99e5073
docs: angular.kr link added ( #28113 )
...
PR Close #28113
2019-01-29 16:31:38 -08:00
onlyflix
0ff48a1266
style: change to American English ( #27266 )
...
PR Close #27266
2019-01-29 16:30:26 -08:00
jithil-kore
cc1b2a5373
perf: yarn version upgrade ( #28360 )
...
PR Close #28360
2019-01-29 11:58:48 -08:00
WilliamKoza
5076185fc8
fix(docs-infra): add hamburger button to CLI COMMANDS section ( #28418 )
...
Currently, when we navigate in the `CLI COMMANDS` section, the "hamburger button" isn't present because the class css `folder-cli` is missing.
This PR add this class in order to show this button when we are in this section.
PR Close #28418
2019-01-29 11:48:34 -08:00
Alan Agius
65375f4c21
fix(docs-infra): boolean options default value is incorrect when it's undefined ( #27024 )
...
In the CLI when it's undefined it can mean `false`, or sometimes it will be overwritten by a runtime value.
PR Close #27024
2019-01-28 20:43:16 -08:00
Dhananjay Kumar
068a6070dc
docs(docs-infra): add ng-India to events list ( #28119 )
...
docs: add ng-India to events list
PR Close #28119
2019-01-28 20:18:52 -08:00
WilliamKoza
2f19ad9b46
fix(docs-infra): upgrade codelyzer to 4.5.0 ( #28389 )
...
PR Close #28389
2019-01-28 11:51:57 -08:00
George Kalpakas
1d67cb0ce1
test(docs-infra): increase timeout for redirection tests more ( #28290 )
...
Occasionally, external URLs take even longer than the previously set 60s
to load, which causes CI flakes.
PR Close #28290
2019-01-25 12:51:38 -08:00
George Kalpakas
318bd83a6e
test(docs-infra): unregister the SW after each test ( #28290 )
...
This ensures that the SW is cleaned up, even in cases where
synchronization is disabled (and thus the clean-up inside `goTo()`
happens without waiting for Angular).
PR Close #28290
2019-01-25 12:51:38 -08:00
George Kalpakas
f767c22b31
test(docs-infra): unregister the SW after waitForAngular() ( #28290 )
...
This increases the chances that the clean-up will take place _after_ the
SW has been registered.
PR Close #28290
2019-01-25 12:51:38 -08:00
George Kalpakas
8346a6dca2
test(docs-infra): properly report errors if page.init() fails/rejects ( #28290 )
...
For asynchronous callbacks, this can be done either by calling
`done.fail()` or by returning the promise directly (without requesting a
`done` callback). (Using the latter, because it is shorter.)
PR Close #28290
2019-01-25 12:51:37 -08:00
WilliamKoza
bc1032866c
fix(docs-infra): change the key used to find out the cli section ( #28293 )
...
PR Close #28293
2019-01-24 15:41:45 -08:00
Carlos Schneider
63e6d1a896
docs(docs-infra): show top menu at 992px screen width ( #26418 )
...
Show top menu at 992px screen width. The JS expression was checking just for screen widths
strictly greater than 992px to show the menu, while the CSS media query was showing the hamburger
icon just for screen widths strictly smaller than 992px, so there was a gap of 1px that the user
could't navigate through the top menu.
closes #24324
PR Close #26418
2019-01-24 10:26:55 -08:00
WilliamKoza
cb9fd9b4d7
feat(docs-infra): saves the scroll position before the change of location ( #28037 )
...
Issue #27916 , #17308
PR Close #28037
2019-01-24 10:24:43 -08:00
George Kalpakas
d5dca0764c
fix(docs-infra): align property names to the top ( #28104 )
...
This looks better when the property descriptions span multiple lines;
especially when scrolling to a specific property (e.g.
[AbstractControl#status][1]).
[1]: https://next.angular.io/api/forms/AbstractControl#status
PR Close #28104
2019-01-24 10:24:04 -08:00
George Kalpakas
bcd1a09dec
refactor(docs-infra): remove unused CSS style rule ( #28104 )
...
The `.properties-table` selector does not match any element and the
styles don't look relevant for the similarly named `.property-table`
class.
PR Close #28104
2019-01-24 10:24:04 -08:00
Dario Braun
898c0134e7
docs: fix typo and add parenthesis to method in HTTP tutorial ( #28289 )
...
Merge remote-tracking branch 'origin/TOH' into TOH
PR Close #28289
2019-01-24 10:23:25 -08:00
George Kalpakas
beacbfcb8e
build(docs-infra): upgrade cli command docs sources to 699743282 ( #28329 )
...
Updating [angular#7.2.x](https://github.com/angular/angular/tree/7.2.x ) from [cli-builds#7.2.x](https://github.com/angular/cli-builds/tree/7.2.x ).
Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/02d2ec250...699743282 ):
**Modified**
- help/generate.json
- help/new.json
PR Close #28329
2019-01-24 10:18:56 -08:00
Daniel Ruf
5877b3f702
refactor: remove unused parameter in _main method invocation ( #28203 )
...
PR Close #28203
2019-01-23 10:58:39 -08:00
Luiz Machado
54565ed389
docs: fix crisis-detail milestone files ( #27025 )
...
Crisis Detail's template was being added two times and the component's TS none.
PR Close #27025
2019-01-22 11:19:51 -08:00
WilliamKoza
eb8ccf65d1
fix(docs-infra): removal of the use of the ChildNode.remove() method that it isn't supported by IE ( #28188 )
...
fixes #28177
PR Close #28188
2019-01-22 09:48:20 -08:00
WilliamKoza
f4ac96d0ff
style(docs-infra): Active tslint rule semicolon ( #28282 )
...
PR Close #28282
2019-01-22 09:38:45 -08:00
George Kalpakas
49bee4c0d8
ci(docs-infra): do not automatically post preview comments on PRs for team ( #28211 )
...
Right now, we post such comments whenever a file has been touched that
could potentially have affected the docs. Since the API docs are built
from comments in the source code, almost all non-docs changes are
generating such preview comments, even though most of the time they are
irrelevant to the author and create unnecessary noise on the PR
(especially for actively worked-on PRs).
This commit removes the `team` GitHub team from the list of teams whose
members will automatically get preview comments.
(Adding the `aio: preview` label would still work on any PR.)
Jira: FW-967
PR Close #28211
2019-01-17 14:11:43 -08:00
Kapunahele Wong
d8c75f1bb0
docs: fix comments in services example ( #26194 )
...
PR Close #26194
2019-01-16 17:38:24 -08:00
WilliamKoza
6d40ef2d6b
fix(docs-infra): improve a11y ( #28086 )
...
Issue #27723
PR Close #28086
2019-01-16 17:37:46 -08:00
krzysztof-grzybek
de80f1b6dd
docs: update testing doc example style for HostListener ( #26372 )
...
HostListener is preferred over host metadata by official style guide
PR Close #26372
2019-01-16 11:56:52 -08:00
Malgosia
f269e433a7
docs: ng config link fix ( #28115 )
...
Fixed 'ng config' link to lead to proper CLI command site
PR Close #28115
2019-01-16 11:56:52 -08:00
WilliamKoza
8750b09fca
fix(docs-infra): Add crossed through styling ( #28111 )
...
PR Close #28111
2019-01-16 11:56:52 -08:00
WilliamKoza
ea2eef737b
fix(docs-infra): change style of deprecated markers ( #28111 )
...
PR Close #28111
2019-01-16 11:56:52 -08:00
WilliamKoza
0ceab97a03
fix(docs-infra): render deprecated markers for CLI command options ( #28111 )
...
fixes #27563
fixes #27423
PR Close #28111
2019-01-16 11:56:52 -08:00
javatutorials2016
5390948360
docs: fix typo in singleton services guide ( #27948 )
...
PR Close #27948
2019-01-16 11:56:51 -08:00
Shivam_Vyas
0d860051af
docs: change in(what should I import? answer) NgModule FAQs ( #27677 )
...
I think only should be after BrowserModule , because we can import more than BrowserModule and I think we need to import other modules to AppModule in most of cases and we should import BrowserModule only in AppModule,so that thing seems okay.
PR Close #27677
2019-01-16 11:56:51 -08:00
Ashinze Ekene
edbba24b60
docs: fix typo in dependency injection guide ( #27616 )
...
~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*
PR Close #27616
2019-01-16 11:56:51 -08:00
Brad Brandhorst
6ae8d7691d
docs: fix typo in docs.md ( #27484 )
...
Added a period to the end of the last sentence in the first paragraph
PR Close #27484
2019-01-16 11:56:51 -08:00
coultonluke
1be2f11965
docs: updates to minor spelling mistakes in pipes guide ( #27208 )
...
PR Close #27208
2019-01-16 11:56:51 -08:00