c41b3c83ca
build: update public-api approvers ( #60328 )
...
Adds myself and Paul to the public API reviewers to help with the reviews.
PR Close #60328
2025-03-11 11:07:19 -07:00
347c3d5761
build: remove circular deps goldens ( #60021 )
...
Removes the circular dependencies golden file and cleans up the
associated pullapprove group. All circular dependencies have been
removed and no new ones may be added.
PR Close #60021
2025-02-19 21:01:32 +00:00
c056fb9df9
ci: add mmalerba to pullapprove ( #60005 )
...
Add mmalerba to pullapprove config
PR Close #60005
2025-02-19 15:18:07 +00:00
d46aa79873
build: update zone.js pullapprove rule ( #59942 )
...
This fixes the broken pullapprove config due to a missing array.
PR Close #59942
2025-02-13 20:16:49 +00:00
d1a3e6203c
build: update zone.js pullapprove rule ( #59941 )
...
This excludes lock and package files from requiring zones approval.
PR Close #59941
2025-02-13 19:17:13 +00:00
8ee91bceed
build: remove self from unavailable list ( #59858 )
...
remove self from unavailable list
PR Close #59858
2025-02-05 12:18:57 -08:00
3d1496274c
ci: update Ethan Cline GitHub user name ( #59516 )
...
Use case-sensitive user name.
PR Close #59516
2025-01-14 10:52:04 -05:00
a648fa14dd
ci: Add self (Ethan Cline) as primitives-shared reviewer. ( #59437 )
...
Add self (Ethan Cline) as primitives-shared reviewer.
PR Close #59437
2025-01-09 10:31:29 -05:00
97039e8ce8
ci: remove devversion from unavailable pullapprove list ( #59391 )
...
Removing myself as I'm available for reviews.
PR Close #59391
2025-01-07 15:31:49 +00:00
2c3630aafd
ci: consolidate pullapprove groups ( #59080 )
...
This change was originally proposed by @alxhub. We should all be comfortable reviewing and approving any and all code in the repo. This consolidation removes the barriers for that to happen.
PR Close #59080
2024-12-19 14:38:42 -07:00
f073bedda4
ci: add kirjs to pullapprove groups ( #59025 )
...
This adds Kirill to a number of pullapprove groups.
PR Close #59025
2024-12-03 18:31:37 +01:00
7c628f9ee8
ci: mark devversion as unavailable ( #59007 )
...
Will be unavailable for a bit, and don't want to block review queue :)
PR Close #59007
2024-12-02 15:13:23 +01:00
9fced64146
ci: remove circleci as we no longer rely on it ( #58615 )
...
Remove CircleCI artifacts and configuration
PR Close #58615
2024-11-12 18:39:25 +00:00
4c3e1a99c1
ci: add packages/ssr in pullappove ( #58556 )
...
This directory was not included in the pullapprove config.
PR Close #58556
2024-11-07 22:43:23 +00:00
55c442033f
ci: add myself to the renovate-changes PullApprove group ( #58537 )
...
I frequently need to ping others to approve Renovate PRs, so this should streamline the process.
PR Close #58537
2024-11-07 18:51:48 +00:00
9cd9428992
ci: clean up pullapprove list ( #58325 )
...
This removes no longer active users from the shared primitives list of reviewers.
PR Close #58325
2024-10-23 07:59:49 -07:00
84b6896956
refactor(platform-server): Add an ssr benchmark setup. ( #57647 )
...
In order to investigate the performances of SSR, this commit introduces a benchmark suite which will measure several step of the rendering.
PR Close #57647
2024-10-04 10:45:22 -07:00
bb06d3eecd
ci: add atscott to unavailable list ( #57995 )
...
I will not be available to review PRs for a while
PR Close #57995
2024-09-30 13:34:24 -07:00
5c967f37b1
ci: make PullApprove config up-to-date ( #57985 )
...
This commit updates PullApprove config:
- Removes Dylan
- Adds Alex to the `fw-forms` group
- Adds Charles to the `fw-language-service` group
PR Close #57985
2024-09-30 13:30:42 -07:00
a448f5a6f2
ci: update ownership to include MarkTechson ( #57885 )
...
Update pullapprove to include MarkTechson in ownership of a couple areas.
PR Close #57885
2024-09-20 16:59:49 +02:00
ddbdf224a5
ci: update pullapprove config to enact changes for renovate ( #57853 )
...
Enact the pullapprove config for changes to renovate reviews
PR Close #57853
2024-09-19 11:18:35 +02:00
37f8c9a1d9
ci: fix fw-testing group triggering for schematics testing changes ( #57526 )
...
The `fw-testing` group should not trigger for schematic changes.
PR Close #57526
2024-08-27 13:21:47 -07:00
8f08d04916
ci: add an entry for aio in the pullapprove config ( #56952 )
...
This would allow me & ben to review some of the changes on the 17.3 branch, for example the redirections.
PR Close #56952
2024-07-11 17:03:26 -07:00
ecd5e6b754
ci: update pullapprove primitives list ( #56761 )
...
This removes one user from the shared primitives group to fix pullapprove requests.
PR Close #56761
2024-06-28 21:07:59 +00:00
917cd14bb4
ci: add more team members into the public-api group ( #56743 )
...
This commit adds more team members into the `public-api` group, so that they can approve public API changes, but they would not be requested for reviews by PullApprove (to avoid requests for unrelated changes).
PR Close #56743
2024-06-27 18:24:43 +00:00
0bd55a684f
refactor(docs-infra): complete removal of aio directory ( #56496 )
...
Finish removal of aio directory as it is no longer used or relied upon.
PR Close #56496
2024-06-18 12:26:00 -07:00
f0fbced1c5
docs: update and reorganize contributor docs ( #56141 )
...
* Move from `docs/` to `contributing-docs/`
* Updated file names to better communicate their content
* Consolidated content into fewer docs
* Updated and/or deleted obsolete info
PR Close #56141
2024-06-11 08:20:59 -07:00
c673a0288d
ci: add dylhunn@ to language-service pullapprove ( #55999 )
...
Add dylhunn@ as an approver for language service code.
PR Close #55999
2024-06-03 16:19:49 +00:00
67128c321b
ci: update explicit required reviews for primitives ( #56191 )
...
This removes the explicit 1 review required for the primitives and primitives-shared groups so that PR creators can serve as their own approval for that group.
PR Close #56191
2024-05-30 18:34:58 +00:00
b9b78d12bc
ci: update primitives-shared membership ( #56189 )
...
This updates the shared primitives ownership list to be correct.
PR Close #56189
2024-05-30 17:28:25 +00:00
e41a52286f
Revert "refactor: move example generation into adev, removing content from aio ( #55263 )" ( #55326 )
...
This reverts commit 9bc15994ceClose #55326
2024-04-12 14:57:05 -07:00
92debf4476
ci: Merge primitives-shared and primitives-event-dispatch groups ( #55273 )
...
This simplifies the approvals necessary for the event dispatch directory
PR Close #55273
2024-04-10 10:59:43 -07:00
e742787c6f
docs: add guide for the output() function ( #54946 )
...
Adds a guide for angular.io that introduces the new `output()` function
(and `outputFromObservable`).
PR Close #54946
2024-04-10 10:40:41 -07:00
9bc15994ce
refactor: move example generation into adev, removing content from aio ( #55263 )
...
Remove the content from aio and set up the example generation in adev
PR Close #55263
2024-04-09 11:18:48 -07:00
f83da4f94f
ci: required by is optional for primitives ( #55265 )
...
This adjusts the need for required by in PR reviews for shared primitives.
PR Close #55265
2024-04-09 10:29:09 -07:00
8cd1b2323a
ci: pullapprove is case sensitive ( #55220 )
...
This fixes thePunderWoman for case sensitivity
PR Close #55220
2024-04-04 21:27:18 -07:00
6c25f29535
ci: jessicajaniuk is thePunderWoman ( #55205 )
...
this swaps jessica for jessica.
PR Close #55205
2024-04-03 16:05:17 -07:00
6f960afd31
ci: fixes jsaction path name ( #55199 )
...
This updates the jsaction path to be event-dispatch.
PR Close #55199
2024-04-03 18:27:45 +00:00
2ff74dcd95
ci: Add primitives groups to pullapprove ( #53404 )
...
This adds the shared primitives reviewers groups and list of reviewers
to the pullapprove rules.
PR Close #53404
2024-04-03 17:06:04 +00:00
52970e3f23
docs: add updating to v17 guide ( #52410 )
...
PR Close #52410
2024-02-28 14:19:45 +01:00
4066e62db6
ci: use angular/team Github team for minimum review set ( #54611 )
...
Use the angular/team Github team to define the list of eligible minimum reviewer set so that it can be reused accross the organization
PR Close #54611
2024-02-27 15:17:07 -08:00
54b5a2f130
ci: correct @jeanmeche to @JeanMeche in pullapprove ( #54610 )
...
Correct the casing so that it works as expected.
PR Close #54610
2024-02-26 18:25:08 +00:00
4efcc74dd6
docs: add a guide for model inputs ( #54514 )
...
Adds a guide for `model()` inputs for angular.io. Will port this over to angular.dev once it's finalized.
PR Close #54514
2024-02-23 11:47:03 -08:00
35e5ba0ba6
ci: adding Matthieu as approver for ADEV ( #54575 )
...
This is to help the team approve changes on the new doc site.
PR Close #54575
2024-02-23 11:42:44 -08:00
ee9c272434
docs: add guide for signal queries ( #54395 )
...
Adding new guide for the signal-based queries.
PR Close #54395
2024-02-15 12:17:01 -08:00
12d4b8eb47
docs: add guide for signal inputs ( #54316 )
...
Adds a guide for signal inputs.
We will port that to `angular.dev` once we finalized this version.
PR Close #54316
2024-02-14 15:22:49 -08:00
5d98a023bc
ci: Add framework team to adev approvers ( #54082 )
...
This adds the entire framework team to the adev approvers list.
PR Close #54082
2024-02-01 17:44:59 +00:00
23eeea5bd7
ci: adding devversion to reviewers for compiler/core ( #54053 )
...
I've been working on framework parts and compiler since pre-Ivy, and
helped with Ivy, runtime and compiler. Adding myself as a reviewer to
ease future work and to help with review load.
PR Close #54053
2024-01-26 19:10:56 +00:00
a6dad59536
ci: update adev approvers list ( #54081 )
...
This temporarily updates the adev approvers list before we decide how we will handle adev content reviews going forward.
PR Close #54081
2024-01-25 20:40:08 +00:00
d5c0743380
ci: add ben to reviewers for adev files ( #54078 )
...
For ADEV changes going forward, Ben will be helping the team to review all PRs associated with this project.
PR Close #54078
2024-01-25 20:18:51 +00:00
Kristiyan Kostadinov