28878 Commits

Author SHA1 Message Date
Dylan Hunn ac8eb5b943 Revert "fix(router): Ensure canMatch guards run on wildcard routes (#53239)" (#53339)
This reverts commit 1940280d27.

PR Close #53339
2023-12-03 14:57:54 -08:00
Miles Malerba 21741384f4 docs(compiler): Improve code comments (#53300)
Adds better comments describing the case where we have multiple ICU
sub-messages that share the same plaeholder.

PR Close #53300
2023-12-01 14:51:30 -08:00
Miles Malerba c1d9b71c4a test(compiler): Enable newly passing tests (#53300)
Enables additional tests that pass after implementing the ICU logic.

PR Close #53300
2023-12-01 14:51:30 -08:00
Miles Malerba ec61ef0895 refactor(compiler): Fix ingestion of nested ICUs (#53300)
It is possible for ICUs to be nested inside other ICUs. This change
adjusts our ingestion logic to create extra interpolation ops for the
nested ICUs during ingestion.

PR Close #53300
2023-12-01 14:51:30 -08:00
Miles Malerba 5ce3190da7 refactor(compiler): Remove invalid assertion about i18n params (#53300)
We previously had an assertion that every placeholder in the i18n AST
had a corresponding param in the output. However, there are some cases
such as interpolations nested inside ICUs where this assertion is not
true. This change simply removes the asserion.

PR Close #53300
2023-12-01 14:51:30 -08:00
Miles Malerba a9e8c3cb0b refactor(compiler): Add support for ICUs that share a placeholder (#53300)
ICUs may share a placeholder, and in that case they need special
post-processing. This change adds logic to cover this possibility. In
particular, we set the param to a special placeholder value and then
pass an array containing the sub-message variables as a post-processing
param.

PR Close #53300
2023-12-01 14:51:30 -08:00
Miles Malerba c8b34623d9 refactor(compiler): Handle i18n placeholders with spaces (#53300)
I18n placeholders may contain spaces, this change updates the formatting
logic to replace them with underscores in the output.

PR Close #53300
2023-12-01 14:51:30 -08:00
Miles Malerba 9040ea4d19 refactor(compiler): Put i18n expression ops in the correct order (#53300)
When we re-assign the slot dependencies for the i18nExprs, we should
move them down below the other ops that target their same slot. This
keeps the behavior consistent with TDB

PR Close #53300
2023-12-01 14:51:29 -08:00
pBouillon af5da6db66 docs: fix the colspan and colSpan link in the property binding page (#53180)
PR Close #53180
2023-12-01 10:36:54 -08:00
Matthieu Riegler 83a3aa58f3 docs: Error codes should start with a 0. (#53271)
Also adding NG0602 to adev.

PR Close #53271
2023-12-01 10:36:21 -08:00
Andrew Kushnir 8e366e8911 fix(core): support swapping hydrated views in @for loops (#53274)
This commit fixes an issue where swapping hydrated views was not possible in the new control flow repeater. The problem was caused by the fact that an internal representation of a view had no indication that hydration is completed and further detaching/attaching should work in a regular (non-hydration) mode. This commit adds a logic that resets a pointer to a dehydrated content and we use this as an indication that the view is swtiched to a regular mode.

Resolves #53163.

PR Close #53274
2023-12-01 10:35:37 -08:00
Jessica Janiuk 58a96e0f50 fix(migrations): CF Migration add support for ngIf with just a then (#53297)
Prior to this fix, the expectation that anytime then was used, else would always be present. That is not a valid assumption.

fixes: #53287

PR Close #53297
2023-12-01 10:33:53 -08:00
Jessica Janiuk 45064f1ae1 fix(migrations): CF migration - ensure NgIfElse attributes are properly removed (#53298)
the attribute in question was assumed to be at the start of the replaced content, but it could be later, too.

fixes: #53288

PR Close #53298
2023-12-01 10:32:36 -08:00
Jessica Janiuk a6275cfa54 fix(migrations): CF Migration - Fix case of aliases on i18n ng-templates preventing removal (#53299)
i18n template removal expected no other attributes to be present, but if a bound ngIf is present with aliases and i18n, that is more than what was expected. Now it should safely remove them appropriately.

fixes: #53289

PR Close #53299
2023-12-01 09:18:32 -08:00
Andrew Kushnir 14e66533ec fix(core): support hydration for cases when content is re-projected using ng-template (#53304)
This commit fixes an issue with hydration, which happens when a content is projected in a certain way, leaving host elements non-projected, but the child content projected.

The fix is to detect such situations and add extra annotations to help runtime logic locate those elements at the right locations.

Resolves #53276.

PR Close #53304
2023-12-01 09:12:55 -08:00
Andrew Kushnir a2e5f483f5 fix(compiler): generate proper code for nullish coalescing in styling host bindings (#53305)
This commit fixes an issue where having an expression with nullish coalescing in styling host bindings leads to JS errors due to the fact that a declaration for a temporary variable was not included into the generated code.

Resolves #53295.

PR Close #53305
2023-12-01 09:12:20 -08:00
Andrew Scott 13ade13a15 fix(router): Ensure canMatch guards run on wildcard routes (#53239)
This commit makes sure that wildcard routes still run the `canMatch`
guards.

Fixes #49949

PR Close #53239
2023-11-30 09:45:41 -08:00
Tomasz Ducin 8c0e7733d6 refactor(devtools): devtools support for maps and symbol description (#53167)
Added 2 tiny improvements:
- instead of "Symbol()", "Symbol(DESCRIPTION)" is displayed
- ECMAScript Maps are distinguished
Additionally:
- PropTypes has been moved to a separate file
- Simple unit tests covering each PropType except for PropType.Unknown

PR Close #53167
2023-11-30 09:45:13 -08:00
Matthieu Riegler f812e72b80 fix(devtools): use a shared angular detection code (#51569)
This fixes an issue where an angular app exposes a global `ng` object that is not our `ng`.

fixes #51565

PR Close #51569
2023-11-30 09:40:12 -08:00
AleksanderBodurri 3f65485e94 docs(devtools): write feature descriptions for new DI debugging features in Angular Devtools (#52290)
This commit adds new sections to the devtools aio page for the new DI debugging features in Angular DevTools:

1. Directive dependency inspection
2. Injector hierarchy visualization

PR Close #52290
2023-11-30 09:38:27 -08:00
Alexander Melde 2a39e64288 docs: fix typo in control flow track description (#52849)
as -> are
PR Close #52849
2023-11-30 09:37:38 -08:00
Sylvain DEDIEU 00a9fd04c0 docs: update http providers example to show the app.config.ts instead of the main.ts (#52848)
The examples of how to provide the http fetch, cookie/header name and disabling XSRF protection now show the app.config.ts file instead of the main.ts file since the cli boostrap application with this architecture.

PR Close #52848
2023-11-30 09:37:06 -08:00
Sasidharan SD 95e84c5e0b docs: fix variable name in code comment (#52851)
PR Close #52851
2023-11-30 09:36:37 -08:00
Sasidharan SD cd14750028 docs: remove repetetive line (#52864)
PR Close #52864
2023-11-30 09:36:10 -08:00
Sai Kumar Kola 9b47003d26 docs: fix typo in learn-angular/forms-validation (#52901)
PR Close #52901
2023-11-30 09:35:43 -08:00
Sasidharan SD 114b840a54 docs: fix typo on form tutorial step 18 (#52908)
PR Close #52908
2023-11-30 09:35:14 -08:00
Pridon Tetradze 60dc59ba24 docs: add missing --no-standalone flag (#52910)
PR Close #52910
2023-11-30 09:34:41 -08:00
Sylvain DEDIEU 063954a6f4 docs: wrong web docs urls for host and host-context (#52966)
Wrong MDN Web Docs URLs for host / host-context on angular.dev

PR Close #52966
2023-11-30 09:34:14 -08:00
Sasidharan SD 12027f5815 docs: fix minor typos in tutorials (#52970)
PR Close #52970
2023-11-30 09:33:46 -08:00
Isaac Aggrey 6478c191b9 docs: fix typo (#53039)
PR Close #53039
2023-11-30 09:33:17 -08:00
Matthieu Riegler 0dbf48b799 docs: fix image path for directive overview (#53048)
fixes #53047

PR Close #53048
2023-11-30 09:32:35 -08:00
Sasidharan SD d6998af34b docs: fix angular press kit logo title (#53055)
PR Close #53055
2023-11-30 09:30:04 -08:00
Matthieu Riegler 848a3fe87e docs: fix section title on binding.md (#53072)
fixes #53070

PR Close #53072
2023-11-30 09:29:32 -08:00
Sasidharan SD a97a6db168 docs: fix directives header (#53080)
PR Close #53080
2023-11-30 09:29:06 -08:00
Sasidharan SD 485fb1d309 docs: fix inconsistent example in binding page (#53081)
PR Close #53081
2023-11-30 09:28:35 -08:00
Sasidharan SD 2f42366b2c docs: update template ref variable with correct link (#53084)
PR Close #53084
2023-11-30 09:28:09 -08:00
Alejandro c67cd2678d docs: remove extra parenthesis in multiple examples and extra backtick (#53098)
PR Close #53098
2023-11-30 09:27:40 -08:00
oliv37 3b58058456 docs: fix schematics links (#53121)
PR Close #53121
2023-11-30 09:27:14 -08:00
Tamás Baranyi 487b87ab2b docs: tutorial url on tutorials/first-app/http page fixed (#53125)
fixes: #53122

PR Close #53125
2023-11-30 09:25:58 -08:00
Balaji 3c9559b340 docs: added more context to the description of standalone components card (#53186)
PR Close #53186
2023-11-30 09:23:31 -08:00
Balaji 640540ada3 docs: updated the description of typed forms card (#53186)
PR Close #53186
2023-11-30 09:23:30 -08:00
Balaji 9d8da59f8b docs: updated the description of module with providers card (#53186)
PR Close #53186
2023-11-30 09:23:30 -08:00
Balaji f29ecadc17 docs: updated the description of standalone components card (#53186)
PR Close #53186
2023-11-30 09:23:30 -08:00
Balaji 535245a326 docs: updated the headline of migration overview section (#53186)
PR Close #53186
2023-11-30 09:23:30 -08:00
prasantht96 9805c179d6 docs: fix typos in adev (#53189)
PR Close #53189
2023-11-30 09:23:03 -08:00
Abhishek Upadhyay 295c26d78d docs: corrected gramatical mistake in ssr.md (#53264)
PR Close #53264
2023-11-30 09:22:00 -08:00
Jan-Niklas W 1be5fc0955 docs: remove unnecessary word (#53265)
PR Close #53265
2023-11-30 09:21:34 -08:00
Fabian Schmidt a7bc603263 docs: fix typo in word "intrinsic" for adev and aio (#53250)
This is a fix for two typos in both angular.dev and angular.io docs

PR Close #53250
2023-11-30 09:20:10 -08:00
Jessica Janiuk 72d22ba7ee fix(migrations): fix regexp for else and then in cf migration (#53257)
The regexp for then and else did not ignore alphanumeric characters prior to the then and else. So if a string contained then, for example Authentication, it would incorrectly match as a then clause.

fixes: #53252

PR Close #53257
2023-11-30 09:19:43 -08:00
Jessica Janiuk 7a2facae8a fix(migrations): handle aliases on bound ngIf migrations (#53261)
This fixes a reported issue where ngIf is used on an ng-template with let aliases.

fixes: #53251

PR Close #53261
2023-11-30 09:19:15 -08:00