Derek Cormier
04935771b7
build(bazel): fix a failing example e2e test that failed to find the
...
shadow root
This broke after using the chrome version provided by dev-infra.
2022-11-22 13:51:16 -07:00
Derek Cormier
8775a745ad
build(bazel): fix some aio linting errors
...
Surfaced by modifying ci to include aio targets
2022-11-22 13:51:16 -07:00
Derek Cormier
50dee93f35
build(bazel): add aio targets to ci
...
This is a first pass. There is more work to do on package.json, adding
more test targets under bazel, and revising documentation.
2022-11-22 13:51:16 -07:00
Derek Cormier
bc1e93d639
build(bazel): refactor aio example e2es to fix windows performance
...
Use the same config flag to enable local vs npm deps as aio.
2022-11-22 13:51:16 -07:00
Derek Cormier
22a317de3d
build(bazel): stamp targets to build, test, and serve aio against
...
first party deps
Architect is not compatible with disabling the rules_nodejs linker so
these targets must use npm_link to link first party deps
2022-11-22 13:51:16 -07:00
Derek Cormier
7a134cf41a
build(bazel): incrementally run aio example e2e tests
...
Replaces the workflow where all example e2es are run at once
2022-11-22 13:51:16 -07:00
Derek Cormier
8015d467fd
build(bazel): remove rules_nodejs patch
...
This patch was added to remove an unnecessary wrapper script around
nodejs binaries which prevented running esm scripts when the linker
was disabled.
2022-11-22 13:51:16 -07:00
Derek Cormier
07126ae40f
build(bazel): fix race conditions in windows aio build
...
Disables the rules_nodejs linker and adds a custom esm module resolver
2022-11-22 13:51:16 -07:00
Derek Cormier
7c8ca113c1
build(bazel): replace ignore example feature with bazel equivalent
...
Comment out the entry in the EXAMPLES map to ignore an example.
2022-11-22 13:51:16 -07:00
Derek Cormier
9a27c4cb50
build(bazel): incrementally build aio example zips and live examples
...
The existing scripts were amended to work on one example at a time
2022-11-22 13:51:16 -07:00
Derek Cormier
7642abfb7a
build(bazel): fix bazel aio regressions after rebase
...
The aio-bazel-migration branch was rebased onto main to include runfiles
support on windows.
2022-11-22 13:51:16 -07:00
Derek Cormier
c5acfb2b33
build(bazel): run aio app tests with bazel-provided chromium
...
Similar to the e2e protractor tests
2022-11-22 13:51:16 -07:00
Derek Cormier
b5ebe9ae6e
build(bazel): run aio application e2e tests under bazel
...
Includes a postinstall fix for puppeteer so that chromium
can be run with protractor on osx under bazel
2022-11-22 13:51:16 -07:00
Derek Cormier
20ff128103
build(bazel): create targets for aio example tooling tests
...
This replaces the boilerplate:test npm script
2022-11-22 13:51:16 -07:00
Derek Cormier
8678550a94
build(bazel): create targets for aio docs tests
...
This replaces the docs-test npm script
2022-11-22 13:51:16 -07:00
Derek Cormier
2daf369ec8
build(bazel): add an aio fast serve target
...
This is equivalent to docs-watch in the legacy build.
2022-11-22 13:51:16 -07:00
Derek Cormier
9cb9161876
build(bazel): generate aio stackblitz and example zips
...
Can be served by running bazel run //aio:serve
2022-11-22 13:51:16 -07:00
Derek Cormier
655427f9b8
build(bazel): add a bazel aio serve target
...
This works with ibazel but is not highly incremental
2022-11-22 13:51:16 -07:00
Derek Cormier
431c562815
build(bazel): add bazel targets for aio doc generation
...
This is an incremental step to produce dgeni output with bazel. The
generated outputs are not yet used by other targets.
2022-11-22 13:51:16 -07:00
Bob Watson
4f03a9c327
docs: fix broken link in v15 deprecations table ( #48157 )
...
PR Close #48157
2022-11-22 11:39:47 -08:00
Bob Watson
2e2135bf18
docs: add missing documentation setup instructions ( #48174 )
...
PR Close #48174
2022-11-22 11:39:25 -08:00
Wooshaah
7fbb53f52d
docs(forms): fix typos in removeValidators and hasValidator usage notes ( #48144 )
...
PR Close #48144
2022-11-22 11:39:02 -08:00
Matthieu Riegler
5127a4d5ed
refactor(platform-browser): Remove ViewEncapsulation.Native warning ( #48101 )
...
ViewEncapsulation.Native has been dropped in v11, let's remove this warning.
PR Close #48101
2022-11-22 11:38:25 -08:00
Andrew Scott
83f0b7b7b2
refactor(router): Update RouterOutlet to not read internal route property ( #48112 )
...
The `RouterOutlet` currently reads the `_futureSnapshot` of the Route.
However, by the time `activateWith` is called, this value is the same as
`snapshot` (https://github.com/angular/angular/blob/414b1b2d5ffe8eac33749bf472af7eafcf248dba/packages/router/src/operators/activate_routes.ts#L163-L205 ).
This change will make it easier for developers to fork the `RouterOutlet`
implementation if necessary without needing to modify any code.
PR Close #48112
2022-11-22 11:37:38 -08:00
Andrew Scott
bc148c30d5
refactor(router): Remove unnecessary logic in enabledBlocking option ( #48064 )
...
The `initNavigated` flag is not necessary. The way `enabledBlocking`
works is by blocking any navigations from finishing until the
application has bootstrapped. The bootstrap is unblocked as soon as we
hit the `afterPreactivation` step. After that point,
`afterPreactivation` is always unblocked because the `bootstrapDone`
Subject is completed/stopped. There is no need for an additional
variable to track this information.
PR Close #48064
2022-11-22 11:36:14 -08:00
Andrew Scott
73f03ad2d2
feat(router): Add new NavigationSkipped event for ignored navigations ( #48024 )
...
The Router currently silently ignores navigations for two reasons:
1. By default, same URL navigations are ignored. When this situation is
encountered, the navigation is ignored without any events
2. A `UrlHandlingStrategy` may ignore some URLs. For situations when the
strategy returns `false` for `shouldProcessUrl`, the Router silently
ignores the URL and updates its internal state without running
matching, guards, or resolver logic.
This commit adds new `NavigationSkipped` events for the above two situations.
PR Close #48024
2022-11-22 11:34:49 -08:00
Andrew Scott
ffc427bffc
test(router): Update flaky tests to consistently pass ( #48176 )
...
This commit makes several updates to the bootstrap tests of the Router.
The change that made the real difference was providing
`MockPlatformLocation`. Other changes include:
* using `async/await` instead of `done`
* not providing APP_BASE_HREF (recent router refactors made this unnecessary)
* using some functional guards to simplify some tests
PR Close #48176
2022-11-22 11:33:18 -08:00
Alan Agius
57a9f67ae8
docs: fix dates in release guide ( #48173 )
...
A version always stays for about a year in LTS.
PR Close #48173
2022-11-22 11:32:01 -08:00
Kristiyan Kostadinov
fd2eea5961
fix(language-service): correctly handle host directive inputs/outputs ( #48147 )
...
Adds some logic to correctly handle hidden or aliased inputs/outputs in the language service.
Fixes #48102 .
PR Close #48147
2022-11-22 09:47:49 -08:00
mgechev
c5d176ceb5
docs: add state of javascript banner ( #48160 )
...
PR Close #48160
2022-11-22 09:45:42 -08:00
Dylan Hunn
b0bc5783a7
docs: release notes for the v12.2.17 release
2022-11-22 09:44:22 -08:00
Nebojsa Cvetkovic
1976e37475
fix(router): restore 'history.state' on popstate even if navigationId missing ( #48033 )
...
If `history.pushState()` or `history.replaceState()` were called manually without including the `navigationId` field the state was being incorrectly discarded - that logic was for maintaining the original behavior of `NavigationStart.restoredState`.
Improves on #28176 , fully fixes #28108 , see also #28954
PR Close #48033
2022-11-21 13:46:17 -08:00
Ikko Ashimine
4ce9650ce4
docs: fix typo in navigation.json ( #48127 )
...
documenation -> documentation
PR Close #48127
2022-11-21 13:45:51 -08:00
Andrew Scott
b0a62bea47
fix(common): Fix MockPlatformLocation events and missing onPopState implementation ( #48113 )
...
The MockPlatformLocation forward, back, and historyGo methods should trigger a popstate event.
Additionally, these events should just be synchronous since that's what the majority of the major
browsers do. Lastly, onPopState should be implemented the same way as onHashChange.
PR Close #48113
2022-11-21 13:45:05 -08:00
Ivan Rodriguez
f376bf8deb
docs: fix typo in cli-builder.mf ( #48129 )
...
Replace `@example/my-builder` with `@example/my-builder`
PR Close #48129
2022-11-21 13:44:41 -08:00
Joe Roxbury
29b198f0c9
docs(forms): add FormRecord class to API summary ( #48136 )
...
Add the missing FormRecord class to the
Reactive forms API summary which is located under Developer Guides ->
Forms -> Reactive Forms.
Fixes #47808
PR Close #48136
2022-11-21 13:44:17 -08:00
Alan Agius
80d0cb5b5b
docs: add version 15 to active version ( #48148 )
...
With this change we update the releases docs to include version 15 as an active version and mark version 14 as an LTS.
Closes #48116
PR Close #48148
2022-11-21 13:43:45 -08:00
Dylan Hunn
ed50032316
docs: release notes for the v13.3.12 release
2022-11-21 13:16:28 -08:00
Dylan Hunn
6618b25426
docs: release notes for the v14.2.12 release
2022-11-21 12:55:25 -08:00
Andrew Scott
0a8b943d10
Revert "refactor(router): Remove promise catch and re-reject ( #48067 )" ( #48135 )
...
This reverts commit 07c9396824 . This
change caused test failures (both unit and integration). Though the code
looks like it should be a no-op update, it's possible it affecting
something to do with microtasks, zoneJS, and change detection. More
investigation would need to be done into the exact nature of the
failures.
PR Close #48135
2022-11-21 09:24:00 -08:00
Andrew Scott
02fb43a347
Revert "Revert "refactor(router): Simplify router defaults by making the defaults Injectable" ( #48121 )" ( #48135 )
...
This reverts commit 57d9296802 . The
original commit was not problematic and was mistakenly reverted.
PR Close #48135
2022-11-21 09:24:00 -08:00
Mikhail Savchuk
b653ee340e
docs: fix typo in image-directive.md ( #48115 )
...
PR Close #48115
2022-11-18 12:17:13 -08:00
Joey Perrott
8d81fcbe20
build: add labeled trigger for assistant-to-the-branch-manager ( #48119 )
...
Add the labeled trigger
PR Close #48119
2022-11-18 12:16:48 -08:00
Dylan Hunn
57d9296802
Revert "refactor(router): Simplify router defaults by making the defaults Injectable" ( #48121 )
...
This reverts commit 18033d5ed2 .
PR Close #48121
2022-11-18 12:16:17 -08:00
Greg Magolan
764fa3d9c3
fix(language-service): update packages/language-service/build.sh script to work with vscode-ng-language-service's new Bazel build ( #48120 )
...
Part of fix for angular/vscode-ng-language-service#1815
PR Close #48120
2022-11-18 10:21:05 -08:00
Bjarki
414b1b2d5f
docs: extract XSS security doc URL into a constant ( #48082 )
...
We plan to change the link in google3 to point to google3-specific
documentation. Replacing a single constant will make for a smaller and
more maintainable patch.
PR Close #48082
2022-11-17 13:21:16 -08:00
Volodymyr
8a45dab754
docs: Changed documentation for providers vs. viewProviders ( #47281 )
...
Content in ```<ng-content></ng-content>``` sees ```viewProviders``` from ```app-root```
PR Close #47281
2022-11-17 13:20:20 -08:00
Matthieu Riegler
d321880440
fix(forms): FormBuilder.group return right type with shorthand parameters. ( #48084 )
...
Extract AbstractControlOptions from type when used in shorthand parameters on FormBuilder.group
Fixes 48073
PR Close #48084
2022-11-17 11:04:54 -08:00
Andrew Scott
1df0ed7d6e
fix(router): Ensure renavigating in component init works with enabledBlocking ( #48063 )
...
The way to complete the `Subject` in a way that is able to be read on
the subject properties itself is to call `unsubscribe`:
https://github.com/ReactiveX/rxjs/blob/afac3d574323333572987e043adcd0f8d4cff546/src/internal/Subject.ts#L101-L104
This sets the `closed` property to `true` whereas `complete` does not.
fixes #48052
PR Close #48063
2022-11-17 11:01:13 -08:00
Dylan Hunn
ef6dbc8850
refactor(compiler): Add getPotentialPipes API method. ( #48090 )
...
`getPotentialPipes` returns possible pipes which can be used in the provided context, whether already in scope or requiring an import.
This is necessary to implement auto-import support for pipes in the language service.
PR Close #48090
2022-11-17 11:00:50 -08:00