25791 Commits

Author SHA1 Message Date
Derek Cormier 86fdcfcc0f build(bazel): point to correct dist folder in firebase config (#48214)
Point to the AIO dist folder in the Bazel output tree.

PR Close #48214
2022-11-23 23:20:36 +00:00
Derek Cormier 00864665a3 build(bazel): fix aio deployment unit tests (#48214)
Missing a spy for the new chmod call.

PR Close #48214
2022-11-23 23:20:36 +00:00
Derek Cormier 78b66b236b build(bazel): remove write protection on aio dist folder for deployment (#48214)
Deploy script adds extra files and needs write access.

PR Close #48214
2022-11-23 23:20:36 +00:00
Derek Cormier 049123cf6c build(bazel): fix AIO deployment unit tests (#48214)
Forgot to update the dist path in these tests.

PR Close #48214
2022-11-23 23:20:36 +00:00
Derek Cormier 7815acd125 build(bazel): fix dist dir in AIO deploy script (#48214)
The script is run cd'ed into aio so the path to the Bazel dist
location is up one folder.

PR Close #48214
2022-11-23 23:20:36 +00:00
Derek Cormier ae812e3936 build(bazel): fix AIO deployment script (#48214)
Don't run the script under Bazel, except for the tests. Configure a
Bazel flag to select the AIO build configuration.

PR Close #48214
2022-11-23 23:20:36 +00:00
Derek Cormier e044939fa9 build(bazel): fix yarn call in aio deploy script (#48214)
Incorrectly calls yarn scripts from the root package.

PR Close #48214
2022-11-23 23:20:36 +00:00
JoostK 86a21f5569 fix(compiler-cli): accept inheriting the constructor from a class in a library (#48156)
The stricter checks under `strictInjectionParameters` in Angular 15 now enforce that
an inherited constructor must be compatible with DI, based on whether all parameters
are valid injection tokens. There is an issue when the constructor is inherited from
a class in a declaration file though, as information on the usage of `@Inject()` is
not present within a declaration file. This means that this stricter check cannot be
accurately performed, resulting in false positives.

This commit disables the stricter check to behave the same as it did prior to
Angular 15, therefore avoiding the false positive.

Fixes #48152

PR Close #48156
2022-11-23 12:10:37 -08:00
Angular Robot c3ccaa83b4 build: update scorecard action dependencies (#47866)
See associated pull request for more information.

PR Close #47866
2022-11-23 10:54:13 -08:00
Angular Robot 6e9075e787 build: update bazel setup to v5.7.1 (#47884)
See associated pull request for more information.

PR Close #47884
2022-11-23 10:53:00 -08:00
Angular Robot 85c35cf693 build: update io_bazel_rules_sass digest to a2fce75 (#47970)
See associated pull request for more information.

PR Close #47970
2022-11-23 10:52:30 -08:00
Alan Agius b8ed822896 build: update safevalues to 0.4.2 (#48153)
This contains a fix which enabled the ESM version of the package to be consumed.

See: https://github.com/angular/angular/issues/48171#issuecomment-1324728758

PR Close #48153
2022-11-23 09:35:41 -08:00
Bob Watson 420af8ee47 docs: update AIO code to v15 (#48153)
PR Close #48153
2022-11-23 09:35:41 -08:00
Kristiyan Kostadinov 665d4650cd refactor(language-service): make selector nullable (#48193)
This is a follow-up from https://github.com/angular/angular/pull/48147. Changes the `DirectiveSymbol.selector` to be nullable since it's possible to have directives without a selector.

PR Close #48193
2022-11-23 09:27:03 -08:00
Dylan Hunn 40c138c13d release: cut the v15.0.1 release 15.0.1 2022-11-22 19:04:21 -08:00
Andrew Scott dc23ad4978 refactor(router): extract navigation transition code to a new file (#48187)
This commit extracts the Router's navigation "transitions" to a separate
file. The goal here is twofold:

- Separate the Router's logic into more manageable chunks. Rather than
  having to always edit a 1000+ line file, this separates different
  pieces into smaller, more focused files
- More importantly, this sets the groundwork for separating the Router
  state from the individual navigation transition. That is, it would be
  good for the rxjs pipeline to _not_ modify the Router state but only
  keep track of its own intermediate stages and emit outwards during
  important events. The Router can subscribe to those events and make
  updates to its state. This would theoretically allow us to swap those
  implementations independently. That is, the Router's state management
  can be changed without changing the transition handling and
  vice-versa.

PR Close #48187
2022-11-22 18:58:38 -08:00
Brooke 3596c44e0c docs: add brooke avery to GDE resources (#47923)
PR Close #47923
2022-11-22 16:22:06 -08:00
Joey Perrott 8600b3077d build: reformat BUILD files
Reformat BUILD file usage of globs.
2022-11-22 13:51:19 -07:00
Derek Cormier 31b2716c1c build(bazel): remaining AIO Bazel migration fixes
Fix the remaining AIO Bazel migration TODOs
2022-11-22 13:51:19 -07:00
Derek Cormier 65712b1d15 build(bazel): add missing dependency to deploy script
Cannot load the root package.json. Surfaced after trying to merge
aio-bazel-migration to main because the deployment short circuits
on ci for feature branhces.
2022-11-22 13:51:19 -07:00
Derek Cormier 4881e75097 build(bazel): mark a couple of aio example tests as flaky
May be caused by resource contention when running the example tests in
parallel.
2022-11-22 13:51:19 -07:00
Derek Cormier 2f5fe32b92 build(bazel): update workspace cli sources ref
Updates to the latest version still used in angular/main.
2022-11-22 13:51:19 -07:00
Derek Cormier 0136eb6d34 build(bazel): tweak parallel jobs for AIO local deps ci
Parallel runs of tests on circleci executor push RAM to the limits.
2022-11-22 13:51:19 -07:00
Derek Cormier 6efefec55c build(bazel): fix a regression when linking local packages for AIO example
tests

Caused by code moving around.
2022-11-22 13:51:19 -07:00
Derek Cormier 371a599c8e build(bazel): fix linking of local angular packages
Npm angular deps were transitively being included, confusing the
rules_nodejs linker.
2022-11-22 13:51:19 -07:00
Derek Cormier a02d114dae build(bazel): support ibazel for AIO example playgrounds
Also uses more fine-grained deps to make an ibazel rebuild fast.
2022-11-22 13:51:19 -07:00
Derek Cormier df5e1802a3 build(bazel): fix a bug where local ngc couldn't be linked into AIO example tests
The ngc entrypoint escapes the sandboxed example folder. Rather than
always symlinking local packages, copy the full package when there are
bin entries.
2022-11-22 13:51:19 -07:00
Derek Cormier c142511084 build(bazel): fix regressions for docs-watch
Some earlier refactoring prevented the watchr script from running in
the source tree. There was also a Windows issue where running architect
didn't preserve symlinks causing the app to not be served.
2022-11-22 13:51:19 -07:00
Derek Cormier 9520a029d2 build(bazel): fix remote cache missses on Windows and OSX
Caused by chromium debug logs in @angular/build-tooling.
2022-11-22 13:51:19 -07:00
Derek Cormier afad500f40 build(bazel): fix a regression where github links were incorrectly
written

Incorrectly prepended 'packages/' to docs that were under aio/content.
2022-11-22 13:51:19 -07:00
Derek Cormier 4199a8db08 build(bazel): fix missing dgeni dependencies
Fixes the 'Export has no declarations: unknown' warning and
unresolved type warnings.
2022-11-22 13:51:19 -07:00
Derek Cormier 6d9339559c build(bazel): update rnj and remove launcher patch
rules_nodejs released  a fix for the RUNFILES issue.
2022-11-22 13:51:19 -07:00
Derek Cormier 5769eb0bd2 build(bazel): consolidate windows chromium path workaround
Add the hack to a central location so that it's easier to fix later.
2022-11-22 13:51:19 -07:00
Derek Cormier da125dbb79 build(bazel): fix an AIO bug where symlinked assets were not loaded on
Windows

Added "followSymlinks" blocks on the assets.
2022-11-22 13:51:19 -07:00
Derek Cormier 84c1896b6b build(bazel): remove unused AIO package.json scripts
No longer needed after the migration
2022-11-22 13:51:19 -07:00
Derek Cormier b13783eeb6 build(bazel): update CLI sources ref for aio build
It was out of date with the current legacy build
2022-11-22 13:51:19 -07:00
Derek Cormier a908ba7a68 build(bazel): use workspace status command for AIO version stamping
Fixes a bug where the navigation map did not have the correct SHAs.
2022-11-22 13:51:19 -07:00
Derek Cormier 500acfcf98 build(bazel): create AIO example playgrounds for manual testing
After the bazel migration, AIO examples are no longer fully formed in
the source tree.
2022-11-22 13:51:19 -07:00
Derek Cormier 8df1deaad5 build(bazel): list docs entrypoints under packages to simplify docgen
target

Follows pattern in @angular/components.
2022-11-22 13:51:19 -07:00
Derek Cormier 9b169f60a6 build(bazel): fix a bug where the esm loader did not point to
node_modules in runfiles

Was passing locally previously due to escaping to the source tree.
2022-11-22 13:51:19 -07:00
Derek Cormier 71ee5d58cf build(bazel): clean up pathing in aio build tooling
Make use of process.env.RUNFILES.
2022-11-22 13:51:19 -07:00
Derek Cormier 0e0ec49f58 build(bazel): allow tag propagation on host machine
Fixes a bug where 'requires-network' tag was not propagated locally.
2022-11-22 13:51:19 -07:00
Derek Cormier 8d685f6997 build(bazel): update documentation for docs authors
Where possible, preseve the original yarn commands.
2022-11-22 13:51:19 -07:00
Derek Cormier 32cc63c067 build(bazel): fix a11y and pwa tests on Windows
Needed to use absoulte paths and fix a separator.
2022-11-22 13:51:19 -07:00
Derek Cormier eb07e5bbda build(bazel): remove old patch rules_nodejs patch
Patch contents included in rules_nodejs 5.6.0.
2022-11-22 13:51:19 -07:00
Derek Cormier 3fa6ae1ba9 build(bazel): fix a bug where $(GIT_BIN_PATH) wasn't providing a correct path on
Windows

Fixed in rules_nodejs 5.6.0
2022-11-22 13:51:19 -07:00
Derek Cormier 347e0139d5 build(bazel): fix windows regression caused by absolute esm loader path
The --loader argument can't handle absolute windows paths.
2022-11-22 13:51:19 -07:00
Derek Cormier 425035b8fd build(bazel): fix broken aio github links on Windows
Caused the aio e2e tests to fail.
2022-11-22 13:51:19 -07:00
Derek Cormier 6c6eaddbe2 build(bazel): fix aio example systemjs tests for locally linked packages
These required a preserveSymlinks hack similar to the CLI tests
2022-11-22 13:51:19 -07:00
Derek Cormier e43686f4d1 build(bazel): fix a bug where the opensearch url coudln't be substituted
The file was write protected in the bazel output tree.
2022-11-22 13:51:19 -07:00