Derek Cormier
cc5a35123d
build(bazel): fix some regressions
...
Caused by some incompatible changes that were merged in.
2022-11-22 13:51:19 -07:00
Derek Cormier
47045a5306
build(bazel): avoid network call during aio build by not inlining fonts
...
Allows the aio build target to be run under remote-exec
2022-11-22 13:51:19 -07:00
Derek Cormier
f183129eab
build(bazel): avoid writing ngsw-config to the source tree
...
This was originally done before runfiles was enabled and the output
and source trees were not merged for architect targets.
2022-11-22 13:51:19 -07:00
Derek Cormier
b0c110ab3a
build(bazel): fix a circular dep in aio
...
Probably caused by some incompatible merges.
2022-11-22 13:51:19 -07:00
Derek Cormier
19fe298d11
build(bazel): merge aio/tools/defaults.bzl and tools/defaults.bzl
...
Detect the correct workspace for the source maps dep.
2022-11-22 13:51:19 -07:00
Derek Cormier
57f63bf471
build(bazel): patch architect to not clear output
...
Otherwise a failed build requires looking in the command log for the
error.
2022-11-22 13:51:19 -07:00
Derek Cormier
c0655e447a
build(bazel): restore filtering for example e2e tests
...
Added a wrapper script that performs bazel queries, filters, then runs
the tests.
2022-11-22 13:51:19 -07:00
Derek Cormier
ec286048c9
build(bazel): fix load statement to point to new dev-infra package
...
This was introduced during a recent rebase.
2022-11-22 13:51:19 -07:00
Derek Cormier
7c12ebb50d
build(bazel): adjust aio opensearch substitution with bazel paths
...
Now points to the bazel dist folder.
2022-11-22 13:51:19 -07:00
Derek Cormier
4cafb67e82
build(bazel): fix a bug where aio firebase utils tests could not link
...
deps
ts-node doesn't appear to use the require patch
2022-11-22 13:51:19 -07:00
Derek Cormier
20b81d0647
build(bazel): run firebase deployment tests under bazel
...
The deployment is still run from a yarn script.
2022-11-22 13:51:19 -07:00
Derek Cormier
3603b4dbf3
build(bazel): test aio pwa score under bazel
...
Refactored the a11y score tests to share the pattern of running an http
server alongside a test script.
2022-11-22 13:51:19 -07:00
Derek Cormier
79554b7a39
build(bazel): run aio a11y tests under bazel
...
Wrap existsing scripts under bazel and write a new script
to spin up an http server on an unused port.
2022-11-22 13:51:19 -07:00
Derek Cormier
6fb3b6f5ba
build(bazel): post-rebase fixes for aio bazel build
...
Updated cli source snapshot and had to fix up lockfile.
2022-11-22 13:51:19 -07:00
Derek Cormier
8062e7113f
build(bazel): run aio firebase redirect tests under bazel
...
Adjust to run under ci.
2022-11-22 13:51:19 -07:00
Derek Cormier
7b5e073a70
build(bazel): run aio systemjs example e2es concurrently
...
These had to be run with the 'exclusive' tag under bazel due to
hardcoded ports.
2022-11-22 13:51:19 -07:00
Derek Cormier
e20bfda83d
build(bazel): Fix a bug where the aio build artifact didn't include assets.
...
Copy the applicaiton sources to the bin dir in order to find the generated relative asset paths.
2022-11-22 13:51:19 -07:00
Derek Cormier
adffd3fdf7
build(bazel): build aio 404 page under bazel
...
The legacy build injected this file into the dist folder, however that's
not possible under bazel so files are copied to a new directory.
2022-11-22 13:51:19 -07:00
Derek Cormier
d9a29e426a
build(bazel): clean up manual build contents for aio example deps
...
This avoids the need to depend on "node_modules" and "node_modules/.bin"
separately.
2022-11-22 13:51:19 -07:00
Derek Cormier
3f92ea57ea
build(bazel): fix a failing example e2e test that failed to find the
...
shadow root
This broke after using the chrome version provided by dev-infra.
2022-11-22 13:51:19 -07:00
Derek Cormier
fa92cf055d
build(bazel): fix some aio linting errors
...
Surfaced by modifying ci to include aio targets
2022-11-22 13:51:19 -07:00
Derek Cormier
4aab63f31e
build(bazel): add aio targets to ci
...
This is a first pass. There is more work to do on package.json, adding
more test targets under bazel, and revising documentation.
2022-11-22 13:51:19 -07:00
Derek Cormier
8d24a91c6a
build(bazel): refactor aio example e2es to fix windows performance
...
Use the same config flag to enable local vs npm deps as aio.
2022-11-22 13:51:19 -07:00
Derek Cormier
a36034a135
build(bazel): stamp targets to build, test, and serve aio against
...
first party deps
Architect is not compatible with disabling the rules_nodejs linker so
these targets must use npm_link to link first party deps
2022-11-22 13:51:19 -07:00
Derek Cormier
12855f3805
build(bazel): incrementally run aio example e2e tests
...
Replaces the workflow where all example e2es are run at once
2022-11-22 13:51:19 -07:00
Derek Cormier
f62339d1d1
build(bazel): remove rules_nodejs patch
...
This patch was added to remove an unnecessary wrapper script around
nodejs binaries which prevented running esm scripts when the linker
was disabled.
2022-11-22 13:51:19 -07:00
Derek Cormier
d7eb429430
build(bazel): fix race conditions in windows aio build
...
Disables the rules_nodejs linker and adds a custom esm module resolver
2022-11-22 13:51:19 -07:00
Derek Cormier
3d6315e6e8
build(bazel): replace ignore example feature with bazel equivalent
...
Comment out the entry in the EXAMPLES map to ignore an example.
2022-11-22 13:51:19 -07:00
Derek Cormier
5ece26a6dc
build(bazel): incrementally build aio example zips and live examples
...
The existing scripts were amended to work on one example at a time
2022-11-22 13:51:19 -07:00
Derek Cormier
1dc641ea30
build(bazel): fix bazel aio regressions after rebase
...
The aio-bazel-migration branch was rebased onto main to include runfiles
support on windows.
2022-11-22 13:51:19 -07:00
Derek Cormier
592eadd7c3
build(bazel): run aio app tests with bazel-provided chromium
...
Similar to the e2e protractor tests
2022-11-22 13:51:19 -07:00
Derek Cormier
216372316a
build(bazel): run aio application e2e tests under bazel
...
Includes a postinstall fix for puppeteer so that chromium
can be run with protractor on osx under bazel
2022-11-22 13:51:19 -07:00
Derek Cormier
7cbedba3af
build(bazel): create targets for aio example tooling tests
...
This replaces the boilerplate:test npm script
2022-11-22 13:51:19 -07:00
Derek Cormier
0b55b647aa
build(bazel): create targets for aio docs tests
...
This replaces the docs-test npm script
2022-11-22 13:51:19 -07:00
Derek Cormier
75e623b179
build(bazel): add an aio fast serve target
...
This is equivalent to docs-watch in the legacy build.
2022-11-22 13:51:19 -07:00
Derek Cormier
472abd7944
build(bazel): generate aio stackblitz and example zips
...
Can be served by running bazel run //aio:serve
2022-11-22 13:51:19 -07:00
Derek Cormier
4ff8f27bad
build(bazel): add a bazel aio serve target
...
This works with ibazel but is not highly incremental
2022-11-22 13:51:19 -07:00
Derek Cormier
c9478f78a2
build(bazel): add bazel targets for aio doc generation
...
This is an incremental step to produce dgeni output with bazel. The
generated outputs are not yet used by other targets.
2022-11-22 13:51:19 -07:00
Bob Watson
8ab50a13d7
docs: fix broken link in v15 deprecations table ( #48157 )
...
PR Close #48157
2022-11-22 11:39:48 -08:00
Bob Watson
f689250605
docs: add missing documentation setup instructions ( #48174 )
...
PR Close #48174
2022-11-22 11:39:25 -08:00
Wooshaah
cfc224983f
docs(forms): fix typos in removeValidators and hasValidator usage notes ( #48144 )
...
PR Close #48144
2022-11-22 11:39:03 -08:00
Andrew Scott
ebcca47402
refactor(router): Update RouterOutlet to not read internal route property ( #48112 )
...
The `RouterOutlet` currently reads the `_futureSnapshot` of the Route.
However, by the time `activateWith` is called, this value is the same as
`snapshot` (https://github.com/angular/angular/blob/414b1b2d5ffe8eac33749bf472af7eafcf248dba/packages/router/src/operators/activate_routes.ts#L163-L205 ).
This change will make it easier for developers to fork the `RouterOutlet`
implementation if necessary without needing to modify any code.
PR Close #48112
2022-11-22 11:37:38 -08:00
Andrew Scott
11d916dcfd
refactor(router): Remove unnecessary logic in enabledBlocking option ( #48064 )
...
The `initNavigated` flag is not necessary. The way `enabledBlocking`
works is by blocking any navigations from finishing until the
application has bootstrapped. The bootstrap is unblocked as soon as we
hit the `afterPreactivation` step. After that point,
`afterPreactivation` is always unblocked because the `bootstrapDone`
Subject is completed/stopped. There is no need for an additional
variable to track this information.
PR Close #48064
2022-11-22 11:36:14 -08:00
Andrew Scott
d50fa6b79e
test(router): Update flaky tests to consistently pass ( #48176 )
...
This commit makes several updates to the bootstrap tests of the Router.
The change that made the real difference was providing
`MockPlatformLocation`. Other changes include:
* using `async/await` instead of `done`
* not providing APP_BASE_HREF (recent router refactors made this unnecessary)
* using some functional guards to simplify some tests
PR Close #48176
2022-11-22 11:33:19 -08:00
Alan Agius
d0631f8aa0
docs: fix dates in release guide ( #48173 )
...
A version always stays for about a year in LTS.
PR Close #48173
2022-11-22 11:32:01 -08:00
Kristiyan Kostadinov
cc8b76ef7c
fix(language-service): correctly handle host directive inputs/outputs ( #48147 )
...
Adds some logic to correctly handle hidden or aliased inputs/outputs in the language service.
Fixes #48102 .
PR Close #48147
2022-11-22 09:47:49 -08:00
Nebojsa Cvetkovic
fa5528fb5f
fix(router): restore 'history.state' on popstate even if navigationId missing ( #48033 )
...
If `history.pushState()` or `history.replaceState()` were called manually without including the `navigationId` field the state was being incorrectly discarded - that logic was for maintaining the original behavior of `NavigationStart.restoredState`.
Improves on #28176 , fully fixes #28108 , see also #28954
PR Close #48033
2022-11-21 13:46:17 -08:00
Ikko Ashimine
f612fce06f
docs: fix typo in navigation.json ( #48127 )
...
documenation -> documentation
PR Close #48127
2022-11-21 13:45:51 -08:00
Andrew Scott
930af9dd26
fix(common): Fix MockPlatformLocation events and missing onPopState implementation ( #48113 )
...
The MockPlatformLocation forward, back, and historyGo methods should trigger a popstate event.
Additionally, these events should just be synchronous since that's what the majority of the major
browsers do. Lastly, onPopState should be implemented the same way as onHashChange.
PR Close #48113
2022-11-21 13:45:06 -08:00
Ivan Rodriguez
7e3dad1ad2
docs: fix typo in cli-builder.mf ( #48129 )
...
Replace `@example/my-builder` with `@example/my-builder`
PR Close #48129
2022-11-21 13:44:42 -08:00