2b503c8da9
docs: Update markdown and formatting in image-directive topic. ( #47259 )
...
PR Close #47259
2022-09-06 11:30:50 -07:00
28d33505fd
fix(service-worker): only consider GET requests as navigation requests ( #47263 )
...
Previously, the criteria for determining if a request was a
[navigation request][1] did not account for the request method. This
incorrectly identified HTML form submit POST requests as navigation
requests and served `index.html` instead of passing them through to the
server, thus breaking the form submission.
This commit fixes this by ensuring that only GET requests are considered
navigation requests.
> **Note**
> HTML forms with their method set to `GET` will still be affected by
> the issue. This is not a big concern, because using `GET` for form
> submission is quite uncommon and generally discouraged (due to
> limitations and security considerations).
[1]: https://angular.io/guide/service-worker-config#handling-navigation-requests
Fixes #36368
PR Close #47263
2022-09-06 10:02:11 -07:00
b7c1d72a61
docs: fix linting errors in component overview guide ( #47352 )
...
PR Close #47352
2022-09-06 09:41:13 -07:00
57f13bfe73
docs: fix linting errors in class binding guide ( #47351 )
...
PR Close #47351
2022-09-06 09:40:40 -07:00
f11d6ffbb1
docs: apply suggestions from code review ( #47350 )
...
Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com >
PR Close #47350
2022-09-06 09:38:33 -07:00
798a92db91
docs: fix linting errors in architecture components guide ( #47350 )
...
PR Close #47350
2022-09-06 09:38:32 -07:00
be5180a6e0
docs: formatting issue ( #47349 )
...
There were some formatting issue and I just updated * to & in migration-undecorated-classes.md
PR Close #47349
2022-09-06 09:37:49 -07:00
200ddce88f
docs: update angular-package-format guide ( #47342 )
...
PR Close #47342
2022-09-06 09:35:39 -07:00
0ba363d5b5
docs: update aio/content/guide/angular-package-format.md with suggestion ( #47342 )
...
Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com >
PR Close #47342
2022-09-06 09:35:39 -07:00
5f065441ca
docs: apply suggestions from code review ( #47342 )
...
adding suggestions from Bob.
Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com >
PR Close #47342
2022-09-06 09:35:39 -07:00
55cc287ad5
docs: fix linting errors in angular package format guide ( #47342 )
...
PR Close #47342
2022-09-06 09:35:38 -07:00
0e2d2a576b
docs: fix grammar ( #47333 )
...
there aren't many forms here, the object model belongs to the form, hence the apostroph is needed before the letter s
PR Close #47333
2022-09-06 09:33:15 -07:00
a62f3fab45
docs: fixed a "grammatical opportunity" ( #47328 )
...
Since "application design" is being used as an adjective in the following sentence:
Angular is an application design framework and development platform for creating efficient and sophisticated single-page apps.
I recommend replacing it with "application-design" (cf. https://en.wikipedia.org/wiki/Compound_modifier ).
PR Close #47328
2022-09-06 09:32:26 -07:00
577673dcf7
docs: fix linting errors in change detection guide ( #47324 )
...
PR Close #47324
2022-09-06 09:31:21 -07:00
58fd2dccdc
docs: update cloudinary url ( #47320 )
...
PR Close #47320
2022-09-06 09:30:49 -07:00
d10b6f54c7
docs: fix typo in image directive guide ( #47313 )
...
PR Close #47313
2022-09-06 09:30:14 -07:00
c5d0da9dce
docs: fix doc linter warnings in app-shell.md ( #47282 )
...
PR Close #47282
2022-09-06 09:24:05 -07:00
3f81b2ac33
docs: fix doc linter warning and error in accessibility.md ( #47282 )
...
PR Close #47282
2022-09-06 09:24:04 -07:00
24660f6a37
docs: fix doc linter warnings in angular-compiler-options.md ( #47282 )
...
PR Close #47282
2022-09-06 09:24:04 -07:00
80155e8605
docs(service-worker): add note regarding assets and CORS ( #47262 )
...
Fixes #41931
PR Close #47262
2022-09-06 09:23:29 -07:00
41c845b4a7
docs: typo ( #47246 )
...
It appears that the indefinite pronoun either does not agree with the verb occur in your sentence. Consider changing the form of the verb.
PR Close #47246
2022-09-06 09:13:22 -07:00
acfa5cb2db
docs: compress the bios image ( #47244 )
...
PR Close #47244
2022-09-06 09:12:39 -07:00
8c6227f186
docs: add Maina Wycliffe to GDE resources ( #47244 )
...
PR Close #47244
2022-09-06 09:12:39 -07:00
7b92f214bb
docs(service-worker): improve docs related to SwUpdate APIs ( #46960 )
...
This commit improves documentation related to recently improved or
deprecated `SwUpdate` APIs in the following ways:
- Update [check-for-update.service.ts][1] to make use of the return
value of [SwUpdate#checkForUpdate()][2].
- Update [prompt-update.service.ts][3] to not call
[SwUpdate#activateUpdate()][4] and just reload the page.
- Update the [SwUpdate#activateUpdate()][4] API docs to explain that it
is only useful if you want to update a client without reloading and
that it can easily lead to version skew.
- Update [a code-snippet][5] to no longer be [hard-coded][6].
[1]: https://github.com/angular/angular/blob/9d9d05911dbd6e2f30e4c7bced0e41fd20ec4285/aio/content/examples/service-worker-getting-started/src/app/check-for-update.service.ts#L16
[2]: https://angular.io/api/service-worker/SwUpdate#checkForUpdate
[3]: https://github.com/angular/angular/blob/9d9d05911dbd6e2f30e4c7bced0e41fd20ec4285/aio/content/examples/service-worker-getting-started/src/app/prompt-update.service.ts#L15
[4]: https://angular.io/api/service-worker/SwUpdate#activateUpdate
[5]: https://github.com/angular/angular/blob/96c6139c9ab35aa6ab2330a5a79a5906d5c2e8be/packages/service-worker/src/update.ts#L44-L54
[6]: https://angular.io/guide/docs-style-guide#hard-coded-snippets
Fixes #43665
PR Close #46960
2022-09-06 09:11:58 -07:00
4ac5ea3ee8
docs: update security guide ( #47296 )
...
Update the security guide to our new vulnerability intake process.
PR Close #47296
2022-08-30 18:03:44 +00:00
fed626d4cb
docs(common): fix code examples in image directive guide ( #47269 )
...
PR Close #47269
2022-08-26 09:20:58 -07:00
40d8821dde
docs: add image directive guide ( #47155 )
...
PR Close #47155
2022-08-24 12:16:48 -07:00
e05d6db2cd
docs: add Angular & JavaScript Master Podcast to resources list ( #47227 )
...
PR Close #47227
2022-08-23 16:20:44 -07:00
e2be52671e
docs: update peek-a-boo example ( #47219 )
...
The peek-a-boo example image does not exactly reflect what happens. This updates the hook table and the image of the peek-a-boo output. Closes #40138
PR Close #47219
2022-08-22 16:03:19 -07:00
e717980d77
docs: add Angular Master website to resources list ( #47129 )
...
PR Close #47129
2022-08-22 16:02:19 -07:00
e5de9a0722
docs: Add Bob Watson as a member of the Angular team ( #47217 )
...
PR Close #47217
2022-08-22 10:28:05 -07:00
6277dd70d4
docs: remove duplicated styles ( #47143 )
...
PR Close #47143
2022-08-12 18:18:20 +00:00
d4678316b4
docs: fix code samples formatting in tutorial ( #47144 )
...
PR Close #47144
2022-08-12 18:17:26 +00:00
757684b705
docs: set titles to sentence case ( #47083 )
...
* update overview and reviewing topics to accommodate new ToC
* incorporate edits from peer reviews
PR Close #47083
2022-08-12 18:04:25 +02:00
1329707327
docs: clarify use of unsubscribe with HttpClient ( #47127 )
...
fix : #46542
PR Close #47127
2022-08-12 09:58:04 +00:00
adda3632d7
docs: add NG Poland 2022 and JS Poland 2022 to events ( #47128 )
...
PR Close #47128
2022-08-11 17:03:07 +00:00
777803c9fe
docs: Moving a div down in tutorial toh-pt6.md ( #47095 )
...
PR Close #47095
2022-08-11 16:09:51 +00:00
8d0d6d941d
docs: rename duplicate header ( #47110 )
...
PR Close #47110
2022-08-11 16:08:38 +00:00
01f5598571
docs: remove duplicated sentence ( #47126 )
...
PR Close #47126
2022-08-11 16:04:15 +00:00
4e3fc7eac8
docs: clarify providers' injection in lazy loaded modules ( #47094 )
...
Addresses https://github.com/angular/angular/issues/47059
I try to keep the edit as concise as possible because adding any further
explanation would bring to much deeper info compared to the topic of the
page
Removed some convoluted info and replaced with a link to a page that
should focus on the specific aspect of the matter.
Conditional is obliged because IMHO that page should have a dedicated
paragraph explaining various ways of populating different injectors with
providers, and maybe integrating the interesting parts from the recent
created page about standalone app.
PR Close #47094
2022-08-10 10:45:03 -07:00
e4aee2b83d
docs: add antoniocardenas to GDE resources ( #47033 )
...
PR Close #47033
2022-08-09 10:02:11 -07:00
5e15e4f0c4
docs: change "zone" to "ngZone" in an example ( #47079 )
...
Change requesting "this.zone" to "this.ngZone" in the Plotly example, as it corresponds to the name declared in the constructor.
PR Close #47079
2022-08-09 10:01:26 -07:00
340fa465ce
docs: add more documentation about lint messages ( #47019 )
...
Adds suggestions for how to resolve the most common messages produced by the documentation linter.
Adds links to the Proselint and other style tests to the new documentation.
Updates pullapprove and navigation.
PR Close #47019
2022-08-08 11:34:56 -07:00
ddef8e2897
docs: updated reference link to NativeScript/Angular documentation ( #47063 )
...
PR Close #47063
2022-08-08 11:34:20 -07:00
951d02e1de
docs: fix dependecy injection documentation page typos ( #47057 )
...
PR Close #47057
2022-08-08 11:33:04 -07:00
974a71c437
fix(docs-infra): fix nav css on tutorial tour of heroes ( #47064 )
...
Fix the navigation button to work properly by the css style applied when the button is active, on tutorial Tour of Heroes.
PR Close #47064
2022-08-08 11:32:40 -07:00
4ae8b2e12c
docs: fix text formatting for paragraph in Hierarchical injectors ( #47067 )
...
Paragraph of text is not wrapped into `p` tag due to missing empty line after the `div` block. The fix is just add an empty line.
PR Close #47067
2022-08-08 11:31:44 -07:00
7f992326e4
docs: update link to the TypeScript handbook ( #47075 )
...
Closes #47070
PR Close #47075
2022-08-08 11:31:18 -07:00
561cd84901
docs: fix link in dependency injection guide ( #47055 )
...
PR Close #47055
2022-08-08 09:23:06 -07:00
0920a15139
docs: update dependency injection content ( #44466 )
...
Refactored the DI section to improve doc quality, reduce cognitive load and drive consistency.
- Added an overview with prerequisites and doc cards that point to rest of the DI content
- Added introduction topic with topic purpose, value proposition and "fail fast"
- Broke apart complex concepts into simpler tasks
- Unified tone and language for each topic
- Added new content based on SME feedback
- Deleted obsolete content
PR Close #44466
2022-08-05 10:06:13 -07:00
Joe Martin (Crowdstaffing)