22818 Commits

Author SHA1 Message Date
dario-piotrowicz 9255d0b05d fix(docs-infra): fix aio homepage breaking on certain widths (#44126)
the aio homepage has a fixed width for its hero content,
that is not handling well certain window widths, fix that by removing
the fixed width and tweaking related media queries

PR Close #44126
2021-11-19 19:32:29 +00:00
Kristiyan Kostadinov 48ca7dce4f fix(compiler-cli): interpret string concat calls (#44167)
These changes add support for interpreting `String.prototype.concat` calls. We need to support it, because in TypeScript 4.5 string template expressions are transpiled to `concat` calls, rather than string concatenations. See https://github.com/microsoft/TypeScript/pull/45304.

PR Close #44167
2021-11-19 19:30:59 +00:00
Kristiyan Kostadinov 2e6b07ab5c refactor(core): clean up leftover isDevMode usages (#44208)
Removes a couple of leftover calls to `isDevMode`.

PR Close #44208
2021-11-19 19:30:20 +00:00
JoostK b930547ffd fix(core): support cyclic metadata in TestBed overrides (#44215)
The TestBed APIs to override metadata would crash when the metadata
contained objects with cyclic references. Metadata overrides use the
JSON serialized representation of a value to compare objects, which
throws an error if the value has cyclic references. This commit avoids
the error by replacing multiple occurrences of the same object using
a unique string representation for the object.

Fixes #43948

PR Close #44215
2021-11-19 19:27:08 +00:00
George Kalpakas 894aaea80b refactor(elements): remove unneeded Custom Elements polyfill from docs examples (#44214)
In PR #43975, the `Angular Elements` guide was updated to remove
mentions of the Custom Elements-related polyfills, since they are no
longer necessary in v13+ (due to all CLI projects being ES2015+ and all
supported browsers natively supporting Custom Elements).

This commit updates the related docs example boilerplate to not include
the unneeded `@webcomponents/custom-elements` polyfill.

PR Close #44214
2021-11-19 18:46:16 +00:00
George Kalpakas e397a4c813 docs(docs-infra): remove obsolete mention of skipping HTTPS-related audits (#44214)
Since commit 6e40551394, the
`audit-web-app` script no longer needs to skip HTTPS-related audits.
Update the docs comment to reflect that.

PR Close #44214
2021-11-19 18:46:16 +00:00
Renovate Bot 7e121e4b55 build: update dependency @angular-eslint/builder to v13 (#44222)
PR Close #44222
2021-11-19 18:43:59 +00:00
Renovate Bot f4c150114b build: update dependency @angular-eslint/template-parser to v13 (#44226)
PR Close #44226
2021-11-19 18:43:11 +00:00
George Kalpakas 76833aa85d build(docs-infra): upgrade cli command docs sources to b8e198ba5 (#44212)
Updating [angular#master](https://github.com/angular/angular/tree/master) from
[cli-builds#master](https://github.com/angular/cli-builds/tree/master).

##
Relevant changes in
[commit range](https://github.com/angular/cli-builds/compare/afd86f0cd...b8e198ba5):

**Modified**
- help/new.json

PR Close #44212
2021-11-18 21:30:26 +00:00
dario-piotrowicz 155742e305 refactor(animations): improve some animations comments (#44203)
Fix various typos and also improve sentences (by making them more clear
or grammatically correct) present in comments inside the animations package

PR Close #44203
2021-11-18 21:12:54 +00:00
Dylan Hunn 213105c542 ci: add dylhunn to review groups for forms. (#44204)
This is needed so I can review forms PRs that affect public API.

PR Close #44204
2021-11-18 10:24:28 -08:00
Ravi Chandra 88c656487d docs: remove tslint references from file structure document (guide/file-structure) (#44202)
remove tslint references from the file structure documentation as angular cli no more generates tslint configuration files by default

Fixes #44163

PR Close #44202
2021-11-18 10:21:31 -08:00
Renovate Bot 8330520a0d build: update dependency lighthouse to v9 (#44184)
PR Close #44184
2021-11-18 10:20:38 -08:00
Paul Gschwendtner 9c40f6c92c build: update extract js module output target to reflect latest API changes (#44145)
The API of the `extract_js_module_output` rule has changed with the
latest build of the shared dev-infra package. This commit adds the
missing attributes to the targets using this rule, avoiding the
CI failures as these attributes are mandatory.

Note: For NPM packages the linker mappings are not relevant, neither
do we want to include sources from the external NPM packages inside
those.

PR Close #44145
2021-11-18 10:17:14 -08:00
Renovate Bot 6d8a889898 build: update angular (#44145)
PR Close #44145
2021-11-18 10:17:14 -08:00
Andrew Kushnir 38c02e13a5 fix(forms): make the FormControlStatus available as a public API (#44183)
This commit makes the `FormControlStatus` symbol available as a public API. The symbol itself
was intended to become a part of the public API, but due to the missing re-export, the symbol
remains private.

Fixes #44176.

PR Close #44183
2021-11-17 10:37:28 -08:00
Andrew Kushnir 65597d650b refactor(forms): inherit ngOnChanges hooks from the base class (#43945)
This commit updates the code of the min/max and minlength/maxlength validator directives to inherit `ngOnChanges` hooks from the base class (the `AbstractValidatorDirective` one), rather than implementing the hooks on the child classes. This was needed to avoid issues with hooks inheritance in ViewEngine, but since it's deprecated, the code can be cleaned up.

PR Close #43945
2021-11-17 10:36:40 -08:00
Alan Agius 6474c3da8e ci: remove cla/google from required statues (#44197)
The CLA tools no longer report statuses as it is being run as Github actions.

PR Close #44197
2021-11-17 10:35:10 -08:00
Marc Redemske 6a2d8e20e9 docs: remove redudant word in goldens/README.md (#44192)
PR Close #44192
2021-11-17 10:34:08 -08:00
Pete Bacon Darwin e0c736066c build(docs-infra): ensure overloaded functions render correctly (#44090)
If there were 1 or 2 additional overloads on a free-standing function in the API the overloads were not being shown.

Also the type of overload parameters were not being escaped correctly.

PR Close #44090
2021-11-17 10:33:10 -08:00
Andrew Kushnir dbc46d68b9 docs: deprecate factory-based signature of the downgradeModule function (#44090)
DEPRECATED:

The `downgradeModule` function calls with NgModule factories are deprecated. Please use NgModule class based `downgradeModule` calls instead.

PR Close #44090
2021-11-17 10:33:10 -08:00
profanis 80a90f0ad7 docs: add profanis to GDE resources (#44147)
PR Close #44147
2021-11-17 10:32:25 -08:00
Andrew Kushnir 90a4ae1dd7 release: cut the v13.1.0-next.2 release (#44201) 13.1.0-next.2 2021-11-17 09:48:22 -08:00
Andrew Kushnir b558d4e2c1 docs: release notes for the v13.0.2 release (#44200) 2021-11-17 09:45:42 -08:00
fusho-takahashi 6c618de22e docs: Adding type annotation to ngOnInit() to make it consistent with the class structure produced by the CLI (#43579)
PR Close #43579
2021-11-16 14:09:51 -08:00
Armen Vardanyan 130f06e6b5 docs: add armen vardanyan to GDE resources (#43919)
PR Close #43919
2021-11-16 14:09:01 -08:00
Joey Perrott 8ce9a60516 build: update to latest commit for feature-request github action (#44191)
Updating as this fixes a permissions error.

PR Close #44191
2021-11-16 14:08:24 -08:00
Andrew Kushnir aa4d7d2715 ci: update pullapprove.yml (#44193)
This commit updates the PullApprove config, since Zach is currently focused on improving Components.

PR Close #44193
2021-11-16 14:07:19 -08:00
Paul Gschwendtner 5a24f96792 refactor(elements): remove non-existent schematic collection breaking with ng add (#44187)
Removes a non-existent schematic collection wired up for
`@angular/elements` that has been removed
with: https://github.com/angular/angular/commit/619b7cc3857b34598a0036f8ebf9bc2eb27f5507.

Fixes #44160.

PR Close #44187
2021-11-16 12:03:41 -08:00
Dylan Hunn 93036542f9 ci: add dylhunn to review groups for size, piblic api, minimum, and circular (#44190)
This is needed so I can review forms PRs that affect public API.

PR Close #44190
2021-11-16 12:02:14 -08:00
dario-piotrowicz 00ae55c3fb docs(animations): improve wording for animation example (#44168)
improve the wording of the text explaining an animation
code snippet as that can be misinterpreted

resolves #43952

PR Close #44168
2021-11-16 09:45:14 -08:00
Ramesh Thiruchelvam 6d2276e17f test: type spy objects in test example (#44170)
Example for test doesn't use typing for Jasmine Spy objects. Updated 
them with `SpyObj<T>` typing as in the Angular Documentation.

See https://angular.io/guide/testing-services

PR Close #44170
2021-11-16 09:38:43 -08:00
Martin von Gagern aac579d976 refactor(router): add type annotation for UrlSegment.parameterMap (#44175)
Having the type specified explicitly makes the API reference more readable.
PR Close #44175
2021-11-16 09:36:17 -08:00
Joey Perrott b7fd9ebf1d ci: remove cla: yes from required labels (#44179)
Remove `cla: yes` from the require labels for merging as the CLACheck
tool no longer relies on labels.

Enforcement of the CLA being signed is still enforced by the status check
which is visible both in Github as well as checked by merge tooling.

PR Close #44179
2021-11-15 11:21:56 -08:00
Pete Bacon Darwin 265e9e3cb0 build: add instructions for getting Angular version for bug report (#44159)
The template asked for the Angular version but did not say how to get it.
Closes #44158

PR Close #44159
2021-11-15 11:21:05 -08:00
Joey Perrott 44890437ae build: update to yarn v1.22.17 (#44150)
Update to the latest version of yarn, 1.22.17.

PR Close #44150
2021-11-15 11:19:05 -08:00
Andrew Scott f817e30405 release: cut the v13.1.0-next.1 release (#44141) 13.1.0-next.1 2021-11-10 15:53:08 -08:00
Andrew Scott f3d512c6ed docs: release notes for the v13.0.1 release (#44140) 2021-11-10 15:49:11 -08:00
Joey Perrott 7a48c159f2 build: update to latest @angular/dev-infra-private to address issues related to verifying environment (#44137)
Update to the latest package which properly checks if the running version of ng-dev is the version
described in yarn lock.

PR Close #44137
2021-11-10 23:38:34 +00:00
Andrew Kushnir 16326058bf refactor(core): format recently updated file to comply the lint rules (#44136)
This commit updates a file that was changed recently, but that change triggered the `lint` CI job to fail, since the lint rules were slightly changed.

PR Close #44136
2021-11-10 23:36:56 +00:00
dario-piotrowicz 0bd01ca64a refactor(core): move outdated comment to view.ts (#44099)
remove the comment suggesting to use a const enum for ViewEncapsulation in
the renderer3/definitions.ts file and add a similar comment in the
view.ts file in which the enum is defined

Note: the new comment does not contain the suggestion of changing `None`
to `0` as it is unclear what benefits that would bring (for more info
see: https://github.com/angular/angular/pull/44099#discussion_r744157686)

PR Close #44099
2021-11-10 20:42:19 +00:00
Renovate Bot 4809bbd83c build: update angular (#44074)
PR Close #44074
2021-11-10 20:41:38 +00:00
ileil 790dfe5e25 docs: update review tag to topic (#44008)
PR Close #44008
2021-11-10 19:29:13 +00:00
Pete Bacon Darwin 393efa54e6 fix(compiler): ensure that partially compiled queries can handle forward references (#44113)
When a partially compiled component or directive is "linked" in JIT mode, the body
of its declaration is evaluated by the JavaScript runtime. If a class is referenced
in a query (e.g. `ViewQuery` or `ContentQuery`) but its definition is later in the
file, then the reference must be wrapped in a `forwardRef()` call.

Previously, query predicates were not wrapped correctly in partial declarations
causing the code to crash at runtime. In AOT mode, this code is never evaluated
but instead transformed as part of the build, so this bug did not become apparent
until Angular Material started running JIT mode tests on its distributable output.

This change fixes this problem by noting when queries are wrapped in `forwardRef()`
calls and ensuring that this gets passed through to partial compilation declarations
and then suitably stripped during linking.

See https://github.com/angular/components/pull/23882 and https://github.com/angular/components/issues/23907

PR Close #44113
2021-11-10 18:25:16 +00:00
Pete Bacon Darwin 67fbec39cb refactor(compiler): rename R3ProviderExpression and associated helpers (#44113)
This interface will be used in other situations so this change renames it to be more general as `MaybeForwardRefExpression`.

PR Close #44113
2021-11-10 18:25:16 +00:00
Renovate Bot 89aa94b7a2 build: lock file maintenance (#44111)
PR Close #44111
2021-11-10 18:22:57 +00:00
Pete Bacon Darwin 18cc7c8b04 test(compiler): remove IE11 match in JIT compiler tests (#44122)
Since we no longer support (nor test on) IE11 we can remove these matches
for `anonymous` functions.

PR Close #44122
2021-11-10 17:37:24 +00:00
Pavan Kumar Jadda ac7d5faf5f docs: updates typescript configuration file links (#44131)
The links for `tsconfig.json` target and module sections no longer valid. This commit updates the document with correct links
PR Close #44131
2021-11-10 17:37:02 +00:00
Pei Wang 7ac2a8cd67 ci: Windows support for tsec_test. (#43924)
Contents of generated tsconfig for tsec_test now depend on whether
Bazel uses symlinked runfiles for nodejs_test. The current
implementation assumes that symlinked runfiles are not available
on Windows.

PR Close #43924
2021-11-10 04:36:48 +00:00
raman 236bdff831 fix(platform-browser): use correct parent in animation removeChild callback (#44033)
Animation's `onRemovalComplete` callback is using incorrect `parentNode`.
Should be parentNode provided by `delegate.parentNode(element)` instead of direct `element.parentNode`.
This is not a problem with default renderer but can cause problems with custom renderer if it uses another
logic to add/remove nodes.

Fixes #44023

PR Close #44033
2021-11-10 01:21:56 +00:00