Andrew Scott
ca0f057491
test(router): refactor tests to not use deprecated loadChildren ( #43578 )
...
Many of the tests in the router code use the deprecated loadChildren as a string. This
has been deprecated for years and can easily be changed to just a function that
returns the module.
PR Close #43578
2021-09-29 11:14:09 -07:00
Chris
e3e424e7ca
docs: clarify description of :host and :host-context selectors ( #41332 )
...
Fixes #39466
PR Close #41332
2021-09-29 10:00:07 -07:00
Daniel Díaz
7a68cd75f2
docs: fix typo in observables file ( #43630 )
...
PR Close #43630
2021-09-29 09:59:39 -07:00
Pete Bacon Darwin
59ad3997bc
build(docs-infra): ensure all overloads are shown in interfaces ( #43614 )
...
In the API docs, concrete classes do not list the "implementation" overload on a method, since this is not strictly part of its API.
There is already a special case for abstract methods that do not have such an implementation overload.
But we were missing the case where the method was part of an interface. In interfaces none of the methods have implementation overloads.
Fixes #43001
PR Close #43614
2021-09-29 09:58:48 -07:00
dario-piotrowicz
8da56d78d9
docs: amend wrong links to async pipe ( #43576 )
...
PR Close #43576
2021-09-29 09:57:59 -07:00
Raj Sekhar
c9cbe6e7d8
docs: fix broken link to measure performance ( #43628 )
...
* "Chrome DevTools Network Performance page" was pointing to a broken link, that was giving 404 error
* The new link points to the right article where it explains the resource timing & network analysis
PR Close #43628
2021-09-28 14:43:47 -07:00
Ricardo Chavarria
4cc9c397dc
docs: Add Ricardo Chavarria to GDE resources ( #43571 )
...
update size image
update preview
docs: replace an avatar with smaller size
Change order
PR Close #43571
2021-09-27 14:25:57 -07:00
Adrien Crivelli
9d3c2d517d
docs(router): params or queryParams are not advised against ( #43562 )
...
According to @atscott:
> We no longer speculate about future deprecations. There are no current plans to remove
> `params` or `queryParams` and there's no benefit to advising against their use.
PR Close #43562
2021-09-27 14:21:11 -07:00
Rafael Santana
a8e84f6920
docs: close tags properly ( #43610 )
...
PR Close #43610
2021-09-27 10:54:56 -07:00
enisfr
dac84dd9e1
docs: links added for each builder schema ( #43564 )
...
closes #43542
Signed-off-by: enisfr <enisfurkane@gmail.com >
docs: links pointed to the schema files.
closes angular#43542
docs: tslint removed.
closes angular#43542
docs: typo.
closes angular#43542
PR Close #43564
2021-09-27 10:51:49 -07:00
Teri Glover
28b7f79a63
docs: Edits to remove jargon ( #43000 )
...
PR Close #43000
2021-09-27 10:44:22 -07:00
George Kalpakas
9a5086e9fe
fix(docs-infra): display deprecation notes for properties ( #43566 )
...
Previously, deprecation notes for deprecated class/interface properties
were not shown in the API docs. This commit fixes it by ensuring that
deprecation notes are shown for properites (similar to how it works for
methods).
PR Close #43566
2021-09-24 10:56:05 -07:00
Virginia Dooley
d585c78ab3
docs: reviewed tag added ( #43472 )
...
PR Close #43472
2021-09-24 10:51:40 -07:00
Virginia Dooley
62e982d7e0
docs: review tag added ( #43469 )
...
PR Close #43469
2021-09-24 10:50:21 -07:00
Joe Martin (Crowdstaffing)
1c7545559d
docs: update review date ( #43245 )
...
docs: Update review date for last content update.
PR Close #43245
2021-09-23 15:40:36 -07:00
Joe Martin (Crowdstaffing)
406abf2372
docs: add subtopics for internationalization ( #43245 )
...
Add subtopics for internationalization guide.
PR Close #43245
2021-09-23 15:40:36 -07:00
Joe Martin (Crowdstaffing)
579b05a43c
docs: update content ( #43245 )
...
Update content per review.
PR Close #43245
2021-09-23 15:40:36 -07:00
Joe Martin (Crowdstaffing)
035b3f7ddb
docs: update punctuation
( #43245 )
...
Update punctuation per review.
Co-authored-by: TeriGlover <teriglover@google.com >
PR Close #43245
2021-09-23 15:40:36 -07:00
Joe Martin (Crowdstaffing)
2dfe4ecda5
docs: update content
( #43245 )
...
Update content per review.
Co-authored-by: TeriGlover <teriglover@google.com >
PR Close #43245
2021-09-23 15:40:36 -07:00
Joe Martin (Crowdstaffing)
38ba02cbdc
docs: update link ( #43245 )
...
Update link per review.
PR Close #43245
2021-09-23 15:40:36 -07:00
Joe Martin (Crowdstaffing)
3609f90899
docs: update content ( #43245 )
...
Update content per review.
PR Close #43245
2021-09-23 15:40:36 -07:00
Joe Martin (Crowdstaffing)
73a5b9e8ed
docs: update punctuation
( #43245 )
...
Update punctuation per review.
Co-authored-by: TeriGlover <teriglover@google.com >
PR Close #43245
2021-09-23 15:40:35 -07:00
Joe Martin (Crowdstaffing)
719f2b11a8
docs: update grammar
( #43245 )
...
Update grammar per review.
Co-authored-by: TeriGlover <teriglover@google.com >
PR Close #43245
2021-09-23 15:40:35 -07:00
Joe Martin (Crowdstaffing)
ee98c134c0
docs: update content ( #43245 )
...
Update content per review.
PR Close #43245
2021-09-23 15:40:35 -07:00
Joe Martin (Crowdstaffing)
5922763786
docs: update spelling
( #43245 )
...
Update spelling per review.
Co-authored-by: TeriGlover <teriglover@google.com >
PR Close #43245
2021-09-23 15:40:35 -07:00
Joe Martin (Crowdstaffing)
0cf60a8f72
docs: add new internationalization links ( #43245 )
...
Update link for subtopics of internationalization guide. Clean up markdown.
PR Close #43245
2021-09-23 15:40:35 -07:00
Joe Martin (Crowdstaffing)
6cbb79c421
docs: add redirect for internationalization ( #43245 )
...
Add redirect for internationalization guide. Add test for redirect.
PR Close #43245
2021-09-23 15:40:35 -07:00
Joe Martin (Crowdstaffing)
a03b8e42d7
docs: add subtopics for internationalization to toc ( #43245 )
...
Add subtopics for internationalization guide to toc.
PR Close #43245
2021-09-23 15:40:35 -07:00
Joe Martin (Crowdstaffing)
587091d993
docs: add subtopics for internationalization ( #43245 )
...
Add subtopics for internationalization guide.
PR Close #43245
2021-09-23 15:40:35 -07:00
Dario Piotrowicz
e9beccb672
docs: fix typo in dynamic forms page ( #43543 )
...
resolves #43536
PR Close #43543
2021-09-23 14:43:35 -07:00
Teri Glover
85a0cb3082
docs: Edits to remove jargon ( #43023 )
...
PR Close #43023
2021-09-23 14:41:17 -07:00
Teri Glover
54050e5927
docs: Edits to remove jargon ( #42965 )
...
PR Close #42965
2021-09-23 14:35:54 -07:00
Teri Glover
e9e85919bf
docs: Edits to remove jargon ( #42950 )
...
PR Close #42950
2021-09-23 14:35:22 -07:00
Teri Glover
9bd6fd62ff
docs: Edits to remove jargon ( #42904 )
...
PR Close #42904
2021-09-23 14:34:42 -07:00
Teri Glover
6e109c7323
docs: amend links in content-projection guide ( #43009 ) ( #42904 )
...
PR Close #43009
PR Close #42904
2021-09-23 14:34:42 -07:00
Teri Glover
1849ed1631
docs: Edits to remove jargon ( #42904 )
...
PR Close #42904
2021-09-23 14:34:42 -07:00
Teri Glover
0201593c66
docs: Edits to remove jargon ( #42904 )
...
PR Close #42904
2021-09-23 14:34:42 -07:00
dario-piotrowicz
19c61bf859
docs(service-worker): improve service worker guides ( #43508 )
...
improve slightly the angular.io guides related to service workers, by
means of fixes, styling, information and clarity changes
PR Close #43508
2021-09-22 17:48:39 +00:00
George Kalpakas
d5881329cd
build(docs-infra): upgrade cli command docs sources to eb7fba335 ( #43533 )
...
Updating [angular#12.2.x](https://github.com/angular/angular/tree/12.2.x ) from
[cli-builds#12.2.x](https://github.com/angular/cli-builds/tree/12.2.x ).
##
Relevant changes in
[commit range](https://github.com/angular/cli-builds/compare/56c5962df...eb7fba335 ):
**Modified**
- help/new.json
PR Close #43533
2021-09-22 16:56:54 +00:00
Xiaohanxu1996
1e03bed706
docs: remove duplicate import from @angular/core ( #43530 )
...
PR Close #43530
2021-09-22 16:16:05 +00:00
George Kalpakas
3cc8c7ee25
fix(docs-infra): add a "skip to content" link for better accessibility ( #43460 )
...
Add a link at the top of the page that allows skipping directly to the
main content area. This allows people using assistive technologies to
skip navigation-related parts of the page which are presented before the
main content.
Related resources:
- [www.w3.org](https://www.w3.org/TR/WCAG20-TECHS/G1.html )
- [accessibility.oit.ncsu.edu](https://accessibility.oit.ncsu.edu/it-accessibility-at-nc-state/developers/accessibility-handbook/mouse-and-keyboard-events/skip-to-main-content )
- [css-tricks.com](https://css-tricks.com/how-to-create-a-skip-to-content-link )
---
Example implementations on other websites:
- **[accessibility.oit.ncsu.edu](https://accessibility.oit.ncsu.edu/ )**:

- **[smile.amazon.com](https://smile.amazon.com/ )**:

- **[chase.com](https://chase.com/ )**:

- **[css-tricks.com](https://css-tricks.com/ )**:

- **[github.com/angular/angular](https://github.com/angular/angular )**:

- **[news.sky.com](https://news.sky.com/ )**:

- **[youtube.com](https://youtube.com/ )**:

---
Angular.io implementation:
- **[angular.io](https://angular.io/ )**:

Fixes #42936
PR Close #43460
2021-09-21 16:12:40 +00:00
George Kalpakas
875bbd3d4e
fix(docs-infra): correctly handle in-page anchor links ( #43460 )
...
Previously, anchor links that were supposed to point to fragments inside
the current page (e.g. `href="#something"`) would end up navigating to
the homepage (`/`). This was due to them being resolved relative to the
base URL, which is set to `/` (via `<base href="/">`). See also
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base#in-page_anchors .
This commit fixes this issue by handling such links specially in
`LocationService#handleAnchorClick()` and prepending the current path to
the URL.
This will also be useful for implementing a "skip to content" link as
described in #42936 .
PR Close #43460
2021-09-21 16:12:40 +00:00
George Kalpakas
cea9d04330
fix(docs-infra): focus elements when scrolling to them (if focusable) ( #43460 )
...
When using `ScrollService#scrollToElement()` to scroll to a specific
element, also focus the element if it is focusable (i.e. if it has a
`focus()` method).
This will be useful for implementing a "skip to content" link as
described in #42936 .
PR Close #43460
2021-09-21 16:12:40 +00:00
George Kalpakas
b07642cf57
fix(docs-infra): improve accessibility of contributor cards ( #43460 )
...
Improve the accessibility of contributor cards (in `/about`) by making
them easier to navigate via keyboard:
- Show the (otherwise hidden) contributor info links on focus.
- Make the "View bio" link focusable via keyboard (to give a clearer
indication that users can click to view the bio - although technically
the click is handled by an ancestor).
- Make the flipped cards focusable via keyboard (so it is possible to
click them to unflip).
PR Close #43460
2021-09-21 16:12:40 +00:00
George Kalpakas
b9900cea7e
fix(docs-infra): improve accessibility of button groups ( #43460 )
...
Improve the accessibility of button groups (such as those seen in
`/about` and `/resources` to choose between the different categories)
by making them easier to navigate via keyboard:
- Make the individual buttons focusable via keyboard.
(Previously, they were not focusable - despite being anchor elements,
because they were lacking an `href` attribute.)
- Give focused buttons a different style.
PR Close #43460
2021-09-21 16:12:40 +00:00
Teri Glover
aa8e8db047
docs: Edits to remove jargon ( #42928 )
...
PR Close #42928
2021-09-20 22:50:59 +00:00
Teri Glover
8e283cb24c
docs: Edits to remove jargon ( #42918 )
...
PR Close #42918
2021-09-20 22:50:15 +00:00
Teri Glover
859e53b465
docs: Edits to remove jargon ( #42912 )
...
PR Close #42912
2021-09-20 22:49:26 +00:00
Virginia Dooley
2690315b3e
docs: reviewed tag added ( #43493 )
...
PR Close #43493
2021-09-20 17:09:50 +00:00
Virginia Dooley
41d6f3caee
docs: reviewed tag added ( #43490 )
...
PR Close #43490
2021-09-20 17:09:21 +00:00